Page MenuHomePhabricator
Create Task
Maniphest T12806

In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments
Closed, ResolvedPublic
Actions

Description

If you go to D17766 and you scroll to see the diff, in the header it is shown that you have 1 unsubmitted comment. They are not my comments so normally they should not (or not).

Screenshot from 2017-06-07 09-38-17.png (1×1 px, 132 KB)

Revisions and Commits

rP Phabricator
D18103rP8692d673c8ab Fix minor inline comment header button behaviors

Related Objects
Search...

Event Timeline

rabahmeradi renamed this task from differential shows unsubmitted comment of other users to Differential shows unsubmitted comment of other users.Jun 7 2017, 8:06 AM
rabahmeradi created this task.
epriestley renamed this task from Differential shows unsubmitted comment of other users to In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments.Jun 7 2017, 10:20 AM
epriestley added a parent task: T12733: (2017 Week 20) Inline Comments Errata / Feedback.
epriestley added a subscriber: epriestley.

This is because of the synthetic comment from Lint near line 108 of DiffusionHistoryController.php, not because of the comment in the screenshot.

Synthetic comments should not be treated as unsubmitted/draft comments.

epriestley mentioned this in T12733: (2017 Week 20) Inline Comments Errata / Feedback.Jun 8 2017, 1:05 AM
epriestley added a revision: D18103: Fix minor inline comment header button behaviors.Jun 8 2017, 2:06 AM
epriestley closed this task as Resolved by committing rP8692d673c8ab: Fix minor inline comment header button behaviors.Jun 8 2017, 2:10 AM
epriestley added a commit: rP8692d673c8ab: Fix minor inline comment header button behaviors.
Phabricator · Built by Phacility