oh thx :)

I'm planning to fix these, since I think they're easy or actually annoying, and just let everything else sit until we iterate or someone else notices:

In Phriction:

The only Maniphest thing I've caught is this:

• Maybe drop "Created" property? Doesn't seem terribly useful to me. This might have been a placeholder at one time to make sure that we always had something so the UI didn't render weird, but I think there's now no case where we have no properties. Fine to keep if you just like having it.
  • The list has lost icon colors. Maybe intentional? Makes things a little harder to pick out visually to me:

Probably pre-existing, but in Pholio, mentioning users in the description does not subscribe them. Embedding images in the description does not attach them to the mock properly. This suggests that the description is not being returned from some getRemarkupBlocks() sort of method although I don't remember which offhand.

These hashtag transactions should use a renderValue() style to render the specific values (for example "drip" should be dark/italic, not plain grey text), we might need to add a renderValueList() or something:

This state on projects might be a little misleading: here, theproject supports subprojects/milestones but the viewer does not have permission to edit the project, so they can not actually create them. The text means "It is possible to create milestones for this project" but the phrasing implies the viewer, specifically, can:

Oh, no it didn't. I just can't read.

Oh, yeah -- that technically promoted last week but I probably should really be looking at the last two weeks, since the previous roundup in T12685.

Changes this week are:

I also can't reproduce the original report in the general case: when I type text into the "Create Task" form, click a notification to navigate away, then press "Back", my text is recovered. This is true whether Quicksand is enabled or not.

That wouldn't actually address the original problem here (accidentally setting your computer on fire and losing work) but would address the issue in T12731.

A possible attack on this is via whatever future abuse system we ultimately might build (T10215).

This looks more like donating than like buying a service. That's ok; but there are established methods to manage such things, usually involving a non-profit entity which accepts members and where members get some voting/decision-making privilege above some threshold of contribution (but you could also call it a donor council or a sponsorship with benefits).

Your system has php-fcgi installed on the CLI (note cgi-fcgi in the output). This is incorrect. Replace this binary with a php-cli SAPI binary.

How could we make it more clear that we require version information for bug reports? Here's how we currently communicate this, but it seems like it didn't work well in this case. Is there a way we could improve this or make it more clear?

Please read Contributing Feature Requests carefully before filing feature requests. This does not describe a root problem; see Describing Root Problems.

Can you show me the output of this command?

• I believe D17959 should resolve this.
• The new algorithm tends overall toward dispersing tasks over time, and clusters with more tasks should tend to cover an larger range, roughly linearly.
• The first few drags after the new algorithm is available may be very slow, since they'll spread the existing clusters out. After each large cluster has dispersed, all future non-pathological operations should be fast. (One pathological operation is to insert a million tasks at the same priority without performing any dragging, then perform a drag.) It's possible that cluster dispersal is fast enough that this isn't a big deal, although I may also just write a migration to normalize task subpriorities for everyone in advance of the new stuff landing so we pay this cost upfront rather than on-first-interacion.
• master has a bunch of churn already, it's late in the week, and this change is moderately risky (it's hard to undo damage if I got something wrong), so I don't expect it to make it into this week's stable release.

This and T8588 have been a multi-year fishing expedition which I'm far from thrilled about, but I'll deal with this. 🐳

Currently, Fixes T123 in a commit message means this:

Yeah, some workarounds are:

you take your made-up ghost bugs and go sit in the corner and think about what you've done

Yeah, give us a bit longer for general feedback -- I think I'll file a feedback task tomorrow with the release cut.

I eventually muddled though things, and I believe work here has now substantially concluded.

I'm also toying with the idea of "Shift+Click" on "Reply" to "Reply-with-Quote" but the only way to discover that would be to read the documentation.

(I normally think of myself as like a 95th percentile power user, and don't use keyboard shortcuts at all in Differential today, and suspect I still won't after these changes. However, I'm also an elite mouse power user, per J769.)

If nothing changes, I was thinking of leaving these top-level:

I'm not sure if D17908 is going to stick, but if it does we more reasonably have room to add a caret menu here. I'm not planning to necessarily pursue this in the current iteration, but I believe there are no longer any meaningful technical blockers, just some product questions which will more or less resolve themselves if everything sticks.

I just want to note that we fixed this in less than 5 years. Learn how in my upcoming book "Unbelievably Agile Ultra-High-Velocity Software Development Which Goes So Fast it Almost Must Account For Relativistic Effects".

If a linter could theoretically catch it (conventions, space, formatting, etc.), I think a linter should (in a perfect world) be catching it.

Broadly, the technical stuff here is in fairly good shape now but I still don't truly understand what problem we're solving. From earlier, I dug this up:

I'm just going to merge this into T8250. I'm still unsure what's to become of this, but I think however that resolves will cover this.

This is effectively not a problem at HEAD, although I may make it a problem again soon. But I'm also not sure if anyone else has actually hit this, and it's a pain to fix, and even in the worst case it's less bad now because we pointer-events this. I'm just going to punt for now, let the dust settle on T12616, and we can revisit this if anyone's actually hitting it after all that.

Per T10563#221154, D17938 makes "reply" put comments in the right (threading-respecting) place and marks this complete.

I can not play the .mov file in Chrome no matter what I try:

Here's a screenshot of this working correctly for me in Safari:

We could say "checkout failed, you might have a bad hook" but I'd want to wait for more users to run into this first, and maybe try to pursue a fix in git with the upstream.

There doesn't appear to be any reasonable way for us to perform something like git checkout --skip-hooks, and I think we shouldn't even if we could.

Can you show me the output of these commands?

I can no longer reproduce the edit issue at HEAD.

In this screenshot:

On mobile, the hamburger menu icon is not aligned properly:

This no longer reproduces for me at HEAD of master.

I papered over this in the short term by restarting daemons for all instances;

We currently have three distinct selection states which I think are a little muddy. The first is the keyboard selection cursor, which shows what is selected with the keyboard:

@nemobis, can you walk me through the major differences you see between the proposal above and the support plans offered by other vendors like GitHub, GitLab, and Atlassian so I can make things more clear?

This is a productive environment, so I could not test to reproduce it and I don't know how can I reproduce it.

Per T12359, we aren't interested in supporting technically-deliverable-but-bizzarely-exotic addresses in the upstream. Feel free to fork to support this kind of address.

I've marked D17919 as fixing this although it only fixes the "hover with your mouse" half. A followup change will fix the "drag-to-select-a-range" half.

I marked D17919 as fixing this. I can't reproduce it after that change (except: the drag-select behavior isn't converted yet) and we're now Quicksand-aware, although it's possible I'm just not doing the right sequence of operations.