Page MenuHomePhabricator
Feed Advanced Search

Today

epriestley requested review of D20471: Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button.
Thu, Apr 25, 3:13 PM
epriestley closed T9821: Allow Harbormaster build plans to run on branch push instead of per-commit as Wontfix.

Please use the Discourse forum for this kind of discussion.

Thu, Apr 25, 2:42 PM · Restricted Project, Harbormaster

Yesterday

epriestley committed rP8f43c773b832: Remove nearly all remaining references to "Autoclose" (authored by epriestley).
Remove nearly all remaining references to "Autoclose"
Wed, Apr 24, 3:29 PM
epriestley closed D20465: Remove nearly all remaining references to "Autoclose".
Wed, Apr 24, 3:29 PM
epriestley committed rP45b9859f0229: Remove "--force-autoclose" from "bin/repository reparse" (authored by epriestley).
Remove "--force-autoclose" from "bin/repository reparse"
Wed, Apr 24, 3:24 PM
epriestley closed D20464: Remove "--force-autoclose" from "bin/repository reparse".
Wed, Apr 24, 3:24 PM
epriestley committed rPa2d3d8edeb93: Move "update related object after commit" to a separate worker in the task queue (authored by epriestley).
Move "update related object after commit" to a separate worker in the task queue
Wed, Apr 24, 1:32 PM
epriestley closed D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 1:32 PM
epriestley added inline comments to D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 1:02 PM
epriestley committed rPb3b1cc64bdd0: When applying transactions, acquire a read lock sooner (authored by epriestley).
When applying transactions, acquire a read lock sooner
Wed, Apr 24, 12:57 PM
Herald updated subscribers of T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Wed, Apr 24, 12:57 PM · Plans, Differential, Harbormaster
epriestley closed D20462: When applying transactions, acquire a read lock sooner.
Wed, Apr 24, 12:57 PM
epriestley committed rP42c02557e4e3: Remove all remaining readers and writers for TABLE_COMMIT (authored by epriestley).
Remove all remaining readers and writers for TABLE_COMMIT
Wed, Apr 24, 12:55 PM
epriestley closed D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Wed, Apr 24, 12:55 PM
epriestley committed rPec0085fd0c7a: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table (authored by epriestley).
Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Wed, Apr 24, 12:54 PM
epriestley closed D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Wed, Apr 24, 12:54 PM
epriestley committed rP7e8dc0742bdc: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()" (authored by epriestley).
Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Wed, Apr 24, 12:53 PM
epriestley closed D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Wed, Apr 24, 12:53 PM
epriestley updated the diff for D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
  • Typechecking.
Wed, Apr 24, 12:47 PM
epriestley committed rPfc92cf438225: Move BlameController away from ancient "TABLE_COMMIT" (authored by epriestley).
Move BlameController away from ancient "TABLE_COMMIT"
Wed, Apr 24, 12:44 PM
epriestley closed D20457: Move BlameController away from ancient "TABLE_COMMIT".
Wed, Apr 24, 12:44 PM
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Wed, Apr 24, 2:02 AM · Differential, Plans
epriestley added a comment to D20462: When applying transactions, acquire a read lock sooner.

I think that's reasonable -- if there are at least, say, 11 consecutive lines affected only by the same indentation level change (or the line is blank), we could show the first 3, fold the middle 5+, then show the last 3.

Wed, Apr 24, 2:00 AM
epriestley added a comment to D20466: Show "hold reasons" on commit page, not on "Edit" page.

!== 0 and !== mask have different meanings when mask has multiple bits set. Today, IMPORTED_CLOSEABLE has just one bit set, so both tests would do the same thing. But the adjacent IMPORTED_ALL mask has several, and using the more general form is safer if IMPORTED_CLOSEABLE ever has multiple bits, or this code gets copy/pasted elsewhere or something.

Wed, Apr 24, 1:59 AM

Tue, Apr 23

epriestley closed T13274: Guide: Overheated Queries as Resolved.

(This seems stable now, and there's no specific action here.)

Tue, Apr 23, 7:34 PM · Infrastructure, Guides
epriestley committed rP70c643c685f8: Simplify implementation of "pure" Chart functions (authored by epriestley).
Simplify implementation of "pure" Chart functions
Tue, Apr 23, 7:30 PM
epriestley closed D20446: Simplify implementation of "pure" Chart functions.
Tue, Apr 23, 7:29 PM
epriestley committed rPedaf17f3fe51: Make chart function argument parsing modular/flexible with 900 pages of error… (authored by epriestley).
Make chart function argument parsing modular/flexible with 900 pages of error…
Tue, Apr 23, 7:26 PM
epriestley closed D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
Tue, Apr 23, 7:26 PM
epriestley updated the diff for D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
  • Typo fix.
Tue, Apr 23, 7:21 PM
epriestley committed rPedda40aa3b93: (stable) Change "Revision Close" story to use commit identities only with no… (authored by epriestley).
(stable) Change "Revision Close" story to use commit identities only with no…
Tue, Apr 23, 6:58 PM
epriestley committed rP7b8ac020b521: Change "Revision Close" story to use commit identities only with no fallback to… (authored by epriestley).
Change "Revision Close" story to use commit identities only with no fallback to…
Tue, Apr 23, 6:57 PM
epriestley closed D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Tue, Apr 23, 6:57 PM
epriestley committed rP2ffc4be4e7df: (stable) Fix "before/after" cursor paging for API call "feed.query" (authored by epriestley).
(stable) Fix "before/after" cursor paging for API call "feed.query"
Tue, Apr 23, 6:57 PM
epriestley committed rPb0b8926c7564: Fix "before/after" cursor paging for API call "feed.query" (authored by epriestley).
Fix "before/after" cursor paging for API call "feed.query"
Tue, Apr 23, 6:51 PM
epriestley closed D20456: Fix "before/after" cursor paging for API call "feed.query".
Tue, Apr 23, 6:51 PM
epriestley committed rP29b2125e3f29: (stable) Fix an issue where internal paging of notifications could fail if some… (authored by epriestley).
(stable) Fix an issue where internal paging of notifications could fail if some…
Tue, Apr 23, 6:45 PM
epriestley committed rPa4a1143b1888: Fix an issue where internal paging of notifications could fail if some… (authored by epriestley).
Fix an issue where internal paging of notifications could fail if some…
Tue, Apr 23, 6:45 PM
epriestley closed D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Tue, Apr 23, 6:45 PM
epriestley requested review of D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
Tue, Apr 23, 6:37 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
Tue, Apr 23, 6:35 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to D20468: Consolidate readers of "differential.revisionID" property.

One note here is that HeraldPreCommitContentAdapter has some similar logic, although it's more low-level.

Tue, Apr 23, 6:08 PM
epriestley requested review of D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
Tue, Apr 23, 6:07 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
Tue, Apr 23, 6:05 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to D20468: Consolidate readers of "differential.revisionID" property.

The "how do we store this data" question kind of relates back to T13056. This is a case where we have edge-like data (Commit Has Related Revision) but we also have metadata (why the two are associated). This currently isn't stored as edge data, but a possibly cleaner approach would be:

Tue, Apr 23, 5:38 PM
epriestley updated the summary of D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:30 PM
epriestley requested review of D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:30 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20468: Consolidate readers of "differential.revisionID" property.
Tue, Apr 23, 5:28 PM · Plans, Diffusion
epriestley requested review of D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Tue, Apr 23, 4:56 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Tue, Apr 23, 4:55 PM · Plans, Diffusion
epriestley updated the task description for T13280: Permanent Refs Errata.
Tue, Apr 23, 4:28 PM · Diffusion
epriestley added a comment to D20436: Make the "git upload-pack" proxy more robust.

The reproduction case for this may be "have a ref which is an annotated tag". Let me see if that works.

Tue, Apr 23, 2:56 PM
epriestley added a comment to D20436: Make the "git upload-pack" proxy more robust.

There's not much of a wire-proto.c to reference. Here's the code that generates the entire thing we're parsing (in Git 2.21-rc1):

Tue, Apr 23, 2:51 PM
epriestley requested review of D20466: Show "hold reasons" on commit page, not on "Edit" page.
Tue, Apr 23, 2:15 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20466: Show "hold reasons" on commit page, not on "Edit" page.
Tue, Apr 23, 2:14 PM · Plans, Diffusion
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

Tue, Apr 23, 1:39 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.

Tue, Apr 23, 1:32 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20465: Remove nearly all remaining references to "Autoclose".
Tue, Apr 23, 12:14 AM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20465: Remove nearly all remaining references to "Autoclose".
Tue, Apr 23, 12:12 AM · Plans, Diffusion

Mon, Apr 22

epriestley added inline comments to D20464: Remove "--force-autoclose" from "bin/repository reparse".
Mon, Apr 22, 11:17 PM
epriestley requested review of D20464: Remove "--force-autoclose" from "bin/repository reparse".
Mon, Apr 22, 11:11 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20464: Remove "--force-autoclose" from "bin/repository reparse".
Mon, Apr 22, 11:10 PM · Plans, Diffusion
epriestley added inline comments to D20463: Move "update related object after commit" to a separate worker in the task queue.
Mon, Apr 22, 10:53 PM
epriestley requested review of D20463: Move "update related object after commit" to a separate worker in the task queue.
Mon, Apr 22, 10:52 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20463: Move "update related object after commit" to a separate worker in the task queue.
Mon, Apr 22, 10:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added inline comments to D20462: When applying transactions, acquire a read lock sooner.
Mon, Apr 22, 10:32 PM
epriestley requested review of D20462: When applying transactions, acquire a read lock sooner.
Mon, Apr 22, 10:27 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20462: When applying transactions, acquire a read lock sooner.
Mon, Apr 22, 10:26 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: D20462: When applying transactions, acquire a read lock sooner.
Mon, Apr 22, 10:26 PM · Plans, Differential, Harbormaster
epriestley added inline comments to D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Mon, Apr 22, 8:31 PM
epriestley requested review of D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Mon, Apr 22, 7:53 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Mon, Apr 22, 7:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Mon, Apr 22, 7:47 PM
epriestley requested review of D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Mon, Apr 22, 7:36 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Mon, Apr 22, 7:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Mon, Apr 22, 7:08 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Mon, Apr 22, 7:06 PM · Diffusion, Harbormaster, Herald, Audit
epriestley requested review of D20457: Move BlameController away from ancient "TABLE_COMMIT".
Mon, Apr 22, 6:49 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20457: Move BlameController away from ancient "TABLE_COMMIT".
Mon, Apr 22, 6:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to Staging Areas on the Diffusion board.
Mon, Apr 22, 6:10 PM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T11502: Expose raw Git refs in the Diffusion UI, but very subtly from Backlog to "Track Only" on the Diffusion board.
Mon, Apr 22, 6:10 PM · Restricted Project, Diffusion
epriestley moved T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance from Backlog to "Track Only" on the Diffusion board.
Mon, Apr 22, 6:07 PM · Plans, Diffusion
epriestley renamed T8370: Index "TODO" comments and other references present in source code from Allow mentions in commit contents to Index "TODO" comments and other references present in source code.
Mon, Apr 22, 6:06 PM · Transactions, Diffusion
epriestley moved T13280: Permanent Refs Errata from Backlog to "Track Only" on the Diffusion board.
Mon, Apr 22, 6:04 PM · Diffusion
epriestley requested review of D20456: Fix "before/after" cursor paging for API call "feed.query".
Mon, Apr 22, 5:43 PM
epriestley added a revision to T13266: Upgrading: Minor Changes to Query Paging / Cursors: D20456: Fix "before/after" cursor paging for API call "feed.query".
Mon, Apr 22, 5:42 PM · Installing & Upgrading
epriestley requested review of D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Mon, Apr 22, 2:28 PM
epriestley added a revision to T13266: Upgrading: Minor Changes to Query Paging / Cursors: D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Mon, Apr 22, 2:27 PM · Installing & Upgrading
epriestley committed rP4e37184862d2: (stable) Don't warn about a locked database value after users run "bin/auth… (authored by epriestley).
(stable) Don't warn about a locked database value after users run "bin/auth…
Mon, Apr 22, 2:00 PM
epriestley triaged T13282: Allow unsetting assignee when bulk editing tasks as Low priority.

Leaving the "Assign To: [...]" field blank will remove assignees, but this is not obvious:

Mon, Apr 22, 1:58 PM · Maniphest

Fri, Apr 19

epriestley committed rPa82a2b84599d: Simplify non-bare working copy rules for the new "git fetch" strategy (authored by epriestley).
Simplify non-bare working copy rules for the new "git fetch" strategy
Fri, Apr 19, 2:06 PM
epriestley closed D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Fri, Apr 19, 2:06 PM
epriestley committed rPe1076528ef76: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >… (authored by epriestley).
Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >…
Fri, Apr 19, 2:05 PM
epriestley closed D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Fri, Apr 19, 2:05 PM
epriestley planned changes to D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.

Sleeping on this, "FunctionChain" should just be a function chain(...) or compose(...) or something, which evaluates as compose(f, g, h)(x) => f(g(h(x))).

Fri, Apr 19, 1:49 PM
epriestley added inline comments to D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.
Fri, Apr 19, 1:25 AM
epriestley requested review of D20454: Treat chart functions as pipe/chain, instead of both configuring and evaluating through function composition.
Fri, Apr 19, 1:14 AM
epriestley accepted D20453: Improve timeline rendering for old macros.
Fri, Apr 19, 1:12 AM
epriestley added inline comments to D20446: Simplify implementation of "pure" Chart functions.
Fri, Apr 19, 12:13 AM
epriestley added a comment to D20452: Separate "accumulate(...)" from Fact functions.

On selecting a domain, you can build a chain like this:

Fri, Apr 19, 12:02 AM