Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 21

epriestley added a comment to T13648: Transaction publishing may stall during mail expansion of package recipients.

The stalled transactions on this host published after I deployed the update.

Wed, Jul 21, 11:39 PM · Transactions
epriestley removed a reviewer for D21498: Fix error handler on PHP 8: Unknown Object (Owners Package).
Wed, Jul 21, 11:36 PM
epriestley removed a reviewer for D21497: Suppress PHP 8 deprecation warning in __arcanist_init_script__: Unknown Object (Owners Package).
Wed, Jul 21, 11:34 PM
epriestley committed rP387d3b4983d7: Resolve deleted packages properly as having no mailable members (authored by epriestley).
Resolve deleted packages properly as having no mailable members
Wed, Jul 21, 9:50 PM
epriestley closed D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:50 PM
epriestley closed T13648: Transaction publishing may stall during mail expansion of package recipients as Resolved by committing rP387d3b4983d7: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:50 PM · Transactions
epriestley requested review of D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:27 PM
epriestley updated the task description for T13661: Give Phame configurable interact policies.
Wed, Jul 21, 9:26 PM · Phacility, Phame
epriestley triaged T13661: Give Phame configurable interact policies as Low priority.
Wed, Jul 21, 9:25 PM · Phacility, Phame
epriestley closed D21687: Correct the flow of edit authority when sending messages to HarbormasterBuild objects.
Wed, Jul 21, 9:24 PM
epriestley added a revision to T13648: Transaction publishing may stall during mail expansion of package recipients: D21707: Resolve deleted packages properly as having no mailable members.
Wed, Jul 21, 9:22 PM · Transactions
epriestley closed D21696: Add a side nav to Conduit API method console pages.
Wed, Jul 21, 9:19 PM
epriestley closed D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
Wed, Jul 21, 9:18 PM
epriestley closed D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
Wed, Jul 21, 9:18 PM
epriestley committed rP3df1e175273f: Add a side nav to Conduit API method console pages (authored by epriestley).
Add a side nav to Conduit API method console pages
Wed, Jul 21, 9:18 PM
epriestley closed D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.
Wed, Jul 21, 9:18 PM
epriestley committed rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods (authored by epriestley).
Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods
Wed, Jul 21, 9:18 PM
epriestley committed rP4cffaa600bec: Rename "HarbormasterRestartException" to "HarbormasterMessageException" (authored by epriestley).
Rename "HarbormasterRestartException" to "HarbormasterMessageException"
Wed, Jul 21, 9:18 PM
epriestley committed rP4c4123f98b6d: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort… (authored by epriestley).
Allow "harbormaster.sendmessage" to send control command (pause, restart, abort…
Wed, Jul 21, 9:18 PM
epriestley committed rP346ffc51e100: Modularize "HarbormasterBuildableTransaction" (authored by epriestley).
Modularize "HarbormasterBuildableTransaction"
Wed, Jul 21, 9:18 PM
epriestley closed D21694: Modularize "HarbormasterBuildableTransaction".
Wed, Jul 21, 9:18 PM
epriestley closed D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
Wed, Jul 21, 9:18 PM
epriestley committed rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE" (authored by epriestley).
Remove "HarbormasterBuildableTransaction::TYPE_CREATE"
Wed, Jul 21, 9:18 PM
epriestley committed rP1a1395579f95: Remove "HarbormasterBuildCommand" (authored by epriestley).
Remove "HarbormasterBuildCommand"
Wed, Jul 21, 9:18 PM
epriestley closed D21692: Remove "HarbormasterBuildCommand".
Wed, Jul 21, 9:18 PM
epriestley closed D21691: Modularize almost all Harbormaster build message workflows and UI/UX.
Wed, Jul 21, 9:18 PM
epriestley committed rP1212dc5fbe8b: Modularize almost all Harbormaster build message workflows and UI/UX (authored by epriestley).
Modularize almost all Harbormaster build message workflows and UI/UX
Wed, Jul 21, 9:18 PM
epriestley committed rP8bbee921398d: Modularize individual Harbormaster build messages (authored by epriestley).
Modularize individual Harbormaster build messages
Wed, Jul 21, 9:17 PM
epriestley closed D21690: Modularize individual Harbormaster build messages.
Wed, Jul 21, 9:17 PM
epriestley closed D21689: Modularize HarbormasterBuildTransaction.
Wed, Jul 21, 9:17 PM
epriestley committed rP6dfea0adaddc: Modularize HarbormasterBuildTransaction (authored by epriestley).
Modularize HarbormasterBuildTransaction
Wed, Jul 21, 9:17 PM
epriestley committed rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE" (authored by epriestley).
Remove "HarbormasterBuildTransaction::TYPE_CREATE"
Wed, Jul 21, 9:17 PM
epriestley committed rP012af00731fd: Improve formality of "HarbormasterBuild" states (authored by epriestley).
Improve formality of "HarbormasterBuild" states
Wed, Jul 21, 9:17 PM
epriestley committed rPbf83fffca129: Correct the flow of edit authority when sending messages to HarbormasterBuild… (authored by epriestley).
Correct the flow of edit authority when sending messages to HarbormasterBuild…
Wed, Jul 21, 9:17 PM
epriestley closed D21688: Remove "HarbormasterBuildTransaction::TYPE_CREATE".
Wed, Jul 21, 9:17 PM
epriestley closed D21685: Improve formality of "HarbormasterBuild" states.
Wed, Jul 21, 9:17 PM
epriestley committed rPb48d4fabaf9e: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage" (authored by epriestley).
Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
Wed, Jul 21, 9:17 PM
epriestley closed D21684: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage".
Wed, Jul 21, 9:17 PM
epriestley committed rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"… (authored by epriestley).
Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"…
Wed, Jul 21, 9:17 PM
epriestley closed D21683: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages" table.
Wed, Jul 21, 9:17 PM
epriestley accepted D21706: Update other usages of "hg rebase" to use the new extension-enabling function.
Wed, Jul 21, 9:06 PM
epriestley committed rARCec68005d758c: Remove "phutil_deprecated()" (authored by epriestley).
Remove "phutil_deprecated()"
Wed, Jul 21, 5:21 PM
epriestley closed D21704: Remove "phutil_deprecated()".
Wed, Jul 21, 5:21 PM
epriestley closed D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:21 PM
epriestley committed rARC8bb7d5889050: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()" (authored by epriestley).
Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()"
Wed, Jul 21, 5:21 PM
epriestley closed T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()" as Resolved by committing rARC8bb7d5889050: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:21 PM · Infrastructure
epriestley committed rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in… (authored by epriestley).
Use "resolve()", not "execute()", for PhutilExecPassthru callsites in…
Wed, Jul 21, 5:21 PM
epriestley closed D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 5:21 PM
epriestley added inline comments to D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:20 PM
epriestley updated the test plan for D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:12 PM
epriestley requested review of D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:12 PM
epriestley added a revision to T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()": D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".
Wed, Jul 21, 5:11 PM · Infrastructure
epriestley requested review of D21704: Remove "phutil_deprecated()".
Wed, Jul 21, 5:08 PM
epriestley requested review of D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 4:56 PM
epriestley added a revision to T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()": D21703: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator.
Wed, Jul 21, 4:54 PM · Infrastructure
epriestley triaged T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()" as Low priority.
Wed, Jul 21, 4:49 PM · Infrastructure
epriestley added a comment to T13659: `arc land` may fail with missing rebase extension.

(After picking up D21697, the approach works properly in my environment where I originally ran into this, but there are a couple of rebase calls still present in ArcanistMercurialLandEngine that don't use the new API yet.)

Wed, Jul 21, 4:44 PM · Arcanist, Mercurial
epriestley added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

I just use TextMate, which is a fairly lightweight editor. I have it minimally configured to disable a couple of default behaviors and add a couple aliases, and I have a crude "jump-to-definition" script set up that tries to open whatever file defines the class/function under the cursor and succeeds about 95% of the time.

Wed, Jul 21, 4:29 PM
epriestley added a comment to D21697: Refactor how Mercurial runs commands that require extensions.

...the one with --onto-remote default not appearing in the trace output...

Wed, Jul 21, 4:14 AM
epriestley added inline comments to D21697: Refactor how Mercurial runs commands that require extensions.
Wed, Jul 21, 4:04 AM
epriestley committed rARC35c1b9bf027b: Fix an ExecFuture typo, "preprebuilt" (authored by epriestley).
Fix an ExecFuture typo, "preprebuilt"
Wed, Jul 21, 3:18 AM
epriestley closed D21702: Fix an ExecFuture typo, "preprebuilt".
Wed, Jul 21, 3:18 AM
epriestley requested review of D21702: Fix an ExecFuture typo, "preprebuilt".
Wed, Jul 21, 3:15 AM
epriestley accepted D21697: Refactor how Mercurial runs commands that require extensions.

Thanks! Couple of minor inlines but I didn't catch anything substantial.

Wed, Jul 21, 3:14 AM
epriestley accepted D21701: Suppress PHP 8 deprecation warning in startup.
Wed, Jul 21, 1:03 AM
epriestley added a comment to T13648: Transaction publishing may stall during mail expansion of package recipients.

This happens when a recipient list includes an Owners package which has been destroyed. Specifically, we'll exit this section of PhabricatorMetaMTAMemberQuery with out the PHID in $package_map, and then fail to return it:

Wed, Jul 21, 1:03 AM · Transactions

Tue, Jul 20

epriestley accepted D21700: Display informative message when arc launches an editor.

There a bit of fancier indent/formatting stuff in some of the newer code (e.g., in ArcanistRefView->newLines()) but it hasn't really generalized into something you could easily apply here yet. I think this is fine for now and we could revisit it to make it fancier later on if the newest display stuff gets generalized a bit.

Tue, Jul 20, 10:58 PM
epriestley added a comment to D21700: Display informative message when arc launches an editor.

Maybe the output could be two separate lines:

Tue, Jul 20, 10:12 PM
epriestley requested review of D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
Tue, Jul 20, 9:45 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
Tue, Jul 20, 9:43 PM · Harbormaster
epriestley requested review of D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.
Tue, Jul 20, 9:42 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.
Tue, Jul 20, 9:41 PM · Harbormaster
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

That all looks good to me.

Tue, Jul 20, 7:57 PM

Mon, Jul 19

epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

We could conceivably prevent that error by making GitLocalState keep a trivial stack (just a stack of true) and return its current depth (0, 1, 2, ...), then throw if the passed $ref was not the current stack depth.

Mon, Jul 19, 7:18 PM
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

Since modern Arcanist usage with Mercurial has required the arc-ls-markers for a while now and nobody else has reported issues, I think it's fine to not try to address these issues for older versions.

Mon, Jul 19, 5:14 PM
epriestley accepted D21686: Update "arc diff" to amend non-head commits with Mercurial.
Mon, Jul 19, 5:12 PM
epriestley added a comment to T13659: `arc land` may fail with missing rebase extension.

...perhaps we should consider a way to do this automatically or at least less-manually.

Mon, Jul 19, 4:58 PM · Arcanist, Mercurial
epriestley added a comment to D21680: An assortment of fixes and updates to using arc-land with mercurial.

This makes me think that in this second scenario where running arc diff initially includes multiple commits that the revision should be updated to include the commit hashes for each, and then might result in having better detect this scenario if it's searching for revisions with associated commit hashes.

Mon, Jul 19, 4:33 PM
epriestley triaged T13659: `arc land` may fail with missing rebase extension as Low priority.
Mon, Jul 19, 4:32 PM · Arcanist, Mercurial

Fri, Jul 16

epriestley requested review of D21696: Add a side nav to Conduit API method console pages.
Fri, Jul 16, 10:16 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21696: Add a side nav to Conduit API method console pages.
Fri, Jul 16, 10:15 PM · Harbormaster
epriestley added a comment to T13652: Notes on Ardunio CNC drivers.
  • Cryptographically Random Orbit Sander
Fri, Jul 16, 9:43 PM
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

Sounds good. I spent 15 seconds on trying to write hg arc-amend, and this does something and does appear to produce an amended commit that looks ballpark-correct (and can amend non-heads), but emits some warnings and I have no clue if it functions across Mercurial versions:

Fri, Jul 16, 5:35 PM
epriestley requested review of D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
Fri, Jul 16, 4:44 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
Fri, Jul 16, 4:43 PM · Harbormaster
epriestley requested review of D21694: Modularize "HarbormasterBuildableTransaction".
Fri, Jul 16, 4:01 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21694: Modularize "HarbormasterBuildableTransaction".
Fri, Jul 16, 4:00 PM · Harbormaster
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

My only guess is you've delved into the Mercurial source base (I've poked around a little)

Fri, Jul 16, 3:55 PM
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

I don't think LocalState should z̵̰̲͚͖̊͗́̓̓a̷̛̱̯̠͐̿̅̅͛̓͗ĺ̵̨̻̠͓̼̗̥̥̻̲̳̎͜ͅg̴̛͙͗̀̄̈́̃̂̓̄͝o̶̥̘̻͙̬͇͚̥̪͌̔̃͛̆̀̂̚ͅ your terminal!

Fri, Jul 16, 3:54 PM
epriestley requested review of D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
Fri, Jul 16, 3:35 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
Fri, Jul 16, 3:34 PM · Harbormaster
epriestley requested review of D21692: Remove "HarbormasterBuildCommand".
Fri, Jul 16, 3:11 PM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21692: Remove "HarbormasterBuildCommand".
Fri, Jul 16, 3:10 PM · Harbormaster
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

This is probably not a great path to walk down, but there are secret flags that disable the "cannot amend changeset with children" check:

Fri, Jul 16, 2:15 AM
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

Another possible approach might be to copy the amend extension to create hg arc-amend which just lets you amend anything, assuming the "head only" rule is a safety guard rail rather than a fundamental issue with Mercurial (which it seems like it should be).

Fri, Jul 16, 2:07 AM
epriestley requested review of D21691: Modularize almost all Harbormaster build message workflows and UI/UX.
Fri, Jul 16, 1:32 AM
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21691: Modularize almost all Harbormaster build message workflows and UI/UX.
Fri, Jul 16, 1:30 AM · Harbormaster
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

Ohhhhh, sorry, I didn't connect the dots and understand that you're only sometimes running the amend (since you can't amend for non-heads).

Fri, Jul 16, 1:28 AM

Thu, Jul 15

epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

This ("Queued at") looks suspicious:

Thu, Jul 15, 11:03 PM · Harbormaster
epriestley added a comment to D21686: Update "arc diff" to amend non-head commits with Mercurial.

I'm not catching on to what you're referring to. Are you saying there are other changes which will have already stashed unsaved state away before calling amendCommit()?

Thu, Jul 15, 11:02 PM