Page MenuHomePhabricator
Feed Advanced Search

Fri, Dec 13

epriestley edited the content of Changelog.
Fri, Dec 13, 6:44 PM
epriestley created an object: 2019 Week 50 (Mid December).
Fri, Dec 13, 6:43 PM
epriestley committed rPc4b4a53cad77: (stable) Promote 2019 Week 50 (authored by epriestley).
(stable) Promote 2019 Week 50
Fri, Dec 13, 6:42 PM
epriestley committed rP54bcbdaba94a: Fix an XSS issue with certain high-priority remarkup rules embedded inside… (authored by epriestley).
Fix an XSS issue with certain high-priority remarkup rules embedded inside…
Fri, Dec 13, 6:38 PM
epriestley closed D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Fri, Dec 13, 6:37 PM
epriestley requested review of D20937: Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules.
Fri, Dec 13, 6:37 PM

Mon, Dec 9

epriestley accepted D20935: Use same method to get object URI as used in DifferentialTransactionEditor and PhabricatorApplicationTransactionEditor.
Mon, Dec 9, 6:38 PM

Sat, Nov 30

epriestley requested review of D20934: Give "Config" a full-width, hierarchical layout.
Sat, Nov 30, 8:05 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20934: Give "Config" a full-width, hierarchical layout.
Sat, Nov 30, 8:03 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Sat, Nov 30, 7:55 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Sat, Nov 30, 6:38 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Sat, Nov 30, 6:37 PM · Design, Config
epriestley updated the summary of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Sat, Nov 30, 6:37 PM
epriestley requested review of D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView".
Sat, Nov 30, 6:35 PM

Tue, Nov 26

epriestley requested review of D20931: Carve out a separate "Services" section of Config.
Tue, Nov 26, 11:32 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20931: Carve out a separate "Services" section of Config.
Tue, Nov 26, 11:31 PM · Design, Config
epriestley requested review of D20930: Carve out a separate "Modules/Extensions" section of Config.
Tue, Nov 26, 11:02 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20930: Carve out a separate "Modules/Extensions" section of Config.
Tue, Nov 26, 11:01 PM · Design, Config
epriestley triaged T13467: Expand the "ddata003" volume as Low priority.
Tue, Nov 26, 6:00 PM · Phacility
CodeMouse92 awarded T10779: Cannot manage base project milestones if base project has subprojects a Party Time token.
Tue, Nov 26, 3:17 AM · Restricted Project, Projects, Bug Report
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

I believe T13462 resolved this.

Tue, Nov 26, 1:52 AM · Restricted Project, Projects, Bug Report
epriestley committed rP33c534f9b74f: Extend Config to full-width (authored by epriestley).
Extend Config to full-width
Tue, Nov 26, 12:18 AM
epriestley closed D20925: Extend Config to full-width.
Tue, Nov 26, 12:18 AM
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

there is no way to bin/host query against the set of instances using a particular repository shard service

Tue, Nov 26, 12:14 AM · Phacility, Ops
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Tue, Nov 26, 12:09 AM · Phacility, Ops

Mon, Nov 25

epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Mon, Nov 25, 11:57 PM · Phacility, Ops
epriestley committed rP1667acfa5d71: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them… (authored by epriestley).
Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them…
Mon, Nov 25, 11:08 PM
epriestley closed D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Mon, Nov 25, 11:08 PM
epriestley added a comment to T11860: Bot email addresses can't be edited.

In D20927, I implemented a policy rule like this:

Mon, Nov 25, 11:08 PM · Setup, People
epriestley requested review of D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Mon, Nov 25, 11:07 PM
epriestley added a revision to T11860: Bot email addresses can't be edited: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Mon, Nov 25, 11:06 PM · Setup, People
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Mon, Nov 25, 11:06 PM · Diffusion
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Mon, Nov 25, 10:46 PM · Phacility, Ops
epriestley requested review of D20925: Extend Config to full-width.
Mon, Nov 25, 10:38 PM
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: D20925: Extend Config to full-width.
Mon, Nov 25, 10:37 PM · Design, Config
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Update Almanac definitions for all instances not on the paired db023 shard.

Mon, Nov 25, 5:01 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

PHI1566 is resolved narrowly. These cleanup steps still need to happen.

Mon, Nov 25, 4:42 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

(Updating addresses with bin/host query leaves the service address cache dirty (the "mutable structure cache" via PhabricatorRepository->getAlmanacServiceRefs()) so it should be followed with bin/cache purge --caches general.)

Mon, Nov 25, 4:29 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'll flesh this out more later, but the move away from db123 = repo123 shard pairing, plus bin/host query using mysql makes it difficult to directly query instances using a particular repository service.

Mon, Nov 25, 4:15 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Minor issue that should be looked at during service sync arising from improved validation elsewhere:

Mon, Nov 25, 4:06 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'm deploying the new host now. We just crossed a release so I'm going to manually restore it to 72f82abe07 once it comes up (see also T13359). Then, I'll resynchronize instance services for active instances.

Mon, Nov 25, 3:57 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Instance termination completed after about 20 minutes and all the volumes detached. Since the original instance can be recycled, I'm going to reattach and restart it, and throw away the replacement host.

Mon, Nov 25, 3:51 PM · Phacility, Ops
epriestley added a project to T13466: AWS instance termination may fail/hang indefinitely: Phacility.
Mon, Nov 25, 3:48 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Normal volume detachment is just spinning, which isn't exactly surprising. I'm going to give it a few minutes and then force detachment.

Mon, Nov 25, 3:47 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

To deal with this narrowly, I'm going to:

Mon, Nov 25, 3:44 PM · Phacility, Ops
epriestley triaged T13466: AWS instance termination may fail/hang indefinitely as Low priority.
Mon, Nov 25, 3:42 PM · Phacility, Ops
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Mon, Nov 25, 3:24 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Mon, Nov 25, 3:22 PM · Design, Config
epriestley added a comment to T13362: Push the "Config" application UI out to full-width.
  • Individual setup issue pages are a little weird.
Mon, Nov 25, 3:17 PM · Design, Config
epriestley edited the content of Changelog.
Mon, Nov 25, 3:13 PM
epriestley created an object: 2019 Week 47 (Very Late November).
Mon, Nov 25, 3:11 PM
epriestley committed rP6de53cf50c38: (stable) Promote 2019 Week 47 (authored by epriestley).
(stable) Promote 2019 Week 47
Mon, Nov 25, 3:11 PM

Fri, Nov 22

epriestley committed rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls (authored by epriestley).
Remove "phlog()" of exeptions during Conduit calls
Fri, Nov 22, 8:03 PM
epriestley closed D20924: Remove "phlog()" of exeptions during Conduit calls.
Fri, Nov 22, 8:03 PM
epriestley closed T13465: Stop sending Conduit exceptions to the error log as Resolved by committing rPeb6df7a2091a: Remove "phlog()" of exeptions during Conduit calls.
Fri, Nov 22, 8:03 PM · Conduit
epriestley requested review of D20924: Remove "phlog()" of exeptions during Conduit calls.
Fri, Nov 22, 7:56 PM
epriestley added a revision to T13465: Stop sending Conduit exceptions to the error log: D20924: Remove "phlog()" of exeptions during Conduit calls.
Fri, Nov 22, 7:54 PM · Conduit
epriestley triaged T13465: Stop sending Conduit exceptions to the error log as Low priority.
Fri, Nov 22, 7:52 PM · Conduit

Thu, Nov 21

epriestley committed rP2abf292821a2: Fix an issue where editing paths in Owners packages could raise an error… (authored by epriestley).
Fix an issue where editing paths in Owners packages could raise an error…
Thu, Nov 21, 7:29 PM
epriestley closed T13464: Fix "display" index issue when editing Paths in Owners as Resolved by committing rP2abf292821a2: Fix an issue where editing paths in Owners packages could raise an error….
Thu, Nov 21, 7:29 PM · Owners
epriestley closed D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Thu, Nov 21, 7:29 PM
epriestley requested review of D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Thu, Nov 21, 7:28 PM
epriestley added a revision to T13464: Fix "display" index issue when editing Paths in Owners: D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Thu, Nov 21, 7:27 PM · Owners
epriestley triaged T13464: Fix "display" index issue when editing Paths in Owners as Low priority.
Thu, Nov 21, 7:18 PM · Owners
epriestley removed a parent task for T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Thu, Nov 21, 4:06 PM · Restricted Project, Diffusion, Custom Fields
epriestley removed a subtask for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure.
Thu, Nov 21, 4:06 PM · Maniphest
epriestley removed a subtask for T10034: Plan the future of Maniphest task relationships: T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Thu, Nov 21, 4:06 PM · Maniphest
epriestley removed a parent task for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T10034: Plan the future of Maniphest task relationships.
Thu, Nov 21, 4:06 PM · Customer Impact, Differential, Maniphest
epriestley merged T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Thu, Nov 21, 4:05 PM · Maniphest, Differential, Diffusion
epriestley merged task T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Thu, Nov 21, 4:05 PM · Maniphest
epriestley added a comment to T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".

T13463 is approximately the same as this, but now ripe; I'm going to merge this there.

Thu, Nov 21, 4:04 PM · Maniphest
epriestley added a parent task for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Thu, Nov 21, 4:03 PM · Maniphest
epriestley added a subtask for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Thu, Nov 21, 4:03 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Thu, Nov 21, 4:03 PM · Customer Impact, Differential, Maniphest
epriestley added a parent task for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Thu, Nov 21, 4:03 PM · Maniphest, Differential, Diffusion
epriestley updated the task description for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Thu, Nov 21, 4:02 PM · Maniphest, Differential, Diffusion
epriestley triaged T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Low priority.
Thu, Nov 21, 4:02 PM · Maniphest, Differential, Diffusion
epriestley closed T5598: Make "T123" in commit title work like "Ref T123" or "Fixes T123" in the body or test plan or a comment as Wontfix.

I don't currently plan to pursue this.

Thu, Nov 21, 3:56 PM · Maniphest, Differential

Wed, Nov 20

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

In the general case:

Wed, Nov 20, 7:00 AM · Customer Impact, Diffusion (v3)

Tue, Nov 19

epriestley committed rP374f8b10b3cf: Add a "--dry-run" flag to "bin/repository rebuild-identities" (authored by epriestley).
Add a "--dry-run" flag to "bin/repository rebuild-identities"
Tue, Nov 19, 8:38 PM
epriestley closed D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Tue, Nov 19, 8:38 PM
epriestley closed T12164: Put an indirection layer between author/committer strings and user accounts as Resolved.

I think this doesn't have anything actionable left, see T13444 for some followups. This feature probably isn't 100% perfect quite yet, but I think remaining work is just cleanup.

Tue, Nov 19, 8:37 PM · Customer Impact, Diffusion (v3)
epriestley requested review of D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Tue, Nov 19, 8:36 PM
epriestley claimed T13444: Provide a standalone script entry point for resolving a repository identity.
Tue, Nov 19, 8:36 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Tue, Nov 19, 8:34 PM · Diffusion
epriestley committed rP63d84e0b44b7: Improve use of keys when iterating over commits in "bin/audit delete" and… (authored by epriestley).
Improve use of keys when iterating over commits in "bin/audit delete" and…
Tue, Nov 19, 6:19 PM
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration, a subtask of T13444: Provide a standalone script entry point for resolving a repository identity, as Resolved.
Tue, Nov 19, 6:19 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Resolved by committing rP63d84e0b44b7: Improve use of keys when iterating over commits in "bin/audit delete" and….
Tue, Nov 19, 6:19 PM · Diffusion
epriestley closed D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Tue, Nov 19, 6:19 PM
epriestley requested review of D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Tue, Nov 19, 6:11 PM
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Tue, Nov 19, 6:10 PM · Diffusion
epriestley added a revision to T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Tue, Nov 19, 6:10 PM · Diffusion
epriestley committed rPa7aca500bcd1: Update repository identities after all mutations to users and email addresses (authored by epriestley).
Update repository identities after all mutations to users and email addresses
Tue, Nov 19, 5:42 PM
epriestley closed D20914: Update repository identities after all mutations to users and email addresses.
Tue, Nov 19, 5:42 PM
epriestley committed rP89dcf9792a0a: Give "PhabricatorUserEmail" a PHID (authored by epriestley).
Give "PhabricatorUserEmail" a PHID
Tue, Nov 19, 5:41 PM
epriestley closed D20913: Give "PhabricatorUserEmail" a PHID.
Tue, Nov 19, 5:41 PM
epriestley committed rPd69a7360ea17: Use DestructionEngine to destroy UserEmail objects (authored by epriestley).
Use DestructionEngine to destroy UserEmail objects
Tue, Nov 19, 5:41 PM
epriestley closed D20912: Use DestructionEngine to destroy UserEmail objects.
Tue, Nov 19, 5:41 PM
epriestley committed rP18da346972b6: Add additional flags to "bin/repository rebuild-identities" to improve… (authored by epriestley).
Add additional flags to "bin/repository rebuild-identities" to improve…
Tue, Nov 19, 5:40 PM
epriestley closed D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Tue, Nov 19, 5:39 PM