Stuff to fix with subscriptions:
Sat, Aug 17
Fri, Aug 16
if this is really an issue we could likely throw a rate limit on the action
This is sort-of-quasi-intentional
This is actually slightly tricky.
A related issue is that when object A returns object B as an extended policy check, the "PolicyException" dialog is misleading. It reads like this:
Thu, Aug 15
Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.
The bucket limit is currently implemented like this:
It would also be nice to figure out Phortune permissions better here since this is a good opportunity to vet everything.
Mon, Aug 12
See PHI1378, which is interested in "at least N", for N = 2.
There was one issue with this: bin/host stop --instance X (which is rarely used, and has no prior automated callers) used --force, which stops all daemons on the host. The recent changes to the --force flag in D20601 also had an indirect impact here. I fixed this and redeployed the repo tier.
Sun, Aug 11
Fri, Aug 9
Thu, Aug 8
See downstream https://phabricator.wikimedia.org/T230001 for a similar issue on project pages.
The repro case is something like:
Oh, good catch. Yeah, that would be an improvement.
Wed, Aug 7
This thread suggests that some version of ssh-keygen is sensitive to trailing whitespace in private keys: