Page MenuHomePhabricator
Feed Advanced Search

Thu, Nov 19

epriestley requested review of D21495: When updating a Ferret search index document, reuse existing rows where possible.
Thu, Nov 19, 9:37 PM
epriestley added a revision to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes: D21495: When updating a Ferret search index document, reuse existing rows where possible.
Thu, Nov 19, 9:36 PM · Search
epriestley accepted D21494: Change baseURI for Packages to avoid 404.

Seems reasonable, definitely the highest impact-per-character change I can come up with.

Thu, Nov 19, 9:35 PM
epriestley triaged T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes as Normal priority.
Thu, Nov 19, 8:24 PM · Search

Sat, Nov 7

epriestley requested review of D21493: Separate Herald transcripts into several different views.
Sat, Nov 7, 12:21 AM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21493: Separate Herald transcripts into several different views.
Sat, Nov 7, 12:20 AM · Herald
epriestley triaged T13586: In Herald transcripts, surface exceptions encountered while evaluating fields as Low priority.
Sat, Nov 7, 12:18 AM · Herald
epriestley closed T13298: Improve Herald profiling information available in transcripts as Resolved.

The profiling in D20566 seems satisfactory, and has been useful in resolving or understanding a few performance-related issuses.

Sat, Nov 7, 12:09 AM · Herald

Tue, Nov 3

epriestley closed D21488: Add a basic "harbormaster.step.search" API method.
Tue, Nov 3, 8:50 PM
epriestley committed rPbf8707d3a9bf: Add a basic "harbormaster.step.search" API method (authored by epriestley).
Add a basic "harbormaster.step.search" API method
Tue, Nov 3, 8:50 PM
epriestley closed D21489: Add a basic "harbormaster.step.edit" API method.
Tue, Nov 3, 8:50 PM
epriestley committed rP34082efb02c7: Add a basic "harbormaster.step.edit" API method (authored by epriestley).
Add a basic "harbormaster.step.edit" API method
Tue, Nov 3, 8:50 PM
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21488: Add a basic "harbormaster.step.search" API method.
Tue, Nov 3, 8:50 PM · Conduit, Harbormaster
epriestley updated the summary of D21488: Add a basic "harbormaster.step.search" API method.
Tue, Nov 3, 8:50 PM
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Tue, Nov 3, 8:49 PM · Conduit, Harbormaster
epriestley requested review of D21489: Add a basic "harbormaster.step.edit" API method.
Tue, Nov 3, 8:47 PM
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21489: Add a basic "harbormaster.step.edit" API method.
Tue, Nov 3, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Tue, Nov 3, 8:45 PM · Conduit, Harbormaster
epriestley updated the diff for D21488: Add a basic "harbormaster.step.search" API method.
  • Use more consistent capitalization.
Tue, Nov 3, 8:38 PM
epriestley requested review of D21488: Add a basic "harbormaster.step.search" API method.
Tue, Nov 3, 8:36 PM
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Tue, Nov 3, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Tue, Nov 3, 8:17 PM · Conduit, Harbormaster
epriestley renamed T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from PCRE segfaults readily with default "pcre.backtrace_limit" and "pcre.recursion_limit" values to PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.
Tue, Nov 3, 7:36 PM · Phacility
epriestley committed rPae5a38f3349f: Guarantee terms in PhabricatorAuthPasswordEngine are strings (authored by epriestley).
Guarantee terms in PhabricatorAuthPasswordEngine are strings
Tue, Nov 3, 7:05 PM
epriestley closed D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Tue, Nov 3, 7:04 PM
epriestley closed T13584: Shallow Git clones fail under recent versions of Git as Resolved.

This appears fixed by D21484 (and @20after4 confirmed the fix on rPc0414732 -- thanks!) so I'm going to mark it as resolved.

Tue, Nov 3, 7:04 PM · Diffusion
epriestley requested review of D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Tue, Nov 3, 6:56 PM
epriestley added a revision to T2312: Modifying PHP: D21487: Guarantee terms in PhabricatorAuthPasswordEngine are strings.
Tue, Nov 3, 6:37 PM · Infrastructure
epriestley added a comment to T2312: Modifying PHP.

See https://discourse.phabricator-community.org/t/strpos-throwing-in-phabricatorauthpasswordengine/4335, and D21477.

Tue, Nov 3, 6:19 PM · Infrastructure

Fri, Oct 30

epriestley added a comment to D21484: Fix isValidGitShallowCloneResponse.

Ah, thanks for the pointers!

Fri, Oct 30, 11:30 PM · Diffusion
epriestley committed rPc04147328fa3: Fix isValidGitShallowCloneResponse (authored by epriestley).
Fix isValidGitShallowCloneResponse
Fri, Oct 30, 8:46 PM
epriestley closed D21484: Fix isValidGitShallowCloneResponse.
Fri, Oct 30, 8:46 PM · Diffusion
epriestley accepted D21484: Fix isValidGitShallowCloneResponse.

Minor nitpicks inlines, I'll just tweak them locally as I land this.

Fri, Oct 30, 8:32 PM · Diffusion
epriestley committed rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients (authored by epriestley).
Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Fri, Oct 30, 8:02 PM
epriestley closed D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.
Fri, Oct 30, 8:02 PM
epriestley requested review of D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.
Fri, Oct 30, 7:58 PM

Oct 24 2020

epriestley triaged T13584: Shallow Git clones fail under recent versions of Git as Low priority.
Oct 24 2020, 11:05 PM · Diffusion

Oct 19 2020

epriestley committed rP86ad69863930: (stable) When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
(stable) When a new, deleted, draft inline is revived with "Undo", undelete it
Oct 19 2020, 7:37 PM
epriestley committed rPbc4f86d27996: When a new, deleted, draft inline is revived with "Undo", undelete it (authored by epriestley).
When a new, deleted, draft inline is revived with "Undo", undelete it
Oct 19 2020, 7:34 PM
epriestley closed D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Oct 19 2020, 7:34 PM
epriestley requested review of D21483: When a new, deleted, draft inline is revived with "Undo", undelete it.
Oct 19 2020, 7:32 PM
epriestley edited the content of Changelog.
Oct 19 2020, 7:05 PM
epriestley created an object: 2020 Week 42.
Oct 19 2020, 7:04 PM
epriestley committed rARCac54d61d7af2: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Oct 19 2020, 7:04 PM
epriestley committed rP916bce119a2b: (stable) Promote 2020 Week 42 (authored by epriestley).
(stable) Promote 2020 Week 42
Oct 19 2020, 7:04 PM
epriestley committed rPb2e96df3a3be: Update "arc call-conduit" instructions in Conduit API console for required "--" (authored by epriestley).
Update "arc call-conduit" instructions in Conduit API console for required "--"
Oct 19 2020, 7:02 PM
epriestley closed D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 7:02 PM
epriestley requested review of D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 6:55 PM
epriestley added a revision to T13491: Why does Arcanist require "--"?: D21482: Update "arc call-conduit" instructions in Conduit API console for required "--".
Oct 19 2020, 6:54 PM · Guides

Oct 16 2020

epriestley committed rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator (authored by epriestley).
Fix a typo of "previously" in FutureIterator
Oct 16 2020, 9:23 PM
epriestley closed D21478: Fix a typo of "previously" in FutureIterator.
Oct 16 2020, 9:23 PM
epriestley committed rP2b8bbae5fb27: Set an explicit height when drawing the dependent revision graph (authored by epriestley).
Set an explicit height when drawing the dependent revision graph
Oct 16 2020, 9:10 PM
epriestley closed D21481: Set an explicit height when drawing the dependent revision graph.
Oct 16 2020, 9:10 PM
epriestley requested review of D21481: Set an explicit height when drawing the dependent revision graph.
Oct 16 2020, 9:06 PM
epriestley committed rP058d2489e7a3: Expose the "file attached to object" and "object attached to file" edges via… (authored by epriestley).
Expose the "file attached to object" and "object attached to file" edges via…
Oct 16 2020, 8:45 PM
epriestley closed D21480: Expose the "file attached to object" and "object attached to file" edges via "edge.search".
Oct 16 2020, 8:45 PM
epriestley requested review of D21480: Expose the "file attached to object" and "object attached to file" edges via "edge.search".
Oct 16 2020, 8:43 PM
epriestley committed rP1f7c736f9ab6: Add a "Comment content" field to Herald (authored by epriestley).
Add a "Comment content" field to Herald
Oct 16 2020, 8:43 PM
epriestley closed D21479: Add a "Comment content" field to Herald.
Oct 16 2020, 8:43 PM
epriestley requested review of D21479: Add a "Comment content" field to Herald.
Oct 16 2020, 8:30 PM
epriestley added a revision to T13583: Support reasonable guardrails against mismatched data retention policies in comment content: D21479: Add a "Comment content" field to Herald.
Oct 16 2020, 8:29 PM · Herald
epriestley triaged T13583: Support reasonable guardrails against mismatched data retention policies in comment content as Normal priority.
Oct 16 2020, 8:27 PM · Herald
epriestley requested review of D21478: Fix a typo of "previously" in FutureIterator.
Oct 16 2020, 7:31 PM
epriestley added a revision to T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool: D21478: Fix a typo of "previously" in FutureIterator.
Oct 16 2020, 7:31 PM · Daemons
epriestley committed rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer (authored by epriestley).
Fix an issue where "phutil_utf8v()" could fatal when passed an integer
Oct 16 2020, 4:22 PM
epriestley closed D21477: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.
Oct 16 2020, 4:22 PM
epriestley requested review of D21477: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.
Oct 16 2020, 4:20 PM

Oct 2 2020

epriestley committed rP0f27cd46ccad: Never render "Show More Context" inside an inline comment suggestion diff (authored by epriestley).
Never render "Show More Context" inside an inline comment suggestion diff
Oct 2 2020, 4:47 PM
epriestley closed D21476: Never render "Show More Context" inside an inline comment suggestion diff.
Oct 2 2020, 4:47 PM
epriestley requested review of D21476: Never render "Show More Context" inside an inline comment suggestion diff.
Oct 2 2020, 4:46 PM
epriestley committed rP0f0e94ca71fe: Use "getInlines()", not "_inlines", to access inlines on client Changeset… (authored by epriestley).
Use "getInlines()", not "_inlines", to access inlines on client Changeset…
Oct 2 2020, 4:19 PM
epriestley closed D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
Oct 2 2020, 4:19 PM
epriestley updated the diff for D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
  • Fix a possible call reentrancy issue, where "getInlines()" and "getInlineForRow()" could call one another.
Oct 2 2020, 4:18 PM
epriestley requested review of D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects.
Oct 2 2020, 4:12 PM

Sep 30 2020

epriestley accepted D21474: Fix rubocop lint tests.

You should be able to land this yourself directly, see the description of Blessed Committers for details or let me know if you run into issues. "Land Revision" in the web UI should also work.

Sep 30 2020, 3:17 PM
epriestley added a member for Community: bootstraponline.
Sep 30 2020, 3:07 PM
epriestley added a member for Blessed Committers: bootstraponline.
Sep 30 2020, 3:07 PM
epriestley committed rARC524aa2aed2ad: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend. (authored by epriestley).
Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.
Sep 30 2020, 2:49 PM
epriestley closed D21473: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.exception_ignore_args".
Sep 30 2020, 2:49 PM
epriestley requested review of D21473: Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.exception_ignore_args".
Sep 30 2020, 2:49 PM

Sep 28 2020

epriestley accepted D21471: fail `arc diff` if second lfs push errors.
Sep 28 2020, 4:55 PM
epriestley committed rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively (authored by epriestley).
When printing, wrap all content in Remarkup tables more aggressively
Sep 28 2020, 4:47 PM
epriestley closed D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 28 2020, 4:47 PM
epriestley added a comment to D21472: When printing, wrap all content in Remarkup tables more aggressively.

Here's the remaining goofy behavior:

Sep 28 2020, 4:47 PM
epriestley requested review of D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 28 2020, 4:23 PM
epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 28 2020, 4:22 PM · Google Chrome, Remarkup

Sep 18 2020

epriestley edited the content of Changelog.
Sep 18 2020, 7:03 PM
epriestley committed rARC68dba1a2c6d9: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Sep 18 2020, 7:00 PM
epriestley committed rP5e06d924f8eb: (stable) Promote 2020 Week 37 (authored by epriestley).
(stable) Promote 2020 Week 37
Sep 18 2020, 7:00 PM
epriestley created an object: 2020 Week 37 (Mid September).
Sep 18 2020, 6:55 PM
epriestley committed rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"… (authored by epriestley).
In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…
Sep 18 2020, 6:23 PM
epriestley closed D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Sep 18 2020, 6:23 PM
epriestley requested review of D21470: In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly.
Sep 18 2020, 6:22 PM

Sep 17 2020

epriestley committed rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as… (authored by epriestley).
Fix an issue where known Subversion commits are incorrectly shown as…
Sep 17 2020, 8:55 PM
epriestley closed D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:55 PM
epriestley requested review of D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:53 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21469: Fix an issue where known Subversion commits are incorrectly shown as "Discovering...".
Sep 17 2020, 8:52 PM · Differential
epriestley committed rPf21a00a3159e: Fix an out-of-order issue in the new update-during-publish behavior (authored by epriestley).
Fix an out-of-order issue in the new update-during-publish behavior
Sep 17 2020, 8:40 PM
epriestley closed D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:40 PM
epriestley requested review of D21468: Fix an out-of-order issue in the new update-during-publish behavior.
Sep 17 2020, 8:39 PM