Page MenuHomePhabricator
Feed Advanced Search

Today

epriestley committed rARC9e72e4ed1df5: Bring "pro" browse queries from modern hardpoint code (authored by epriestley).
Bring "pro" browse queries from modern hardpoint code
Fri, Apr 10, 3:05 PM
epriestley closed D21080: Bring "pro" browse queries from modern hardpoint code.
Fri, Apr 10, 3:05 PM
epriestley committed rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks (authored by epriestley).
Fix an out-of-date API call on the destruction pathway for Pholio mocks
Fri, Apr 10, 3:01 PM
epriestley closed D21081: Fix an out-of-date API call on the destruction pathway for Pholio mocks.
Fri, Apr 10, 3:01 PM
epriestley requested review of D21081: Fix an out-of-date API call on the destruction pathway for Pholio mocks.
Fri, Apr 10, 3:01 PM
epriestley added inline comments to D19914: Make Images in Pholio refer to mocks by PHID instead of ID.
Fri, Apr 10, 3:01 PM
epriestley triaged T13508: In Chrome, the menu bar hover animation can cycle very rapidly if you put your cursor exactly on the bottom as Wishlist priority.
Fri, Apr 10, 2:55 PM · Design
epriestley requested review of D21080: Bring "pro" browse queries from modern hardpoint code.
Fri, Apr 10, 2:51 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21080: Bring "pro" browse queries from modern hardpoint code.
Fri, Apr 10, 2:51 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley abandoned D3357: GitHub-style punchcards.

No current plans to pursue this upstream.

Fri, Apr 10, 2:32 PM
epriestley committed rARC8bb81217d5d2: Bring a "pro" WorkingCopyState ref to "master" (authored by epriestley).
Bring a "pro" WorkingCopyState ref to "master"
Fri, Apr 10, 1:16 PM
epriestley closed D21079: Bring a "pro" WorkingCopyState ref to "master".
Fri, Apr 10, 1:16 PM
epriestley requested review of D21079: Bring a "pro" WorkingCopyState ref to "master".
Fri, Apr 10, 1:07 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21079: Bring a "pro" WorkingCopyState ref to "master".
Fri, Apr 10, 1:06 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley committed rARCadea2550f533: Introduce "arc inspect" and some of the new ref/hardpoint classes (authored by epriestley).
Introduce "arc inspect" and some of the new ref/hardpoint classes
Fri, Apr 10, 12:01 PM
epriestley closed D21078: Introduce "arc inspect" and some of the new ref/hardpoint classes.
Fri, Apr 10, 12:01 PM
epriestley requested review of D21078: Introduce "arc inspect" and some of the new ref/hardpoint classes.
Fri, Apr 10, 11:58 AM
epriestley added a comment to T11968: Decide the fate of FutureGraph.

Generators can't "return" until PHP 7:

Fri, Apr 10, 11:43 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21078: Introduce "arc inspect" and some of the new ref/hardpoint classes.
Fri, Apr 10, 11:39 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley committed rARC92b29f53f3c9: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist (authored by epriestley).
Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist
Fri, Apr 10, 11:24 AM
epriestley closed D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.
Fri, Apr 10, 11:24 AM
epriestley committed rARC391c1643134a: Trivially update "arc branch/feature" and "arc browse" for Toolsets (authored by epriestley).
Trivially update "arc branch/feature" and "arc browse" for Toolsets
Fri, Apr 10, 11:23 AM
epriestley closed D21074: Trivially update "arc branch/feature" and "arc browse" for Toolsets.
Fri, Apr 10, 11:23 AM

Yesterday

epriestley committed rPa2fb91b8af4b: Remove the (hopefully) obsolete "post_max_size" check during startup (authored by epriestley).
Remove the (hopefully) obsolete "post_max_size" check during startup
Thu, Apr 9, 8:33 PM
epriestley closed D21077: Remove the (hopefully) obsolete "post_max_size" check during startup.
Thu, Apr 9, 8:33 PM
epriestley requested review of D21077: Remove the (hopefully) obsolete "post_max_size" check during startup.
Thu, Apr 9, 8:28 PM
epriestley added a revision to T13507: Compress Conduit client requests: D21077: Remove the (hopefully) obsolete "post_max_size" check during startup.
Thu, Apr 9, 8:27 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

PHP has a setting called post_max_size. If a POST request is larger than this size, PHP does not populate $_POST or $_FILES.

Thu, Apr 9, 8:22 PM · Performance, Conduit
epriestley added a reverting change for rARC7e25288f4968: Compress requests from the Conduit client to Phabricator: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:25 PM
epriestley committed rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator" (authored by epriestley).
Revert "Compress requests from the Conduit client to Phabricator"
Thu, Apr 9, 7:25 PM
epriestley added a reverting change for D21073: Compress requests from the Conduit client to Phabricator: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:25 PM
epriestley closed D21076: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:25 PM
epriestley requested review of D21076: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:22 PM
epriestley added a reverting change for D21073: Compress requests from the Conduit client to Phabricator: D21076: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:22 PM
epriestley added a reverting change for rARC7e25288f4968: Compress requests from the Conduit client to Phabricator: D21076: Revert "Compress requests from the Conduit client to Phabricator".
Thu, Apr 9, 7:22 PM

Wed, Apr 8

epriestley requested review of D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.
Wed, Apr 8, 7:37 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.
Wed, Apr 8, 7:37 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.
Wed, Apr 8, 7:37 PM · Arcanist
epriestley requested review of D21074: Trivially update "arc branch/feature" and "arc browse" for Toolsets.
Wed, Apr 8, 7:29 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21074: Trivially update "arc branch/feature" and "arc browse" for Toolsets.
Wed, Apr 8, 7:29 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: D21074: Trivially update "arc branch/feature" and "arc browse" for Toolsets.
Wed, Apr 8, 7:29 PM · Arcanist
epriestley committed rARC7e25288f4968: Compress requests from the Conduit client to Phabricator (authored by epriestley).
Compress requests from the Conduit client to Phabricator
Wed, Apr 8, 4:25 PM
epriestley closed D21073: Compress requests from the Conduit client to Phabricator.
Wed, Apr 8, 4:24 PM
epriestley committed rARCdeb72c37db84: Remove onboard future bulk-resolution from ConduitEngine (authored by epriestley).
Remove onboard future bulk-resolution from ConduitEngine
Wed, Apr 8, 4:24 PM
epriestley closed D21072: Remove onboard future bulk-resolution from ConduitEngine.
Wed, Apr 8, 4:24 PM
epriestley committed rARC85141c4d909b: Add new "Hardpoint" classes to support request parallelization (authored by epriestley).
Add new "Hardpoint" classes to support request parallelization
Wed, Apr 8, 4:23 PM
epriestley closed D21071: Add new "Hardpoint" classes to support request parallelization.
Wed, Apr 8, 4:23 PM
epriestley committed rARC0b3cd39230e9: Update the "WorkingCopy" API and create a fallback "Filesystem" working copy (authored by epriestley).
Update the "WorkingCopy" API and create a fallback "Filesystem" working copy
Wed, Apr 8, 4:22 PM
epriestley closed D21070: Update the "WorkingCopy" API and create a fallback "Filesystem" working copy.
Wed, Apr 8, 4:22 PM
epriestley requested review of D21073: Compress requests from the Conduit client to Phabricator.
Wed, Apr 8, 4:21 PM
epriestley added a revision to T13507: Compress Conduit client requests: D21073: Compress requests from the Conduit client to Phabricator.
Wed, Apr 8, 4:21 PM · Performance, Conduit
epriestley claimed T13507: Compress Conduit client requests.
Wed, Apr 8, 3:58 PM · Performance, Conduit
epriestley triaged T13507: Compress Conduit client requests as Normal priority.
Wed, Apr 8, 3:58 PM · Performance, Conduit
epriestley requested review of D21072: Remove onboard future bulk-resolution from ConduitEngine.
Wed, Apr 8, 3:56 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21072: Remove onboard future bulk-resolution from ConduitEngine.
Wed, Apr 8, 3:55 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to D21071: Add new "Hardpoint" classes to support request parallelization.

This also updates the XHPAST linter to target PHP 5.5 (see T13492); it complained about Generator otherwise.

Wed, Apr 8, 3:48 PM
epriestley requested review of D21071: Add new "Hardpoint" classes to support request parallelization.
Wed, Apr 8, 3:48 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21071: Add new "Hardpoint" classes to support request parallelization.
Wed, Apr 8, 3:47 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley requested review of D21070: Update the "WorkingCopy" API and create a fallback "Filesystem" working copy.
Wed, Apr 8, 3:36 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21070: Update the "WorkingCopy" API and create a fallback "Filesystem" working copy.
Wed, Apr 8, 3:35 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

XHPAST currently can't build an AST for $result = yield ..., even though this is a valid construct. This is probably a straightforward fix.

Wed, Apr 8, 1:27 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Tue, Apr 7

epriestley committed rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley).
Fix improper XHPAST parsing of namespace grammar like "use x as private;"
Tue, Apr 7, 9:35 PM
epriestley closed D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:35 PM
epriestley committed rARCe03431def8c0: Fix XHPAST parsing of variadic calls (authored by epriestley).
Fix XHPAST parsing of variadic calls
Tue, Apr 7, 9:33 PM
epriestley closed D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:33 PM
epriestley committed rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format (authored by epriestley).
Update XHPAST "expect" test blocks to the new stable, human-readable format
Tue, Apr 7, 9:32 PM
epriestley closed D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:32 PM
epriestley committed rARC8a7ce97b51a0: Make XHPAST unit test "expect" blocks stable and human-readable (authored by epriestley).
Make XHPAST unit test "expect" blocks stable and human-readable
Tue, Apr 7, 9:32 PM
epriestley closed D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Tue, Apr 7, 9:32 PM
epriestley committed rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code (authored by epriestley).
Remove duplication of XHPAST version in PHP and C code
Tue, Apr 7, 9:31 PM
epriestley closed D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:31 PM
epriestley committed rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3 (authored by epriestley).
Revert xhpast changes that impacted builds under Bison 2.3
Tue, Apr 7, 9:29 PM
epriestley closed D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:29 PM
epriestley closed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) as Resolved by committing rARC763ac445dc8d: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:29 PM · XHPAST
epriestley abandoned D17820: Replace all the PHPAST JSON test data with readable test data.

Superseded by D21066.

Tue, Apr 7, 9:28 PM
epriestley closed T4334: Support PHP5.4+ syntax in XHPAST as Resolved.

Much of this is supported now; T13492 has some general followup.

Tue, Apr 7, 9:27 PM · XHPAST
epriestley requested review of D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:25 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".
Tue, Apr 7, 9:24 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

XHPAST currently can not parse $x = yield $y;.

Tue, Apr 7, 9:21 PM · Infrastructure
epriestley requested review of D21065: Make XHPAST unit test "expect" blocks stable and human-readable.

Test failures are expected.

Tue, Apr 7, 9:14 PM
epriestley requested review of D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:13 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21067: Fix XHPAST parsing of variadic calls.
Tue, Apr 7, 9:12 PM · Infrastructure
epriestley requested review of D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:11 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21066: Update XHPAST "expect" test blocks to the new stable, human-readable format.
Tue, Apr 7, 9:11 PM · Infrastructure
epriestley added a comment to D17819: Make PHPAST parser tests stable and human-readable.

(This was ultimately superseded by D21065.)

Tue, Apr 7, 9:09 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21065: Make XHPAST unit test "expect" blocks stable and human-readable.
Tue, Apr 7, 9:08 PM · Infrastructure
epriestley requested review of D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:05 PM
epriestley added a revision to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5: D21064: Remove duplication of XHPAST version in PHP and C code.
Tue, Apr 7, 9:04 PM · Infrastructure
epriestley renamed T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) from XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3) to XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3).
Tue, Apr 7, 9:03 PM · XHPAST
epriestley requested review of D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:02 PM
epriestley added a revision to T9753: XHPAST no longer parses heredocs and can't build on OS X (Bison 2.3): D21063: Revert xhpast changes that impacted builds under Bison 2.3.
Tue, Apr 7, 9:02 PM · XHPAST
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

This is entangled with T9753.

Tue, Apr 7, 2:08 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

XHPAST currently can not parse $x = yield $y;. I suspect this was added to the PHP grammar after XHPAST diverged. I'm hopeful the fix is straightforward.

Tue, Apr 7, 1:53 PM · Infrastructure
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
Tue, Apr 7, 1:33 PM · Windows, XHPAST
epriestley moved T8653: xhpast generation does not work properly under MinGW if the repo has CRLF line endings from Backlog to Windows on the XHPAST board.
Tue, Apr 7, 1:33 PM · XHPAST
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Future on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Arcanist
epriestley closed T7301: XHPAST application is not optimized for mobile as Wontfix.

No current plans to pursue this.

Tue, Apr 7, 1:32 PM · XHPAST, Mobile
epriestley moved T10971: php lint: catch `"${var}"` vs `"{$var}"` from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Lint, Feature Request
epriestley moved T11081: XHPAST doesn't handle complex embedded variables in strings using the same quoting style from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST, Bug Report
epriestley moved T8049: Improve parsing of variables embedded in strings in XHPAST from Backlog to String Variables on the XHPAST board.
Tue, Apr 7, 1:32 PM · XHPAST