Page MenuHomePhabricator
Feed Advanced Search

Yesterday

epriestley triaged T13619: Provide an administrative tool to adjust TriggerClock configuration as Low priority.
Wed, Feb 24, 10:13 PM · Daemons, Phacility
epriestley updated the task description for T13614: Provide a write-free, non-locking maintenance window for repositories.
Wed, Feb 24, 10:10 PM · Clusters, Diffusion
epriestley triaged T13618: When a Phacility "rbak" device does not exist, backups can run twice and converge to a "successful" but inconsistent state as Wishlist priority.
Wed, Feb 24, 10:03 PM · Phacility

Tue, Feb 23

epriestley closed D21572: When mapping phantom comments across changes, correct an off-by-one issue.
Tue, Feb 23, 7:08 PM
epriestley committed rP6bfa990254a2: When mapping phantom comments across changes, correct an off-by-one issue (authored by epriestley).
When mapping phantom comments across changes, correct an off-by-one issue
Tue, Feb 23, 7:08 PM

Sun, Feb 21

epriestley requested review of D21572: When mapping phantom comments across changes, correct an off-by-one issue.
Sun, Feb 21, 5:04 PM
epriestley added a revision to T13617: Blocks of added lines have an off-by-one error when porting phantom comments: D21572: When mapping phantom comments across changes, correct an off-by-one issue.
Sun, Feb 21, 5:03 PM · Differential
epriestley triaged T13617: Blocks of added lines have an off-by-one error when porting phantom comments as Normal priority.
Sun, Feb 21, 4:38 PM · Differential

Sat, Feb 20

epriestley triaged T13616: Formally support ad-hoc invoicing in Phortune as Wishlist priority.
Sat, Feb 20, 5:37 PM · Phortune

Fri, Feb 19

epriestley closed T12795: Move PHUICircleView to PHUIButtonView as Wontfix.

It appears that PHUICircleView no longer exists, so calling this moot.

Fri, Feb 19, 10:55 PM · PHUI
epriestley closed T12911: Better handling for users subscribed to objects they cannot see as Resolved.

See T13602 for modern followup, recent changes, and plans.

Fri, Feb 19, 10:52 PM · Spaces, Feature Request
epriestley closed T12908: Allow verbosity of Aphlict log to be reduced as Resolved.

I think this was at least approximately resolved by D21115, which made the default log much quieter and the "debug" log more verbose.

Fri, Feb 19, 10:51 PM · Aphlict, Feature Request
epriestley added a revision to T12908: Allow verbosity of Aphlict log to be reduced: D21115: Reduce the verbosity of the "Aphlict" log.
Fri, Feb 19, 10:50 PM · Aphlict, Feature Request
epriestley added a task to D21115: Reduce the verbosity of the "Aphlict" log: T12908: Allow verbosity of Aphlict log to be reduced.
Fri, Feb 19, 10:50 PM
epriestley committed rPb047653e536e: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult" (authored by epriestley).
Lift core of "HeraldConditionResult" to "HeraldTranscriptResult"
Fri, Feb 19, 7:16 PM
epriestley committed rP5bfd6bda7733: Provide a more structured result log for Herald rules (authored by epriestley).
Provide a more structured result log for Herald rules
Fri, Feb 19, 7:16 PM
epriestley committed rPe77ae13d5c71: Provide a more structured result log for Herald conditions (authored by epriestley).
Provide a more structured result log for Herald conditions
Fri, Feb 19, 7:16 PM
epriestley closed D21563: Provide a more structured result log for Herald conditions.
Fri, Feb 19, 7:16 PM
epriestley closed D21564: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult".
Fri, Feb 19, 7:16 PM
epriestley committed rP20a54a3006de: Apply "pcre.*_limit" ini options in web environments (authored by epriestley).
Apply "pcre.*_limit" ini options in web environments
Fri, Feb 19, 7:16 PM
epriestley closed D21567: Apply "pcre.*_limit" ini options in web environments.
Fri, Feb 19, 7:16 PM
epriestley closed D21565: Provide a more structured result log for Herald rules.
Fri, Feb 19, 7:16 PM
epriestley committed rP5408429466b5: Separate Herald transcripts into several different views (authored by epriestley).
Separate Herald transcripts into several different views
Fri, Feb 19, 7:16 PM
epriestley closed D21493: Separate Herald transcripts into several different views.
Fri, Feb 19, 7:16 PM
epriestley closed D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Fri, Feb 19, 7:16 PM
epriestley committed rARCe95afd1d005c: Apply "pcre.*_limit" config options at startup in CLI environments (authored by epriestley).
Apply "pcre.*_limit" config options at startup in CLI environments
Fri, Feb 19, 7:16 PM
epriestley committed rARC9d5802cb9f08: Provide some "preg_*" wrappers which raise exceptions on failure (authored by epriestley).
Provide some "preg_*" wrappers which raise exceptions on failure
Fri, Feb 19, 7:16 PM
epriestley closed D21566: Apply "pcre.*_limit" config options at startup in CLI environments.
Fri, Feb 19, 7:16 PM
epriestley edited the content of Changelog.
Fri, Feb 19, 7:04 PM
epriestley closed T13615: Facebook OAuth adapter is failing with "security_settings" error as Resolved.

Seems okay for me, too. Calling this resolved, thanks for the report!

Fri, Feb 19, 7:04 PM · Facebook, Auth
epriestley committed rP05745dfd024b: (stable) Promote 2021 Week 8 (authored by epriestley).
(stable) Promote 2021 Week 8
Fri, Feb 19, 7:03 PM
epriestley created an object: 2021 Week 8 (Late February).
Fri, Feb 19, 7:03 PM
epriestley created Blog Post: Quick Look: Improved UI for Exiled Users.
Fri, Feb 19, 6:58 PM · Policy
epriestley committed rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property (authored by epriestley).
Remove Facebook OAuth dependency on "security_settings" property
Fri, Feb 19, 6:27 PM
epriestley closed D21571: Remove Facebook OAuth dependency on "security_settings" property.
Fri, Feb 19, 6:27 PM
epriestley requested review of D21571: Remove Facebook OAuth dependency on "security_settings" property.
Fri, Feb 19, 6:27 PM
epriestley added a revision to T13615: Facebook OAuth adapter is failing with "security_settings" error: D21571: Remove Facebook OAuth dependency on "security_settings" property.
Fri, Feb 19, 6:25 PM · Facebook, Auth
epriestley triaged T13615: Facebook OAuth adapter is failing with "security_settings" error as Low priority.
Fri, Feb 19, 5:16 PM · Facebook, Auth
epriestley closed T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Resolved.

That covered everything that looked low-hanging.

Fri, Feb 19, 4:35 PM · Database, Differential
epriestley triaged T13614: Provide a write-free, non-locking maintenance window for repositories as Normal priority.
Fri, Feb 19, 4:27 PM · Clusters, Diffusion
epriestley committed rPb3976acc40a6: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php" (authored by epriestley).
Improve performance of "phabricator:20210215.changeset.02.phid-populate.php"
Fri, Feb 19, 3:53 PM
epriestley closed D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".
Fri, Feb 19, 3:53 PM
epriestley added a comment to D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".

From "--trace", client PHID generation seems to be the limiting factor.

Fri, Feb 19, 3:52 PM
epriestley requested review of D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".
Fri, Feb 19, 3:49 PM
epriestley added a revision to T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php": D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".
Fri, Feb 19, 3:48 PM · Database, Differential
epriestley updated the task description for T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php".
Fri, Feb 19, 3:21 PM · Database, Differential
epriestley triaged T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Low priority.
Fri, Feb 19, 3:21 PM · Database, Differential
epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

A minimal implementation here is probably:

Fri, Feb 19, 4:57 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Fri, Feb 19, 4:47 AM · Herald, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Fri, Feb 19, 4:37 AM · Plans, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Fri, Feb 19, 4:34 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Fri, Feb 19, 4:31 AM · Herald, Harbormaster
epriestley closed T10260: Harbormaster Herald Rules as Resolved.
Fri, Feb 19, 4:31 AM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10260: Harbormaster Herald Rules.

See T13612 for followup.

Fri, Feb 19, 4:31 AM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley closed T5491: Harbormaster Build Notification Status as Resolved.

Continued in T13612.

Fri, Feb 19, 4:24 AM · Restricted Project, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Fri, Feb 19, 4:23 AM · Herald, Harbormaster
epriestley triaged T13612: Support Herald rules for Harbormaster Builds as Normal priority.
Fri, Feb 19, 4:22 AM · Herald, Harbormaster

Thu, Feb 18

epriestley triaged T13611: In clusters, "writable" property on bindings may not actually prevent writes as Low priority.
Thu, Feb 18, 11:54 PM · Clusters, Diffusion
epriestley triaged T13610: Support per-node billing for hosted Phacility instances as Low priority.
Thu, Feb 18, 11:38 PM · Phortune, Phacility
epriestley closed T13609: Expose buildable object and container PHIDs as build variables as Resolved.
Thu, Feb 18, 9:38 PM · Differential, Harbormaster
epriestley committed rP7c44657ca573: Add more useful PHIDs to Harbormaster build variables (authored by epriestley).
Add more useful PHIDs to Harbormaster build variables
Thu, Feb 18, 9:38 PM
epriestley closed D21569: Add more useful PHIDs to Harbormaster build variables.
Thu, Feb 18, 9:38 PM
epriestley requested review of D21569: Add more useful PHIDs to Harbormaster build variables.
Thu, Feb 18, 9:37 PM
epriestley added a revision to T13609: Expose buildable object and container PHIDs as build variables: D21569: Add more useful PHIDs to Harbormaster build variables.
Thu, Feb 18, 9:35 PM · Differential, Harbormaster
epriestley triaged T13609: Expose buildable object and container PHIDs as build variables as Normal priority.
Thu, Feb 18, 9:32 PM · Differential, Harbormaster
epriestley added a comment to T12952: Reviewer not able to see diff.

See T13602 for eventual followup.

Thu, Feb 18, 8:16 PM · Differential, Bug Report
epriestley closed T4411: Adding a CC to a Maniphest Task should give View rights for that user as Resolved.

I'm going to close this in favor of T13602, which has a more cohesive/modern discussion of the issue. Broadly:

Thu, Feb 18, 8:15 PM · Wikimedia, Policy
epriestley committed rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley).
Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Thu, Feb 18, 7:59 PM
epriestley closed D21568: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.
Thu, Feb 18, 7:59 PM
epriestley requested review of D21568: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.
Thu, Feb 18, 7:58 PM
epriestley added a revision to T13608: Remarkup hyperlink pattern may backtrack explosively: D21568: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.
Thu, Feb 18, 7:56 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

Ah! I like that fix, and it also works for me locally. I think the protocol-length-limit is reasonable to retain on the basis of general sanity, but I'll add the negative lookbehind to further encourage PCRE to run in something resembling O(N) time.

Thu, Feb 18, 7:52 PM
epriestley requested review of D21567: Apply "pcre.*_limit" ini options in web environments.
Thu, Feb 18, 7:23 PM
epriestley added a revision to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values: D21567: Apply "pcre.*_limit" ini options in web environments.
Thu, Feb 18, 7:21 PM · Phacility
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21567: Apply "pcre.*_limit" ini options in web environments.
Thu, Feb 18, 7:21 PM · Herald
epriestley requested review of D21566: Apply "pcre.*_limit" config options at startup in CLI environments.
Thu, Feb 18, 7:18 PM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21566: Apply "pcre.*_limit" config options at startup in CLI environments.
Thu, Feb 18, 7:17 PM · Herald
epriestley added a revision to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values: D21566: Apply "pcre.*_limit" config options at startup in CLI environments.
Thu, Feb 18, 7:17 PM · Phacility
epriestley requested review of D21565: Provide a more structured result log for Herald rules.
Thu, Feb 18, 6:54 PM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21565: Provide a more structured result log for Herald rules.
Thu, Feb 18, 6:53 PM · Herald
epriestley requested review of D21564: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult".
Thu, Feb 18, 5:43 PM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21564: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult".
Thu, Feb 18, 5:42 PM · Herald

Wed, Feb 17

epriestley requested review of D21563: Provide a more structured result log for Herald conditions.
Wed, Feb 17, 9:49 PM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21563: Provide a more structured result log for Herald conditions.
Wed, Feb 17, 9:48 PM · Herald
epriestley added a revision to T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values: D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 9:37 PM · Phacility
epriestley updated the summary of D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 9:37 PM
epriestley added a revision to T13586: In Herald transcripts, surface exceptions encountered while evaluating fields: D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 9:37 PM · Herald
epriestley closed T13608: Remarkup hyperlink pattern may backtrack explosively as Resolved.

This is at least approximately resolved by D21562. Hopefully that'll stick if I don't kick it anymore. I may or may not land D21561, depending on whether I ultimately use it in T13586.

Wed, Feb 17, 9:23 PM
epriestley committed rPbd4d9d88f2df: Limit remarkup URI protocol length to 32 characters to avoid expensive regex… (authored by epriestley).
Limit remarkup URI protocol length to 32 characters to avoid expensive regex…
Wed, Feb 17, 9:21 PM
epriestley closed D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:21 PM
epriestley requested review of D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:13 PM
epriestley added a revision to T13608: Remarkup hyperlink pattern may backtrack explosively: D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:12 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

This passes tests, but it sure is a big mess compared to a 3-character change to just add a maximum length, and discretion is the better part of avoiding a sunk cost fallacy or something along those lines:

Wed, Feb 17, 9:00 PM
epriestley requested review of D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 8:44 PM
epriestley added a revision to T13608: Remarkup hyperlink pattern may backtrack explosively: D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 8:44 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

At least on my system, no: \w+, \w{3,}, and \w{3,}+ all take 60s+ to (fail to) match AAAAAAAA... (with total length 512KB).

Wed, Feb 17, 8:31 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

We also can't pass $flags to preg_replace_callback(...) because it wasn't supported until PHP 7.4. This means preg_replace_callback() can't operate on a match-offset basis.

Wed, Feb 17, 6:22 PM
epriestley triaged T13608: Remarkup hyperlink pattern may backtrack explosively as Low priority.
Wed, Feb 17, 6:16 PM
epriestley updated the diff for D21493: Separate Herald transcripts into several different views.
  • Fix regexp issue.
Wed, Feb 17, 4:05 PM
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.

I've deployed these changes to secure, so hopefully any issues will present themselves.

Wed, Feb 17, 12:18 AM · Search