Page MenuHomePhabricator
Feed Advanced Search

Today

epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

cd provides "at least once" delivery guarantees.

Wed, Jun 26, 1:44 AM · Daemons, Phacility
epriestley committed rPHU340e00f6622d: When matching process titles, don't attempt a match if we're out of "argv" parts (authored by epriestley).
When matching process titles, don't attempt a match if we're out of "argv" parts
Wed, Jun 26, 1:27 AM
epriestley closed D20620: When matching process titles, don't attempt a match if we're out of "argv" parts.
Wed, Jun 26, 1:26 AM

Yesterday

epriestley requested review of D20620: When matching process titles, don't attempt a match if we're out of "argv" parts.
Tue, Jun 25, 10:21 PM
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: D20620: When matching process titles, don't attempt a match if we're out of "argv" parts.
Tue, Jun 25, 10:21 PM · Daemons, Phacility
epriestley committed rPHU71666e588072: Make "PhutilProcessQuery" detection of overseer processes more robust (authored by epriestley).
Make "PhutilProcessQuery" detection of overseer processes more robust
Tue, Jun 25, 9:57 PM
epriestley closed D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Tue, Jun 25, 9:57 PM
epriestley committed rP2d2626d73f0b: (stable) Bump the remarkup cache version after JIRA/Asana rule changes (authored by epriestley).
(stable) Bump the remarkup cache version after JIRA/Asana rule changes
Tue, Jun 25, 9:57 PM
epriestley committed rP987e10461056: Bump the remarkup cache version after JIRA/Asana rule changes (authored by epriestley).
Bump the remarkup cache version after JIRA/Asana rule changes
Tue, Jun 25, 9:56 PM
epriestley closed D20619: Bump the remarkup cache version after JIRA/Asana rule changes.
Tue, Jun 25, 9:56 PM
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

Yeah, I suppose most of my skepticism comes from not knowing any other examples of long-loved processes parsing ps output instead of using PID files.

Tue, Jun 25, 9:50 PM
epriestley requested review of D20619: Bump the remarkup cache version after JIRA/Asana rule changes.
Tue, Jun 25, 7:56 PM
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20619: Bump the remarkup cache version after JIRA/Asana rule changes.
Tue, Jun 25, 7:55 PM · Remarkup, Diffusion
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
  • Fix typo.
  • Fix out-of-date comment/logic around overseer tests.
Tue, Jun 25, 7:45 PM
epriestley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

This whole series of changes is motivated by "a PID file was out of date because of a reboot, and we tried to kill some other random process", right? Was there anything else that PID file tracking wasn't doing correctly?

Tue, Jun 25, 7:43 PM
epriestley added a revision to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts: Unknown Object (Differential Revision).
Tue, Jun 25, 5:50 PM · Phacility
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

This incantation seems to work as an upstart job:

Tue, Jun 25, 5:46 PM · Phacility
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

I'm going to install an upstart task on secure004 and kick it a few times, some stuff might be sketchy until I figure that out.

Tue, Jun 25, 5:17 PM · Phacility
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Support multiple request encodings (likely BSON, protobuf, or messagepack). Leave JSON as the default, but in cases where messages can not be represented in JSON this gives us a plausible way forward.

Tue, Jun 25, 4:55 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

The stalled production backup process completed successfully after deploying the change.

Tue, Jun 25, 3:54 PM · Restricted Project, Infrastructure, Phacility
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also PHI1318. The new behavior here has tightened our rules about which users we act as.

Tue, Jun 25, 2:38 PM · Diffusion, Differential
epriestley committed rPccf207f20928: (stable) Limit the read buffer size in `bin/storage dump` (authored by epriestley).
(stable) Limit the read buffer size in `bin/storage dump`
Tue, Jun 25, 2:17 PM
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

I'm going to try to sneak this out to the db tier to resolve things before the west coast wakes up, at least.

Tue, Jun 25, 2:17 PM · Restricted Project, Infrastructure, Phacility
epriestley committed rPeaa60334ec16: Limit the read buffer size in `bin/storage dump` (authored by epriestley).
Limit the read buffer size in `bin/storage dump`
Tue, Jun 25, 2:17 PM
epriestley closed D20617: Limit the read buffer size in `bin/storage dump`.
Tue, Jun 25, 2:17 PM
epriestley requested review of D20617: Limit the read buffer size in `bin/storage dump`.
Tue, Jun 25, 12:27 PM
epriestley added a revision to T13328: Database dumps can buffer (?) too much data to hold in memory: D20617: Limit the read buffer size in `bin/storage dump`.
Tue, Jun 25, 12:25 PM · Restricted Project, Infrastructure, Phacility
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

PHP Fatal error: Out of memory (allocated 311164928) (tried to allocate 105988097 bytes) in /core/lib/libphutil/src/future/exec/ExecFuture.php on line 246

Tue, Jun 25, 12:18 PM · Restricted Project, Infrastructure, Phacility
epriestley created T13328: Database dumps can buffer (?) too much data to hold in memory.
Tue, Jun 25, 12:06 PM · Restricted Project, Infrastructure, Phacility
epriestley requested review of D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Tue, Jun 25, 12:52 AM
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.
Tue, Jun 25, 12:51 AM · Daemons, Phacility

Mon, Jun 24

epriestley committed rPd1704f04d331: (stable) Consider "all account members are disabled" to be a permanent failure… (authored by epriestley).
(stable) Consider "all account members are disabled" to be a permanent failure…
Mon, Jun 24, 11:13 PM
epriestley committed rPccfc74702f67: (stable) Make "bin/files" parsing of working set arguments more consistent (authored by epriestley).
(stable) Make "bin/files" parsing of working set arguments more consistent
Mon, Jun 24, 11:13 PM
epriestley committed rPda0dfc057d64: Make "bin/files" parsing of working set arguments more consistent (authored by epriestley).
Make "bin/files" parsing of working set arguments more consistent
Mon, Jun 24, 11:02 PM
epriestley closed D20614: Make "bin/files" parsing of working set arguments more consistent.
Mon, Jun 24, 11:02 PM
epriestley closed T13326: "bin/files integrity" misparses file selection arguments as Resolved by committing rPda0dfc057d64: Make "bin/files" parsing of working set arguments more consistent.
Mon, Jun 24, 11:02 PM · Files
epriestley committed rPa3397fb87613: Consider "all account members are disabled" to be a permanent failure when… (authored by epriestley).
Consider "all account members are disabled" to be a permanent failure when…
Mon, Jun 24, 10:29 PM
epriestley closed D20613: Consider "all account members are disabled" to be a permanent failure when billing a Phortune subscription.
Mon, Jun 24, 10:29 PM
epriestley closed T13327: When all payment account members are disabled, subscription workers fail infinitely as Resolved by committing rPa3397fb87613: Consider "all account members are disabled" to be a permanent failure when….
Mon, Jun 24, 10:29 PM · Phortune, Phacility
epriestley requested review of D20614: Make "bin/files" parsing of working set arguments more consistent.
Mon, Jun 24, 10:14 PM
epriestley added a revision to T13326: "bin/files integrity" misparses file selection arguments: D20614: Make "bin/files" parsing of working set arguments more consistent.
Mon, Jun 24, 10:13 PM · Files
epriestley requested review of D20613: Consider "all account members are disabled" to be a permanent failure when billing a Phortune subscription.
Mon, Jun 24, 9:51 PM
epriestley added a revision to T13327: When all payment account members are disabled, subscription workers fail infinitely: D20613: Consider "all account members are disabled" to be a permanent failure when billing a Phortune subscription.
Mon, Jun 24, 9:50 PM · Phortune, Phacility
epriestley created T13327: When all payment account members are disabled, subscription workers fail infinitely.
Mon, Jun 24, 9:33 PM · Phortune, Phacility
epriestley committed rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons (authored by epriestley).
Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
Mon, Jun 24, 6:29 PM
epriestley closed D20608: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons.
Mon, Jun 24, 6:29 PM
epriestley committed rPHU7adfe4e4f4a3: Stop writing PID files in daemons (authored by epriestley).
Stop writing PID files in daemons
Mon, Jun 24, 6:28 PM
epriestley closed D20607: Stop writing PID files in daemons.
Mon, Jun 24, 6:28 PM
epriestley committed rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files (authored by epriestley).
Make "phd start" and "phd reload" use the process list, not PID files
Mon, Jun 24, 6:27 PM
epriestley closed D20606: Make "phd start" and "phd reload" use the process list, not PID files.
Mon, Jun 24, 6:27 PM
epriestley committed rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of… (authored by epriestley).
Make "bin/phd status" report local daemons from the process list, not a mess of…
Mon, Jun 24, 6:26 PM
epriestley closed T11037: `bin/phd status` is misleading about local / remote daemons as Resolved by committing rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of….
Mon, Jun 24, 6:26 PM · Daemons, Restricted Project
epriestley closed D20604: Make "bin/phd status" report local daemons from the process list, not a mess of local/remote information.
Mon, Jun 24, 6:26 PM
epriestley committed rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()" (authored by epriestley).
Remove "PhutilDaemonOverseer->findRunningDaemons()"
Mon, Jun 24, 6:23 PM
epriestley closed D20603: Remove "PhutilDaemonOverseer->findRunningDaemons()".
Mon, Jun 24, 6:23 PM
epriestley committed rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation (authored by epriestley).
Deprecate "bin/phd ... --gently" and update documentation
Mon, Jun 24, 6:16 PM
epriestley closed D20602: Deprecate "bin/phd ... --gently" and update documentation.
Mon, Jun 24, 6:16 PM
epriestley committed rPd98bf8ef8ee6: Drive "phd stop" entirely from the process list, not PID files on disk (authored by epriestley).
Drive "phd stop" entirely from the process list, not PID files on disk
Mon, Jun 24, 6:06 PM
epriestley closed D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
Mon, Jun 24, 6:06 PM
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
  • Rebase to clear tests.
Mon, Jun 24, 6:00 PM
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
  • Wordsmithing: "any instance" -> "all instances"
Mon, Jun 24, 5:58 PM
epriestley committed rPHUb6505e98bfbc: Formalize a "Query" class for looking at the process list (authored by epriestley).
Formalize a "Query" class for looking at the process list
Mon, Jun 24, 5:53 PM
epriestley closed D20600: Formalize a "Query" class for looking at the process list.
Mon, Jun 24, 5:53 PM
epriestley committed rPHUb9f35642c4e0: Parse remarkup tables with something like a real parser instead of regular… (authored by epriestley).
Parse remarkup tables with something like a real parser instead of regular…
Mon, Jun 24, 5:51 PM
epriestley closed D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
Mon, Jun 24, 5:51 PM
Herald updated subscribers of T13160: Support <colgroup> in the verbose remarkup <table> syntax for specifying column widths.
Mon, Jun 24, 5:51 PM · Remarkup
epriestley committed rP09ecf49ee454: (stable) Require commit identities when editing commits to resolve an issue… (authored by epriestley).
(stable) Require commit identities when editing commits to resolve an issue…
Mon, Jun 24, 5:51 PM
epriestley committed rP75c359835903: Require commit identities when editing commits to resolve an issue with audit… (authored by epriestley).
Require commit identities when editing commits to resolve an issue with audit…
Mon, Jun 24, 5:50 PM
epriestley closed D20612: Require commit identities when editing commits to resolve an issue with audit actions not applying properly.
Mon, Jun 24, 5:50 PM
epriestley requested review of D20612: Require commit identities when editing commits to resolve an issue with audit actions not applying properly.
Mon, Jun 24, 4:27 PM
kerberizer awarded T13323: Remove the "CAN_EDIT on a parent project implies CAN_EDIT on a child project" policy rule a Like token.
Mon, Jun 24, 7:01 AM · Policy, Projects

Sat, Jun 22

epriestley added a comment to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.

See one followup in T13326. The "import from disk" part seems to have worked properly in production.

Sat, Jun 22, 4:51 PM · Phacility, Files
epriestley closed T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological" as Resolved.
Sat, Jun 22, 4:50 PM · Infrastructure
epriestley created T13326: "bin/files integrity" misparses file selection arguments.
Sat, Jun 22, 4:50 PM · Files
epriestley committed rPHUb675a06bf741: (stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort… (authored by epriestley).
(stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort…
Sat, Jun 22, 4:06 PM
epriestley committed rPHUf5879cc6a9dc: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function (authored by epriestley).
Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
Sat, Jun 22, 4:06 PM
epriestley closed D20611: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function.
Sat, Jun 22, 4:05 PM
epriestley requested review of D20611: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function.
Sat, Jun 22, 4:04 PM
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20611: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function.
Sat, Jun 22, 4:03 PM · Transactions
epriestley edited the content of Changelog.
Sat, Jun 22, 2:55 PM
Herald added 1 auditor(s) for rARCdb4cd55d4673: Merge branch "master" into "experimental".: Cowboy Commits.
Merge branch "master" into "experimental".
Sat, Jun 22, 2:40 PM
epriestley created an object: 2019 Week 25 (Late June).
Sat, Jun 22, 2:39 PM
epriestley committed rPHU674d69718e88: (stable) Promote 2019 Week 25 (authored by epriestley).
(stable) Promote 2019 Week 25
Sat, Jun 22, 2:38 PM
Herald added 1 auditor(s) for rARCfeb5f4d42c4f: (stable) Promote 2019 Week 25: Cowboy Commits.
(stable) Promote 2019 Week 25
Sat, Jun 22, 2:38 PM
Herald added 1 auditor(s) for rP51cd3f097928: (stable) Promote 2019 Week 25: Cowboy Commits.
(stable) Promote 2019 Week 25
Sat, Jun 22, 2:37 PM

Fri, Jun 21

20after4 awarded T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion a Mountain of Wealth token.
Fri, Jun 21, 9:06 PM · Remarkup, Diffusion
20after4 awarded D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion a Mountain of Wealth token.
Fri, Jun 21, 9:05 PM
epriestley committed rPca56e8590a3d: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way… (authored by epriestley).
Don't handle JIRA/Asana URIs with anchors or query parameters in a special way…
Fri, Jun 21, 1:34 PM
epriestley closed D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Fri, Jun 21, 1:34 PM
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

I'm just going to land this as-is pending feedback on actual use cases, anticipating a followup to do parameter/anchor support if some reasonable #comment-123 URI exists in either external system. Then it will at least be easy for us to link-and-preserve-parameters or decline-to-link and we can figure out whatever else arises on a case-by-case basis.

Fri, Jun 21, 1:34 PM

Thu, Jun 20

epriestley committed rPc0dc411d2319: Update "phabricator/" for "topological" API changes (authored by epriestley).
Update "phabricator/" for "topological" API changes
Thu, Jun 20, 11:12 PM
epriestley closed D20599: Update "phabricator/" for "topological" API changes.
Thu, Jun 20, 11:12 PM
epriestley added a comment to rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.

(Build failure is just D20599 landing out-of-order, oops.)

Thu, Jun 20, 11:10 PM
epriestley committed rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects (authored by epriestley).
Fix an issue in Owners where a transaction change could show too many effects
Thu, Jun 20, 11:08 PM
epriestley closed D20596: Fix an issue in Owners where a transaction change could show too many effects.
Thu, Jun 20, 11:08 PM
epriestley closed T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly as Resolved by committing rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.
Thu, Jun 20, 11:08 PM · Owners
epriestley committed rARCd92fa96366c0: Fix two "msort()" vs "msortv()" issues in "arc land" (authored by epriestley).
Fix two "msort()" vs "msortv()" issues in "arc land"
Thu, Jun 20, 11:07 PM
epriestley closed D20605: Fix two "msort()" vs "msortv()" issues in "arc land".
Thu, Jun 20, 11:07 PM
epriestley committed rARC1ef94098179f: Update "arcanist/" for "topological" API changes (authored by epriestley).
Update "arcanist/" for "topological" API changes
Thu, Jun 20, 11:05 PM
epriestley closed D20598: Update "arcanist/" for "topological" API changes.
Thu, Jun 20, 11:05 PM