Page MenuHomePhabricator
Feed Advanced Search

Yesterday

epriestley closed T12746: Add support for PHUIPinboardItemView to timeline/transactions as Wontfix.

Probably a good idea, but not worth keeping a task around for.

Wed, Feb 20, 11:33 PM · Maniphest, Macros, Transactions
epriestley closed T11824: Use Pinboard view in Maniphest Mocks tab as Wontfix.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

Wed, Feb 20, 11:32 PM · Pholio, Maniphest
epriestley edited projects for T10571: Default quote action breaks text between lists, added: Remarkup; removed Maniphest, Bug Report.
Wed, Feb 20, 11:31 PM · Remarkup, Wikimedia
epriestley closed T10567: Ability to know who can do what in Maniphest EditEngine as Wontfix.
Wed, Feb 20, 11:30 PM · ApplicationEditor, Maniphest, Feature Request
epriestley edited projects for T7443: Include full link to Maniphest tasks in commit messages, added: Diffusion; removed Maniphest.
Wed, Feb 20, 11:29 PM · Diffusion, Arcanist
epriestley moved T6896: Add group by 'author' to maniphest search results from Backlog to vNext on the Maniphest board.
Wed, Feb 20, 11:29 PM · Maniphest
epriestley moved T5679: Search daemon fails when document title >255 chars from Backlog to vNext on the Maniphest board.
Wed, Feb 20, 11:28 PM · Maniphest
epriestley closed T4548: Support "Mylyn" Eclipse plugin as Wontfix.

We have no customer interest in this and no current plans to pursue it.

Wed, Feb 20, 11:27 PM · Feature Request, Maniphest
epriestley moved T4316: Allow a comment to be added on the Maniphest edit interface from vNext to Far Future on the Maniphest board.
Wed, Feb 20, 11:25 PM · Maniphest
epriestley committed rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining… (authored by epriestley).
Add "random_int" and "random_bytes" as builtins so the linter stops complaining…
Wed, Feb 20, 11:03 PM
epriestley closed D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Wed, Feb 20, 11:03 PM
epriestley requested review of D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Wed, Feb 20, 10:59 PM
epriestley accepted D20201: Add milliseconds and microseconds to phutil_units.
Wed, Feb 20, 10:38 PM
epriestley accepted D20200: Track total time from task creation to task archival.

Looks good to me. I'll see about getting random_bytes and random_int into the builtins map to fix that lint thing.

Wed, Feb 20, 10:29 PM
epriestley added a comment to D20200: Track total time from task creation to task archival.

I think it's fine to let dateModified update to the current time -- you're technically modifying the thing.

Wed, Feb 20, 10:10 PM
epriestley accepted D20200: Track total time from task creation to task archival.
Wed, Feb 20, 7:21 PM
epriestley committed rP1b8325642112: Don't enable the "ScopeEngine" or try to identify scope context for diffs… (authored by epriestley).
Don't enable the "ScopeEngine" or try to identify scope context for diffs…
Wed, Feb 20, 6:16 PM
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP1b8325642112: Don't enable the "ScopeEngine" or try to identify scope context for diffs….
Wed, Feb 20, 6:16 PM · Differential, Plans
epriestley closed D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Wed, Feb 20, 6:16 PM
epriestley committed rPf1a035d5c2c6: In Differential, give the "moved/copied from" gutter a more clear visual look (authored by epriestley).
In Differential, give the "moved/copied from" gutter a more clear visual look
Wed, Feb 20, 6:12 PM
epriestley closed D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Wed, Feb 20, 6:12 PM
epriestley committed rPa33409991c27: Remove an old Differential selection behavior (authored by epriestley).
Remove an old Differential selection behavior
Wed, Feb 20, 6:09 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rPa33409991c27: Remove an old Differential selection behavior.
Wed, Feb 20, 6:09 PM · Differential
epriestley closed D20196: Remove an old Differential selection behavior.
Wed, Feb 20, 6:09 PM
epriestley added a comment to T13253: Plans: Daemon Status Reporting.

I'm looking at these storage/backend changes:

Wed, Feb 20, 6:05 PM · Plans, Daemons
epriestley committed rPc10b283b9270: Remove some ancient daemon log code (authored by epriestley).
Remove some ancient daemon log code
Wed, Feb 20, 5:52 PM
epriestley added a commit to T13253: Plans: Daemon Status Reporting: rPc10b283b9270: Remove some ancient daemon log code.
Wed, Feb 20, 5:52 PM · Plans, Daemons
epriestley closed D20199: Remove some ancient daemon log code.
Wed, Feb 20, 5:52 PM
epriestley requested review of D20199: Remove some ancient daemon log code.
Wed, Feb 20, 5:36 PM
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20199: Remove some ancient daemon log code.
Wed, Feb 20, 5:34 PM · Plans, Daemons
epriestley closed T8343: Copied code detection takes >30s on 48MB diff as Resolved.

Presuming resolved by D19748 since we don't have an actual reproduction case.

Wed, Feb 20, 2:52 PM · Differential
epriestley closed T11714: Unified diffs don't allow selecting text in inline comments as Resolved.

D20196 removes this code.

Wed, Feb 20, 2:50 PM · Differential, Bug Report
epriestley added a comment to T7878: strange "moved from" signal in [Phriction] diff.

I think it had some white-space removed from its end.

Wed, Feb 20, 2:15 PM · Differential
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Wed, Feb 20, 1:15 PM · Differential, Plans
epriestley requested review of D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Wed, Feb 20, 1:12 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Wed, Feb 20, 1:10 PM · Differential, Plans
epriestley added a child revision for D20197: In Differential, give the "moved/copied from" gutter a more clear visual look: D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Wed, Feb 20, 1:10 PM
epriestley requested review of D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Wed, Feb 20, 12:46 PM
epriestley added a child revision for D20196: Remove an old Differential selection behavior: D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Wed, Feb 20, 12:44 PM
leoluk awarded D20191: Behold! Copy text from either side of a diff! a Mountain of Wealth token.
Wed, Feb 20, 9:36 AM
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

After D20194, expansion of tabs now uses the correct rule (expand tabs to the next tabstop) instead of the old rule (hard-coded replacement with a fixed number of spaces).

Wed, Feb 20, 5:44 AM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Wed, Feb 20, 5:04 AM · Differential, Plans
epriestley requested review of D20196: Remove an old Differential selection behavior.
Wed, Feb 20, 5:00 AM
epriestley added a revision to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: D20196: Remove an old Differential selection behavior.
Wed, Feb 20, 4:58 AM · Differential
epriestley committed rARC2c494385ffd6: Merge branch "master" into "experimental" (authored by epriestley).
Merge branch "master" into "experimental"
Wed, Feb 20, 4:57 AM
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery, a subtask of T13161: Plans: Improve Differential diff display behaviors, as Resolved.
Wed, Feb 20, 4:48 AM · Differential, Plans
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery as Resolved.

There are probably still a few remaining kinks to work out here, but I believe this is substantially resolved:

Wed, Feb 20, 4:48 AM · Differential

Tue, Feb 19

epriestley committed rPcf048f4402fe: Tweak some display behaviors for indent indicators (authored by epriestley).
Tweak some display behaviors for indent indicators
Tue, Feb 19, 11:34 PM
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rPcf048f4402fe: Tweak some display behaviors for indent indicators.
Tue, Feb 19, 11:34 PM · Differential, Plans
epriestley closed D20195: Tweak some display behaviors for indent indicators.
Tue, Feb 19, 11:34 PM
epriestley added a commit to T2495: Improve whitespace expansion of tab literals: rPfe7047d12d69: Display some invisible/nonprintable characters in diffs by default.
Tue, Feb 19, 11:22 PM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley committed rPfe7047d12d69: Display some invisible/nonprintable characters in diffs by default (authored by epriestley).
Display some invisible/nonprintable characters in diffs by default
Tue, Feb 19, 11:22 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rPfe7047d12d69: Display some invisible/nonprintable characters in diffs by default.
Tue, Feb 19, 11:21 PM · Differential
epriestley closed D20194: Display some invisible/nonprintable characters in diffs by default.
Tue, Feb 19, 11:21 PM
epriestley added inline comments to D20194: Display some invisible/nonprintable characters in diffs by default.
Tue, Feb 19, 11:20 PM
epriestley committed rPefccd75ae371: Correct various minor diff copy behaviors (authored by epriestley).
Correct various minor diff copy behaviors
Tue, Feb 19, 11:19 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rPefccd75ae371: Correct various minor diff copy behaviors.
Tue, Feb 19, 11:18 PM · Differential
epriestley closed D20192: Correct various minor diff copy behaviors.
Tue, Feb 19, 11:18 PM
epriestley committed rP37f12a05ea62: Behold! Copy text from either side of a diff! (authored by epriestley).
Behold! Copy text from either side of a diff!
Tue, Feb 19, 11:17 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rP37f12a05ea62: Behold! Copy text from either side of a diff!.
Tue, Feb 19, 11:17 PM · Differential
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP37f12a05ea62: Behold! Copy text from either side of a diff!.
Tue, Feb 19, 11:17 PM · Differential, Plans
epriestley closed D20191: Behold! Copy text from either side of a diff!.
Tue, Feb 19, 11:17 PM
epriestley committed rP3ded5d3e8ca8: Disable the JSHint "function called before it is defined" and "unused… (authored by epriestley).
Disable the JSHint "function called before it is defined" and "unused…
Tue, Feb 19, 11:14 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rP3ded5d3e8ca8: Disable the JSHint "function called before it is defined" and "unused….
Tue, Feb 19, 11:14 PM · Differential
epriestley closed D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Tue, Feb 19, 11:14 PM
epriestley committed rPd4b96bcf6b01: Remove hidden zero-width spaces affecting copy behavior (authored by epriestley).
Remove hidden zero-width spaces affecting copy behavior
Tue, Feb 19, 11:10 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rPd4b96bcf6b01: Remove hidden zero-width spaces affecting copy behavior.
Tue, Feb 19, 11:10 PM · Differential
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rPd4b96bcf6b01: Remove hidden zero-width spaces affecting copy behavior.
Tue, Feb 19, 11:10 PM · Differential, Plans
epriestley closed D20189: Remove hidden zero-width spaces affecting copy behavior.
Tue, Feb 19, 11:10 PM
epriestley committed rP98fe8fae4a90: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers (authored by epriestley).
Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Tue, Feb 19, 11:07 PM
epriestley added a commit to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: rP98fe8fae4a90: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Tue, Feb 19, 11:07 PM · Differential
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP98fe8fae4a90: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Tue, Feb 19, 11:07 PM · Differential, Plans
epriestley closed D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Tue, Feb 19, 11:07 PM
epriestley requested review of D20195: Tweak some display behaviors for indent indicators.
Tue, Feb 19, 11:02 PM
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20195: Tweak some display behaviors for indent indicators.
Tue, Feb 19, 11:00 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.
  • The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
  • The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
Tue, Feb 19, 10:42 PM · Differential, Plans
amckinley awarded D20191: Behold! Copy text from either side of a diff! a Mountain of Wealth token.
Tue, Feb 19, 10:09 PM
epriestley committed rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display (authored by epriestley).
Put some whitespace behaviors back, but only for "diff alignment", not display
Tue, Feb 19, 9:12 PM
epriestley closed T6791: Side-by-side diff for source code is noisier than other tools as Resolved by committing rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display.
Tue, Feb 19, 9:12 PM · Diffusion, Differential
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display.
Tue, Feb 19, 9:12 PM · Differential, Plans
epriestley closed D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Tue, Feb 19, 9:11 PM
epriestley added a comment to D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.

...since some of the pixel alignment isn't quite right

Tue, Feb 19, 9:09 PM
epriestley closed T3498: Allow ignore whitespace in Audit/Diffusion diffs as Resolved by committing rP5310f1cdd90e: Remove all whitespace options/configuration everywhere.
Tue, Feb 19, 9:09 PM · Diffusion
epriestley committed rP5310f1cdd90e: Remove all whitespace options/configuration everywhere (authored by epriestley).
Remove all whitespace options/configuration everywhere
Tue, Feb 19, 9:09 PM
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP5310f1cdd90e: Remove all whitespace options/configuration everywhere.
Tue, Feb 19, 9:09 PM · Differential, Plans
epriestley closed D20185: Remove all whitespace options/configuration everywhere.
Tue, Feb 19, 9:09 PM
epriestley committed rP661c758ff9d1: Render indent depth changes more clearly (authored by epriestley).
Render indent depth changes more clearly
Tue, Feb 19, 8:40 PM
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rP661c758ff9d1: Render indent depth changes more clearly.
Tue, Feb 19, 8:40 PM · Differential, Plans
epriestley closed D20181: Render indent depth changes more clearly.
Tue, Feb 19, 8:40 PM
epriestley added inline comments to D20185: Remove all whitespace options/configuration everywhere.
Tue, Feb 19, 8:38 PM
epriestley updated the diff for D20181: Render indent depth changes more clearly.
  • Fix a bug with the copied code column; could cause concerns with ">>" alignment.
Tue, Feb 19, 8:36 PM
epriestley committed rARC9581dd0f5272: Add Arcanist support for highlighting indent change intraline diffs (authored by epriestley).
Add Arcanist support for highlighting indent change intraline diffs
Tue, Feb 19, 8:17 PM
epriestley added a commit to T13161: Plans: Improve Differential diff display behaviors: rARC9581dd0f5272: Add Arcanist support for highlighting indent change intraline diffs.
Tue, Feb 19, 8:17 PM · Differential, Plans
epriestley closed D20182: Add Arcanist support for highlighting indent change intraline diffs.
Tue, Feb 19, 8:17 PM
jcox awarded rPdeea2f01f5d2: Allow unit tests to have arbitrarily long names (>255 characters) a Cup of Joe token.
Tue, Feb 19, 7:55 PM
epriestley added a comment to T13158: View query results as annotatable "spreadsheets".

Tue, Feb 19, 7:34 PM · Design
epriestley committed rPdeea2f01f5d2: Allow unit tests to have arbitrarily long names (>255 characters) (authored by epriestley).
Allow unit tests to have arbitrarily long names (>255 characters)
Tue, Feb 19, 7:22 PM
epriestley added a commit to T13088: Plans: Harbormaster UI usability and interconnectedness: rPdeea2f01f5d2: Allow unit tests to have arbitrarily long names (>255 characters).
Tue, Feb 19, 7:21 PM · Plans, Harbormaster
epriestley closed D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Tue, Feb 19, 7:21 PM
epriestley added inline comments to D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Tue, Feb 19, 7:21 PM