Maniphest T12634

Keyboard focus reticle is generally oblivious to the world around it
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Apr 24 2017, 10:26 AM

Tags

Referenced Files

None

Subscribers

Description

Container for a set of closely related tasks which boil down to "the keyboard reticle isn't aware of other UI interactions".

Revisions and Commits

rP Phabricator
	D17905	rPa154407efb32 Retain keyboard cursor state across more inline edit operations in Differential
	D17904	rP1493f08272dc Emit resize events after making document changes during inline editing
	D17903	rP665ff4fdf6e7 Redraw the Differential keyboard reticle after collapsing/un-collapsing an…
	D17902	rP3c0da8161967 When the Differential filetree is toggled, resize the keyboard reticle properly
	D17901	rP7d6133929a66 Resize the Differential keyboard focus reticle when the window is resized
	D17900	rP5d7202526f3d Hide the Differential keyboard focus reticle after Quicksand navigation
	D17899	rP06c933781e97 Move keyboard focus reticle code to Differential

Related Objects
Search...

		Status	Assigned	Task
		Resolved	epriestley	T12634 Keyboard focus reticle is generally oblivious to the world around it
		Resolved	None	T12633 Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle
		Resolved	None	T12632 Resizing a diff does not resize the keyboard focus reticle
		Resolved	None	T9270 Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset
		Resolved	None	T10049 Differential highlight reticle persists after focusing an inline comment, then hiding it
		Resolved	None	T11648 Jumping to an reply inline comment via URL anchor should highlight the comment node accurately

Event Timeline

epriestley created this task.Apr 24 2017, 10:26 AM

Herald added a subscriber: eadler. · View Herald TranscriptApr 24 2017, 10:26 AM

epriestley added subtasks: T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, T12632: Resizing a diff does not resize the keyboard focus reticle, T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.Apr 24 2017, 10:27 AM

epriestley added a subtask: T8047: Differential inline reticle can persist across Quicksand navigations.Apr 24 2017, 10:29 AM

epriestley removed a subtask: T8047: Differential inline reticle can persist across Quicksand navigations.

epriestley added a revision: D17899: Move keyboard focus reticle code to Differential.May 16 2017, 1:39 PM

epriestley added a revision: D17900: Hide the Differential keyboard focus reticle after Quicksand navigation.May 16 2017, 1:47 PM

epriestley added a revision: D17901: Resize the Differential keyboard focus reticle when the window is resized.May 16 2017, 1:54 PM

epriestley added a revision: D17902: When the Differential filetree is toggled, resize the keyboard reticle properly.May 16 2017, 2:01 PM

epriestley added a revision: D17903: Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline.May 16 2017, 2:05 PM

epriestley added a revision: D17904: Emit resize events after making document changes during inline editing.May 16 2017, 2:13 PM

epriestley added a revision: D17905: Retain keyboard cursor state across more inline edit operations in Differential.May 16 2017, 2:31 PM

epriestley added a commit: rP06c933781e97: Move keyboard focus reticle code to Differential.May 16 2017, 3:20 PM

epriestley added a commit: rP5d7202526f3d: Hide the Differential keyboard focus reticle after Quicksand navigation.

epriestley added a commit: rP7d6133929a66: Resize the Differential keyboard focus reticle when the window is resized.

epriestley closed subtask T12632: Resizing a diff does not resize the keyboard focus reticle as Resolved.

epriestley added a commit: rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly.

epriestley added a commit: rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an….

epriestley closed subtask T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it as Resolved.

epriestley added a commit: rP1493f08272dc: Emit resize events after making document changes during inline editing.

epriestley closed subtask T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle as Resolved.

epriestley added a commit: rPa154407efb32: Retain keyboard cursor state across more inline edit operations in Differential.May 16 2017, 3:23 PM

I think the keyboard reticle now generally has reasonable behavior.

T9270 has outstanding work, but it's about the hover/edit reticle.

T11648 has outstanding work, but it's partly about the anchor reticle and partly about new behavior.

epriestley closed subtask T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Resolved.May 16 2017, 6:09 PM

epriestley closed subtask T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset as Resolved.May 17 2017, 12:37 AM