Page MenuHomePhabricator
Create Task
Maniphest T12634

Keyboard focus reticle is generally oblivious to the world around it
Closed, ResolvedPublic
Actions

Description

Container for a set of closely related tasks which boil down to "the keyboard reticle isn't aware of other UI interactions".

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

Event Timeline

epriestley created this task.Apr 24 2017, 10:26 AM
Herald added a subscriber: eadler. · View Herald TranscriptApr 24 2017, 10:26 AM
epriestley added subtasks: T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, T12632: Resizing a diff does not resize the keyboard focus reticle, T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.Apr 24 2017, 10:27 AM
epriestley added a subtask: T8047: Differential inline reticle can persist across Quicksand navigations.Apr 24 2017, 10:29 AM
epriestley removed a subtask: T8047: Differential inline reticle can persist across Quicksand navigations.
epriestley added a revision: Restricted Differential Revision.May 16 2017, 1:39 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 1:47 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 1:54 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 2:01 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 2:05 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 2:13 PM
epriestley added a revision: Restricted Differential Revision.May 16 2017, 2:31 PM
epriestley added a commit: Restricted Diffusion Commit.May 16 2017, 3:20 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T12632: Resizing a diff does not resize the keyboard focus reticle as Resolved.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it as Resolved.
epriestley added a commit: Restricted Diffusion Commit.
epriestley closed subtask T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle as Resolved.
epriestley added a commit: Restricted Diffusion Commit.May 16 2017, 3:23 PM
epriestley closed this task as Resolved.May 16 2017, 4:45 PM
epriestley claimed this task.

I think the keyboard reticle now generally has reasonable behavior.

T9270 has outstanding work, but it's about the hover/edit reticle.

T11648 has outstanding work, but it's partly about the anchor reticle and partly about new behavior.

epriestley closed subtask T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Resolved.May 16 2017, 6:09 PM
epriestley closed subtask T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset as Resolved.May 17 2017, 12:37 AM
Phabricator · Built by Phacility