Page MenuHomePhabricator
Create Task
Maniphest T8047

Differential inline reticle can persist across Quicksand navigations
Closed, ResolvedPublic
Actions

Description

I think this is related to quicksand, was browsing around and this odd div popped up:

pasted_file (782×1 px, 576 KB)

when inspected via devtools I see:

<div class="differential-reticle" style="left: 606px; top: 1446px; width: 513px; height: 17px;"></div>
<div class="differential-reticle" style="left: 606px; top: 1446px; width: 513px; height: 17px;"></div>

inside the <div id="phabricator-standard-page" class="phabricator-standard-page" data-autoid="autoid_1">

Revisions and Commits

rP Phabricator
D17919rP0ca49fbeb951 Move "hover over an inline to see the affected lines" code to the new class tree
D17900rP5d7202526f3d Hide the Differential keyboard focus reticle after Quicksand navigation
D17840rP404fe482d914 Add a Quicksand-aware page-level container to diffs

Related Objects

Event Timeline

Mnkras created this task.May 3 2015, 11:28 PM
Mnkras raised the priority of this task from to Needs Triage.
Mnkras updated the task description. (Show Details)
Mnkras added a project: Quicksand.
Mnkras added a subscriber: Mnkras.
epriestley renamed this task from Odd Div on page to Differential inline reticle can persist across Quicksand navigations.May 4 2015, 1:31 PM
epriestley triaged this task as Normal priority.May 7 2015, 1:50 PM
epriestley merged a task: T8244: Multiple Differential Reticles hide content.May 18 2015, 6:03 PM
epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
epriestley added a project: Inline Comments.Apr 24 2017, 10:29 AM
epriestley added a parent task: T12634: Keyboard focus reticle is generally oblivious to the world around it.
epriestley added a subscriber: epriestley.

Oh, this actually is the inline reticle, not the keyboard reticle.

epriestley removed a parent task: T12634: Keyboard focus reticle is generally oblivious to the world around it.Apr 24 2017, 10:30 AM

The keyboard reticle probably has the same issue but we can figure that out later.

epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 24 2017, 10:30 AM
epriestley added a revision: D17840: Add a Quicksand-aware page-level container to diffs.May 8 2017, 4:01 PM
epriestley added a commit: rP404fe482d914: Add a Quicksand-aware page-level container to diffs.May 16 2017, 1:16 PM
epriestley moved this task from Glitches to Reticle on the Inline Comments board.May 16 2017, 1:28 PM
epriestley added a revision: D17900: Hide the Differential keyboard focus reticle after Quicksand navigation.May 16 2017, 1:47 PM
epriestley added a commit: rP5d7202526f3d: Hide the Differential keyboard focus reticle after Quicksand navigation.May 16 2017, 3:21 PM
epriestley added a comment.May 16 2017, 4:46 PM

The keyboard reticle has been fixed but the inline reticle is still at large.

epriestley added a revision: D17919: Move "hover over an inline to see the affected lines" code to the new class tree.May 16 2017, 11:06 PM
epriestley added a comment.May 16 2017, 11:09 PM

I marked D17919 as fixing this. I can't reproduce it after that change (except: the drag-select behavior isn't converted yet) and we're now Quicksand-aware, although it's possible I'm just not doing the right sequence of operations.

epriestley closed this task as Resolved by committing rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree.May 17 2017, 12:37 AM
epriestley added a commit: rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree.
Phabricator · Built by Phacility