Page MenuHomePhabricator
Feed Advanced Search

Dec 12 2015

epriestley edited the content of Changelog.
Dec 12 2015, 2:08 AM
epriestley created 2015 Week 50 (Early December).
Dec 12 2015, 2:07 AM
epriestley renamed Blog Post: Development Notes (2015 Week 50) blog post from to Development Notes (2015 Week 50).
Dec 12 2015, 1:52 AM
epriestley added a comment to T9927: Improve PhameHome.

New blogs element is great :3

Dec 12 2015, 1:51 AM · Phame
epriestley awarded T9927: Improve PhameHome a Mountain of Wealth token.
Dec 12 2015, 1:50 AM · Phame
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Oh, there are only two options and neither would break this.

Dec 12 2015, 1:45 AM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Is Settings → Diff Preferences → Show Unified Diffs set to "On Small Screens" (the default) for you?

Dec 12 2015, 1:44 AM · Safari, Differential, Bug Report
epriestley closed T9968: Phame can fatal if handed an older-style URI as Resolved.

D14747 should fix this. I haven't pushed that yet, but I updated all the changelogs.

Dec 12 2015, 1:36 AM · Phame, Bug Report
epriestley renamed T9968: Phame can fatal if handed an older-style URI from Phame Fatal to Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:36 AM · Phame, Bug Report
epriestley edited the content of 2015 Week 49 (Very Early December).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 48 (Very Late November).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 47 (Late November).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 45 (Early November).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 44 (Very Late October).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 43 (Late October).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 42 (Mid October).
Dec 12 2015, 1:30 AM
epriestley edited the content of 2015 Week 41 (Early October).
Dec 12 2015, 1:30 AM
epriestley added a revision to T9968: Phame can fatal if handed an older-style URI: Unknown Object (Differential Revision).
Dec 12 2015, 1:28 AM · Phame, Bug Report
epriestley added a comment to T9968: Phame can fatal if handed an older-style URI.

The URI scheme changed but this shouldn't fatal. I'll fix the fatal and then go fix the links in the changelogs, there are only like 6 of them or something.

Dec 12 2015, 1:23 AM · Phame, Bug Report
epriestley claimed T9968: Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:22 AM · Phame, Bug Report
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 12 2015, 1:03 AM · ApplicationEditor
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

I think this should now be fixed in HEAD. Let us know if we missed anything, and thanks for the report.

Dec 12 2015, 1:00 AM · Security, Bug Report
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

Dec 12 2015, 12:54 AM · ApplicationEditor
epriestley closed T9966: Diffusion credentials may be leaked under some circumstances as Resolved by committing Restricted Diffusion Commit.
Dec 12 2015, 12:53 AM · Security, Bug Report
epriestley added a revision to T9966: Diffusion credentials may be leaked under some circumstances: Unknown Object (Differential Revision).
Dec 12 2015, 12:52 AM · Security, Bug Report
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

So you haven't actually reproduced this yourself? Is it possible that the user mistook xxxxx as uncensored credentials? Can you try reproducing it directly?

Dec 12 2015, 12:12 AM · Security, Bug Report
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

I should note that we're running the latest version of Git (2.6.3) which could be the culprit. From my superficial inspection of the code, it appears that the output of git fetch is simply reflected.

Dec 12 2015, 12:11 AM · Security, Bug Report
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

In your report, you say <user email address> -- is the login username for this user a string including "@"? Does the UI print out a message like this?

Dec 12 2015, 12:06 AM · Security, Bug Report
epriestley added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Until we have such a tool, you can revoke keys like this:

Dec 12 2015, 12:01 AM · Auth, Feature Request

Dec 11 2015

epriestley triaged T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff as Wishlist priority.

I think this is worth improving. However, I think it is not a very important feature in situations where things are set up reasonably well (not too many lint false positives, fairly fast tests or server-side CI), and that fixing these problems will have a lot of other benefits in cases where they aren't working well. That is, this should be more like a "nice-to-have" that saves you a few seconds once a week, not something you're hitting on >50% of revisions.

Dec 11 2015, 11:53 PM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9336: Link profile image in feed.

Can I set looks an intern on this?

Dec 11 2015, 11:41 PM · Badge Awarded, PHUI
epriestley added a comment to T9336: Link profile image in feed.

Although timeline is now linked, I think feed still isn't linked?

Dec 11 2015, 11:35 PM · Badge Awarded, PHUI
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

What version of Phabricator are you running? (You can find this in Config → Versions for recent versions.)

Dec 11 2015, 11:33 PM · Security, Bug Report
epriestley added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Do you have the public key (or the private key), or do you just know which user has a compromised key but not know which key is compromised?

Dec 11 2015, 11:29 PM · Auth, Feature Request
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

I can't reproduce that. Here's a search using "Path", which seems to work correctly:

Dec 11 2015, 11:25 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley closed T9965: Don't require newline for Differential Revision autoclose magic as Invalid.

This request does not describe a root problem.

Dec 11 2015, 8:24 PM · Feature Request
epriestley added projects to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Conduit, Arcanist, Owners, Phame, Maniphest.
Dec 11 2015, 7:49 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Dec 11 2015, 7:39 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 11 2015, 7:39 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley created T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
Dec 11 2015, 7:35 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley closed T9963: Bug report link 404's as Resolved by committing Restricted Diffusion Commit.
Dec 11 2015, 6:28 PM · Documentation, Phurl, Bug Report
epriestley added a revision to T9963: Bug report link 404's: Unknown Object (Differential Revision).
Dec 11 2015, 6:27 PM · Documentation, Phurl, Bug Report
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 11 2015, 4:30 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

I eventually got this live. blog.phacility.com is a little plain now, but seems to work fine:

Dec 11 2015, 4:26 PM · Phame
epriestley closed T9960: teste as Spite.
Dec 11 2015, 4:13 PM
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 11 2015, 3:19 PM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 11 2015, 2:53 PM · Phame
epriestley added a subtask for T9897: Unbeta Feedback on Phame: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Dec 11 2015, 2:52 PM · Phame
epriestley added a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Dec 11 2015, 2:52 PM · Haskell.org, Remarkup, Phame
epriestley added a comment to T7108: high server load due to continuous hg calls.

@andrew-dixon Sorry, there's no secret internal tracker full of juicy updates that we're hiding from the public. If we haven't updated a task, there aren't any updates on it. See Planning for a little more discussion on this in general.

Dec 11 2015, 2:45 PM · Mercurial
epriestley closed T9285: Custom locale may fail when pht a sentence with variants as Resolved.
  • Send rules upstream for now (like with the Korean rules).
  • We'll probably make this modular eventually.
Dec 11 2015, 1:02 PM · Localization
epriestley closed T9306: Improve Phacility trial period behavior as Resolved.

This has been in production for a while and seems to be working correctly. New rules are:

Dec 11 2015, 1:00 PM · Phacility
epriestley closed T9306: Improve Phacility trial period behavior, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Dec 11 2015, 1:00 PM · Phacility
epriestley closed T9367: Add another accept state for code review as Wontfix.

Closing this out since there's nothing actionable here.

Dec 11 2015, 12:56 PM · Differential, Restricted Project
epriestley closed T9546: Phame "Oblivious" skin a few rough edges as Wontfix.

I'm planning to just remove skin support in T9897.

Dec 11 2015, 12:54 PM · Phame
epriestley closed T9605: Running prod daemons fails on test files as Resolved.

Assuming this is in good shape now.

Dec 11 2015, 12:53 PM · Daemons, Restricted Project
epriestley updated subscribers of T5158: Maniphest custom field refuses to use non-empty default value.
Dec 11 2015, 12:50 PM · Maniphest, Custom Fields, Transactions
epriestley merged task T9667: Be able to set default user(s) for a custom "users" field into T5158: Maniphest custom field refuses to use non-empty default value.
Dec 11 2015, 12:50 PM · Custom Fields
epriestley closed T9682: Phriction emails are not formatted as Resolved.

I believe this was fixed by D14511.

Dec 11 2015, 12:47 PM · Phriction
epriestley closed T9647: Ponder feed stories don't get marked up as Resolved.

This was fixed in connection with T9825.

Dec 11 2015, 12:45 PM · Ponder
epriestley closed T9678: "Argument 1 passed to AphrontView::setUser() must be an instance of PhabricatorUser, null given" on cloning a repository as Invalid.

I can't reproduce this. Here's what I did:

Dec 11 2015, 12:43 PM · Diffusion
epriestley renamed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel from Support Editing Queries to Make it easier to update the query a Dashboard panel uses.
Dec 11 2015, 12:39 PM · Dashboards
mememori awarded T7858: Typeahead/Tokenizer Errata a Like token.
Dec 11 2015, 3:30 AM · Restricted Project, Typeahead
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

Briefly, T9529 discusses some server-side system running on revisions that's live in your environment, presumably. Its current behavior is something like this:

Dec 11 2015, 2:43 AM · Restricted Project, Herald
epriestley added a comment to T9940: Revision Project Reviewers state not updated after reviewer added to project.

T8378 discusses a milder case of this sort of thing but I think the logic here applies to it as well.

Dec 11 2015, 2:36 AM · Bug Report
epriestley updated subscribers of T9940: Revision Project Reviewers state not updated after reviewer added to project.
Dec 11 2015, 2:33 AM · Bug Report
epriestley merged task T8378: when adding a project that a member already reviewed, the project is not considered to have reviewed it into T9940: Revision Project Reviewers state not updated after reviewer added to project.
Dec 11 2015, 2:33 AM · Differential
epriestley moved T8403: arc patch leaves empty branch behind on failure from Backlog to arc patch on the Arcanist board.
Dec 11 2015, 2:30 AM · Restricted Project, Arcanist, Restricted Project
epriestley closed T7617: Make it easier to know why herald adds reviewers as Wontfix.

I think T8405 and this are both basically discussing the same use case, which I understand to be:

Dec 11 2015, 2:27 AM · Restricted Project, Herald
epriestley updated subscribers of T7617: Make it easier to know why herald adds reviewers.
Dec 11 2015, 1:55 AM · Restricted Project, Herald
epriestley merged task T8405: Making lint easier to use into T7617: Make it easier to know why herald adds reviewers.
Dec 11 2015, 1:55 AM · Lint, Restricted Project
epriestley closed T8396: projects autofill text box as Wontfix.

I think this behavior is reasonable as-is.

Dec 11 2015, 1:51 AM · Typeahead
epriestley closed T8431: show last changed information early on in the diff view as Invalid.

See Contributing Feature Requests. If you're aren't sure what we mean by a "root problem", see Describing Root Problems.

Dec 11 2015, 1:49 AM · Differential
epriestley closed T8452: Cannot read property 'textContent' of null as Invalid.

No idea how to reproduce, no other reports.

Dec 11 2015, 1:47 AM · Differential
epriestley closed T9943: why won't phabricator make me a sandwich? as Wontfix.
Dec 11 2015, 1:42 AM · Public & Media Relations, Feature Request
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 11 2015, 1:38 AM · Restricted Project, Typeahead
epriestley added a revision to T7858: Typeahead/Tokenizer Errata: Unknown Object (Differential Revision).
Dec 11 2015, 1:37 AM · Restricted Project, Typeahead

Dec 10 2015

epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:47 PM · Restricted Project, Typeahead
epriestley merged task T9761: tokenizer search button ignores limit into T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:45 PM · Javelin
epriestley merged T9761: tokenizer search button ignores limit into T7858: Typeahead/Tokenizer Errata.
Dec 10 2015, 11:45 PM · Restricted Project, Typeahead
epriestley closed T9952: Let "Land Revision" target branches other than master as Resolved.

This behavior should be more reasonable at HEAD. In particular:

Dec 10 2015, 11:38 PM · Differential
epriestley closed T9952: Let "Land Revision" target branches other than master, a subtask of T182: Commit into repository directly from differential, as Resolved.
Dec 10 2015, 11:38 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T3462: In Differential, expose "featurename (branched from master)" via Conduit.

After D14737, we will now show this information in the UI if it's available. Here are the requirements:

Dec 10 2015, 11:15 PM · Differential, Arcanist
epriestley added a revision to T3462: In Differential, expose "featurename (branched from master)" via Conduit: Unknown Object (Differential Revision).
Dec 10 2015, 11:06 PM · Differential, Arcanist
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Restricted Differential Revision.
Dec 10 2015, 11:06 PM · Differential
epriestley added a revision to T3462: In Differential, expose "featurename (branched from master)" via Conduit: Unknown Object (Differential Revision).
Dec 10 2015, 10:45 PM · Differential, Arcanist
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Unknown Object (Differential Revision).
Dec 10 2015, 10:45 PM · Differential
epriestley added a comment to T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6.

This should be fixed at HEAD. Let us know if we missed anything or if you run into anything else. Thanks for the report!

Dec 10 2015, 10:20 PM · Arcanist, Bug Report
epriestley closed T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6 as Resolved by committing Restricted Diffusion Commit.
Dec 10 2015, 10:19 PM · Arcanist, Bug Report
epriestley raised the priority of T7345: Install PHPExcel in the cluster from Low to Normal.

Someone actually wants this, so I'll configure it during the deploy on Saturday.

Dec 10 2015, 10:18 PM · Phacility
epriestley added a revision to T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6: Unknown Object (Differential Revision).
Dec 10 2015, 10:15 PM · Arcanist, Bug Report
epriestley claimed T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6.

Thanks for checking, that's quite helpful.

Dec 10 2015, 10:07 PM · Arcanist, Bug Report
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Unknown Object (Differential Revision).
Dec 10 2015, 10:07 PM · Differential
epriestley added a comment to T9954: Cannot change a fulfiled promise to rejected.

Ah. Yes, I agree.

Dec 10 2015, 9:54 PM · libphutil
epriestley added a comment to T9954: Cannot change a fulfiled promise to rejected.

I don't think that string is one of ours. Does it appear in flarc?

Dec 10 2015, 9:53 PM · libphutil
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Unknown Object (Differential Revision).
Dec 10 2015, 9:50 PM · Differential
epriestley added a comment to T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6.
  • -c seems to come from 1.7.2.
  • --no-color and --color=never are probably two acceptable alternative methods for writing -c color.ui=never.
  • --no-column seems to be an acceptable alternative for writing -c column.ui=never, but may not have existed until 1.7.11.
Dec 10 2015, 9:47 PM · Arcanist, Bug Report
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Unknown Object (Differential Revision).
Dec 10 2015, 9:19 PM · Differential
avivey awarded T9952: Let "Land Revision" target branches other than master a Yellow Medal token.
Dec 10 2015, 9:08 PM · Differential
epriestley added a revision to T9952: Let "Land Revision" target branches other than master: Restricted Differential Revision.
Dec 10 2015, 9:08 PM · Differential