Page MenuHomePhabricator

Custom locale may fail when pht a sentence with variants
Closed, ResolvedPublic

Description

As PhutilTranslator::chooseVariant accepts locale codes en_US, en_GB, en_W*, en_R*, en_A* and cs_CZ only.

Revisions and Commits

Event Timeline

kfll updated the task description. (Show Details)
kfll added a subscriber: kfll.

I expect to move this stuff into Locale subclasses eventually, but it's potentially performance-sensitive so I want to be careful when doing so.

If you're trying to translate into another human language (like French or Spanish or Italian), I'll accept new PhutilLocale subclasses into libphutil (with corresponding rules in PhutilTranslator) if you want to send a diff.

If you're trying to translate into a specialized English, you'll have to patch locally or wait for the rules to move into Locale classes.

If you're trying to translate into another human language (like French or Spanish or Italian), I'll accept new PhutilLocale subclasses into libphutil (with corresponding rules in PhutilTranslator) if you want to send a diff.

I'm trying to translate to Korean, and I'm willing to send a diff. Can you point me which file I need to edit?

epriestley claimed this task.
  • Send rules upstream for now (like with the Korean rules).
  • We'll probably make this modular eventually.