Page MenuHomePhabricator
Create Task
Maniphest T9953

arc fails with `git:branch-unique(*)` base commit rule on CentOS 6
Closed, ResolvedPublic
Actions

Description

It appears that use of the git:branch-unique(*) base commit rule causes a number of arc commands to fail on CentOS/RHEL 6, due to its version of Git (1.7.1) not supporting the -c argument.

For example,
$ arc which --base 'git:branch-unique(origin/master)' --trace shows that arc tries to execute:

git -c column.ui=never -c color.ui=never branch --contains 'b500ca6e1b1943ff88798b18e75d51ee39f65b0b'

Executing this git command manually:

Unknown option: -c
usage: git [--version] [--exec-path[=GIT_EXEC_PATH]] [--html-path]
           [-p|--paginate|--no-pager] [--no-replace-objects]
           [--bare] [--git-dir=GIT_DIR] [--work-tree=GIT_WORK_TREE]
           [--help] COMMAND [ARGS]

Appears to have been introduced by rARC4600914

Revisions and Commits

rARC Arcanist
D14735rARCd0e73bb65610 Don't use "-c" flag in "git:branch-unique()" revision range rule

Related Objects

Event Timeline

nickhutchinson created this task.Dec 10 2015, 9:28 PM
nickhutchinson raised the priority of this task from to Needs Triage.
nickhutchinson updated the task description. (Show Details)
nickhutchinson changed the edit policy from "All Users" to "Custom Policy".
nickhutchinson added a project: Bug Report.
nickhutchinson added a subscriber: nickhutchinson.
nickhutchinson updated the task description. (Show Details)Dec 10 2015, 9:32 PM
nickhutchinson renamed this task from arc's `git:branch-unique(*)` workflow causes on CentOS 6 to arc fails with `git:branch-unique(*)` base commit rule on CentOS 6.Dec 10 2015, 9:36 PM
nickhutchinson updated the task description. (Show Details)
epriestley added a subscriber: epriestley.Dec 10 2015, 9:47 PM
  • -c seems to come from 1.7.2.
  • --no-color and --color=never are probably two acceptable alternative methods for writing -c color.ui=never.
  • --no-column seems to be an acceptable alternative for writing -c column.ui=never, but may not have existed until 1.7.11.

That potentially gives us this:

  • Up to (but excluding) 1.7.11, pass --no-color.
  • On 1.7.11 and newer, pass --no-color --no-column.

Does --no-color exist in your version of Git? (I expect it does.)
Does --no-column exist in your version of Git? (I expect it does not.)

See also T9898.

chad added a project: Arcanist.Dec 10 2015, 9:50 PM
chad added a subscriber: chad.
nickhutchinson added a comment.EditedDec 10 2015, 9:56 PM

git branch --no-color and git branch --color=never both work, but Git 1.7.1 does not like git branch --no-column.

epriestley claimed this task.Dec 10 2015, 10:07 PM
epriestley triaged this task as Normal priority.

Thanks for checking, that's quite helpful.

epriestley added a revision: D14735: Don't use "-c" flag in "git:branch-unique()" revision range rule.Dec 10 2015, 10:15 PM
epriestley closed this task as Resolved by committing rARCd0e73bb65610: Don't use "-c" flag in "git:branch-unique()" revision range rule.Dec 10 2015, 10:19 PM
epriestley added a commit: rARCd0e73bb65610: Don't use "-c" flag in "git:branch-unique()" revision range rule.
epriestley added a comment.Dec 10 2015, 10:20 PM

This should be fixed at HEAD. Let us know if we missed anything or if you run into anything else. Thanks for the report!

epriestley mentioned this in T5554: arc fails with svn/git/hg non english locales.Dec 12 2015, 1:46 PM
Phabricator · Built by Phacility