Page MenuHomePhabricator
Create Task
Maniphest T9968

Phame can fatal if handed an older-style URI
Closed, ResolvedPublic
Actions

Description

I visited this link https://secure.phabricator.com/phame/live/111/post/development_notes_2015_week_49/

and got the follow error

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getName() on a non-object

/core/lib/phabricator/src/applications/phame/controller/PhameLiveController.php:180


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

I found this link in this page: https://secure.phabricator.com/w/changelog/2015.49/

Revisions and Commits

rP Phabricator
D14747rPdbdd70270230 404 older-style Phame URIs properly

Related Objects

Event Timeline

starruler created this task.Dec 12 2015, 1:10 AM
starruler raised the priority of this task from to Needs Triage.
starruler updated the task description. (Show Details)
starruler changed the edit policy from "All Users" to "Custom Policy".
starruler added a project: Bug Report.
starruler added a subscriber: starruler.

Looks like the URL scheme migh thave just changed? I was able to get to the post by navigating to phame home: https://secure.phabricator.com/w/changelog/2015.49/

chad added subscribers: epriestley, chad.Dec 12 2015, 1:17 AM
epriestley claimed this task.Dec 12 2015, 1:22 AM

The URI scheme changed but this shouldn't fatal. I'll fix the fatal and then go fix the links in the changelogs, there are only like 6 of them or something.

epriestley added a revision: D14747: 404 older-style Phame URIs properly.Dec 12 2015, 1:28 AM
epriestley added a commit: rPdbdd70270230: 404 older-style Phame URIs properly.Dec 12 2015, 1:32 AM
epriestley renamed this task from Phame Fatal to Phame can fatal if handed an older-style URI.Dec 12 2015, 1:36 AM
epriestley closed this task as Resolved.

D14747 should fix this. I haven't pushed that yet, but I updated all the changelogs.

joshuaspence added a project: Phame.Dec 12 2015, 2:26 AM
Phabricator · Built by Phacility