Page MenuHomePhabricator

Don't require newline for Differential Revision autoclose magic
Closed, DuplicatePublic

Description

Would it be possible to use the same (or similar) syntax for autoclosing differential revisions as autoclosing tasks? My main issue is not so much the verbosity of "Differential Revision", rather that it must be on a line by itself. I'd like to be able to just write "Closes D1" or "Merge D1" anywhere in the commit message to get the linkage and autoclose functionality.

Event Timeline

nochum created this task.Dec 11 2015, 8:03 PM
nochum raised the priority of this task from to Needs Triage.
nochum updated the task description. (Show Details)
nochum changed the edit policy from "All Users" to "Custom Policy".
nochum added a project: Feature Request.
nochum added a subscriber: nochum.
epriestley closed this task as Invalid.Dec 11 2015, 8:24 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

This request does not describe a root problem.

Please see Contributing Feature Requests for guidance on what we're looking for in a feature request. If you aren't sure what we mean by a "root problem", see Describing Root Problems.

The reason we'd rather have it on the same line is because most hg clients (including Phabricator's Diffusion, but more importantly our local TortoiseHg clients) only show the first line of any commit in the pushlog. For us to get to the revision number would require an extra action. We generally try to keep our commit messages to one line for this reason. Additionally this was something that was difficult for us to figure out as it is inconsistent with the rest of the linking functionality explained in T5132.

nochum added a comment.Jan 6 2016, 9:17 PM

@epriestley Can you reconsider this request now?

Sorry, I still don't understand your root problem.

If you want the revision in the first line, why not just put it there? This message will parse fine:

[D123] Only this line is visible

Differential Revision: https://phabricator.yourinstall.com/D123

Phabricator will ignore the reference to the revision in the subject line, but you can read it with TortiseHG.

There is no "Closes D1" or "Merge D1" syntax, so this isn't inconsistent with T5132.

nochum added a comment.Mar 8 2016, 7:57 PM

Btw, we just ran into an issue where the Differential Revision wasn't parsed because the newline was just a LF, phabricator seems to require CRLF. So the git log shows it on its own line with the correct syntax but the description in the differential itself shows it all on one line. Another oddity...

@epriestley Any idea why the issue in my previous comment would be happening? Thanks.