Page MenuHomePhabricator

arc patch leaves empty branch behind on failure
Open, Needs TriagePublic


When I run arc patch I sometimes get an error with a question, to which I usually answer 'no'. Example:

$ arc patch D98155
Created and checked out branch arcpatch-D98155.

    This diff is against commit ebe436220476a97f83a9e92d6a5f18f56078dfb5, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (0a6d5dbdd88cdda8acf77004a6fd266396e16c8d)
    [Y/n] n

Usage Exception: User aborted the workflow.

In such cases arc leaves behind a useless branch. Shouldn't it remove that branch (given that it always creates a new branch anyway) or perhaps check for such error conditions earlier in its flow?

Related Objects

Event Timeline

angie raised the priority of this task from to Needs Triage.
angie updated the task description. (Show Details)
angie added a project: Restricted Project.
angie added subscribers: angie, gvanrossum, jhurwitz.
eadler added a project: Restricted Project.Dec 22 2016, 5:53 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.