Page MenuHomePhabricator
Create Task
Maniphest T8726

Modularize Herald fields and actions
Closed, ResolvedPublic
Actions

Description

Herald conditions are currently hard-coded and should be modularized to support other infrastructure changes (custom field selects, outbound mail rules).

Revisions and Commits

rP Phabricator
AuditedrP5f76c71d781c Share target filtering code in HeraldAction
AuditedrPa3e2f655eb87 Modularize the Diffusion/Differential "Block" Herald actions
AuditedrP6f6d88794b25 Modularize the Diffusion "Add Auditors" Herald action
AuditedrP776caa507b15 Modularize the Harbormaster "Run build plan" Herald action
AuditedrPfdd379a026c3 Modularize the Legalpad "Require Signature" Herald Action
AuditedrPa335004a91a9 Modularize Differential Reviewer actions in Herald
D13706rP8d8ee18ce0fd Modularize Maniphest Herald "Assign Task" action
D13705rP37829926702b Modularize "add projects" and "remove projects" Herald actions
D13701rP51fead17cf13 Modularize "Send an Email" Herald actions
D13699rP8ae08a3de70b Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
D13649rP8d9bd791f7f2 Modularize Herald "flag" action, plus update transcripts
D13646rP56dd5211f0d0 Make Herald action modularization more aggressive
D13644rPe0861bf240cf Rename "HeraldAction" to "HeraldActionRecord"
D13619rP0306eb70edfc Group and order Herald fields
D13618rP97ccd936709c Support "Select" custom fields in Herald rules
D13616rP715233fb6115 Fully modularize Herald field values
D13614rPed3dfd491f17 Further modularize Herald values
D13613rPa9caab49f7b5 Begin modularizing Herald field values
D13612rPb2b739c709aa Reduce code duplication in Herald fields
D13601rPe8f063de25c1 Modularize Herald Diffusion pre-commit content fields
D13600rPf9134fc33199 Modularize all Herald pre-commit ref fields
D13598rP00b98eca541c Modularize all DifferentialRevision fields
D13590rPc013108675ef Modernize all Herald DifferentialDiff fields
D13567rP98ac0a022c90 Modularize all Diffusion commit Herald fields
D13514rP68de3dae9ab0 Modularize all remaining Phriction Herald fields
D13513rP415e4d4cc135 Modularize all remaining Pholio Herald fields
D13501rP83c0fda28059 Modularize all remaining Maniphest Herald fields
D13500rPc02c83108d21 Modularize Herald task status/priority fields
D13499rP9f220995b246 Modularize Application Email Herald field
D13498rPbfbc0e638ddf Remove vestigal "tags" stuff from Herald
D13497rP4c23d5cfae54 Make Herald custom field integration modular
D13495rP59c294457f71 Modularize more Herald fields
D13488rPb266412f3ee8 Begin modularizing Herald fields

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
Restricted Maniphest Task
 InvalidepriestleyT9520 Allow Workboards to show a thumbnail image within each card
 ResolvedepriestleyT4863 Allow Workboard Cards to be customized for display
 ResolvedepriestleyT10034 Plan the future of Maniphest task relationships
 OpenNoneT5353 Add visual hint to tasks that are blocked by others
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedchadT4771 Add an option to show task status in task list
 WontfixepriestleyT4782 Provide short revision status summary in Differential query results?
 ResolvedepriestleyT9287 Working with many repositories
 InvalidNoneT11466 Build status on Differential search results
 ResolvedchadT9184 Remove IRC based support
 ResolvedchadT3578 Unbeta Ponder
 ResolvedchadT6919 Add Herald support to Ponder
 OpenNoneT7004 Don't send email whilst online
 OpenNoneT9891 Verify WMF use cases are accommodated after Herald Outbound Rules resolves
 OpenNoneT5791 Write Herald rules for outbound mail
 WontfixepriestleyT3794 Rebuild Diffusion/Audit on top of CustomField infrastructure
 OpenepriestleyT418 Integrate CustomField into more interfaces
 ResolvedepriestleyT8434 Accommodate the "Security" workflow
 ResolvedNoneT5016 Allow Herald rules for Maniphest to act on custom task fields
 ResolvedepriestleyT655 Integrate CustomField into Herald
Restricted Maniphest Task
 ResolvedjoshuaspenceT5889 Allow herald rules to act on existence of auditors
 ResolvedNoneT7804 Implement an "Acting User" Herald condition
 ResolvedepriestleyT8726 Modularize Herald fields and actions
 ResolvedepriestleyT8920 'Another Herald rule matches' is being displayed as a raw PHID
 ResolvedepriestleyT9055 Weird Herald spacing
 ResolvedepriestleyT9054 Undefined class constant ACTION_BLOCK

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley claimed this task.Jun 30 2015, 4:52 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Herald.
epriestley added a parent task: T8434: Accommodate the "Security" workflow.
epriestley added a parent task: T5791: Write Herald rules for outbound mail.
epriestley added a parent task: T655: Integrate CustomField into Herald.
epriestley added a parent task: T5016: Allow Herald rules for Maniphest to act on custom task fields.
epriestley added a subscriber: epriestley.
epriestley added a parent task: T5889: Allow herald rules to act on existence of auditors.Jun 30 2015, 4:54 PM
epriestley added a parent task: T7804: Implement an "Acting User" Herald condition.
epriestley added a revision: D13488: Begin modularizing Herald fields.Jun 30 2015, 5:33 PM
joshuaspence added a subscriber: joshuaspence.Jun 30 2015, 8:53 PM
epriestley added a revision: D13495: Modularize more Herald fields.Jun 30 2015, 10:38 PM
epriestley added a revision: D13497: Make Herald custom field integration modular.Jun 30 2015, 11:00 PM
epriestley added a revision: D13498: Remove vestigal "tags" stuff from Herald.Jun 30 2015, 11:04 PM
epriestley added a revision: D13499: Modularize Application Email Herald field.Jun 30 2015, 11:28 PM
epriestley added a revision: D13500: Modularize Herald task status/priority fields.Jul 1 2015, 12:06 AM
epriestley added a revision: D13501: Modularize all remaining Maniphest Herald fields.Jul 1 2015, 12:51 AM
sascha-egerer added a subscriber: sascha-egerer.Jul 1 2015, 6:15 AM
epriestley added a revision: D13513: Modularize all remaining Pholio Herald fields.Jul 1 2015, 3:05 PM
epriestley added a revision: D13514: Modularize all remaining Phriction Herald fields.Jul 1 2015, 3:31 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
epriestley added a commit: rPb266412f3ee8: Begin modularizing Herald fields.Jul 6 2015, 8:15 PM
epriestley added a commit: rP59c294457f71: Modularize more Herald fields.
epriestley added a commit: rP4c23d5cfae54: Make Herald custom field integration modular.
epriestley added a commit: rPbfbc0e638ddf: Remove vestigal "tags" stuff from Herald.
epriestley added a commit: rP9f220995b246: Modularize Application Email Herald field.
epriestley added a commit: rPc02c83108d21: Modularize Herald task status/priority fields.
epriestley added a commit: rP83c0fda28059: Modularize all remaining Maniphest Herald fields.
epriestley added a commit: rP415e4d4cc135: Modularize all remaining Pholio Herald fields.
epriestley added a commit: rP68de3dae9ab0: Modularize all remaining Phriction Herald fields.Jul 6 2015, 8:17 PM
epriestley added a revision: D13567: Modularize all Diffusion commit Herald fields.Jul 6 2015, 9:15 PM
epriestley added a commit: rP98ac0a022c90: Modularize all Diffusion commit Herald fields.Jul 7 2015, 6:53 PM
epriestley added a revision: D13590: Modernize all Herald DifferentialDiff fields.Jul 7 2015, 11:10 PM
epriestley renamed this task from Modularize Herald conditions to Modularize Herald fields.Jul 8 2015, 9:55 AM
epriestley added a revision: D13598: Modularize all DifferentialRevision fields.Jul 8 2015, 9:58 AM
epriestley added a revision: D13600: Modularize all Herald pre-commit ref fields.Jul 8 2015, 10:40 AM
epriestley added a revision: D13601: Modularize Herald Diffusion pre-commit content fields.Jul 8 2015, 11:33 AM
epriestley added a commit: rPc013108675ef: Modernize all Herald DifferentialDiff fields.Jul 8 2015, 7:25 PM
epriestley added a commit: rP00b98eca541c: Modularize all DifferentialRevision fields.
epriestley added a commit: rPf9134fc33199: Modularize all Herald pre-commit ref fields.
epriestley added a commit: rPe8f063de25c1: Modularize Herald Diffusion pre-commit content fields.
epriestley added a revision: D13612: Reduce code duplication in Herald fields.Jul 9 2015, 3:42 PM
epriestley added a revision: D13613: Begin modularizing Herald field values.Jul 9 2015, 4:06 PM
epriestley added a revision: D13614: Further modularize Herald values.Jul 9 2015, 4:33 PM
epriestley added a revision: D13616: Fully modularize Herald field values.Jul 9 2015, 8:32 PM
epriestley added a revision: D13618: Support "Select" custom fields in Herald rules.Jul 9 2015, 10:07 PM
epriestley added a revision: D13619: Group and order Herald fields.Jul 9 2015, 11:27 PM
epriestley mentioned this in T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule..Jul 10 2015, 12:40 PM
epriestley mentioned this in T8848: Add policy support to hosted repositories for allowing pushing branches or tags.Jul 15 2015, 5:14 PM
epriestley added a commit: rPb2b739c709aa: Reduce code duplication in Herald fields.Jul 16 2015, 9:11 PM
epriestley added a commit: rPa9caab49f7b5: Begin modularizing Herald field values.
epriestley added a commit: rPed3dfd491f17: Further modularize Herald values.
epriestley added a commit: rP715233fb6115: Fully modularize Herald field values.
epriestley added a commit: rP97ccd936709c: Support "Select" custom fields in Herald rules.
epriestley added a commit: rP0306eb70edfc: Group and order Herald fields.
epriestley added a revision: D13644: Rename "HeraldAction" to "HeraldActionRecord".Jul 17 2015, 3:19 PM
epriestley mentioned this in T8812: Herald Rule does not send mails.Jul 17 2015, 5:03 PM
epriestley added a revision: D13646: Make Herald action modularization more aggressive.Jul 17 2015, 5:31 PM
epriestley added a revision: D13649: Modularize Herald "flag" action, plus update transcripts.Jul 18 2015, 1:07 PM
epriestley added a subtask: T8920: 'Another Herald rule matches' is being displayed as a raw PHID.Jul 21 2015, 6:42 PM
epriestley mentioned this in T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
epriestley added a commit: rPe0861bf240cf: Rename "HeraldAction" to "HeraldActionRecord".Jul 23 2015, 8:26 PM
epriestley added a revision: D13699: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.Jul 24 2015, 2:54 PM
epriestley renamed this task from Modularize Herald fields to Modularize Herald fields and actions.Jul 24 2015, 3:35 PM
epriestley added a revision: D13701: Modularize "Send an Email" Herald actions.Jul 24 2015, 3:37 PM
epriestley closed subtask T8920: 'Another Herald rule matches' is being displayed as a raw PHID as Resolved.Jul 24 2015, 5:57 PM
epriestley added a revision: D13705: Modularize "add projects" and "remove projects" Herald actions.Jul 24 2015, 7:26 PM
epriestley added a revision: D13706: Modularize Maniphest Herald "Assign Task" action.Jul 24 2015, 8:03 PM
epriestley mentioned this in T8957: Upgrading: HeraldCustomAction is now HeraldAction.Jul 25 2015, 11:42 AM
joshuaspence awarded a token.Jul 25 2015, 11:29 PM
epriestley mentioned this in T9003: Herald rule not working.Jul 29 2015, 7:44 PM
epriestley mentioned this in T6919: Add Herald support to Ponder.Aug 3 2015, 7:40 PM
epriestley added a parent task: T6919: Add Herald support to Ponder.
epriestley mentioned this in T5194: Create documentation on how to implement a custom Herald action.Aug 3 2015, 8:11 PM
epriestley added a commit: rP56dd5211f0d0: Make Herald action modularization more aggressive.Aug 3 2015, 9:52 PM
epriestley added a commit: rP8d9bd791f7f2: Modularize Herald "flag" action, plus update transcripts.
epriestley added a commit: rP8ae08a3de70b: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.
epriestley added a commit: rP51fead17cf13: Modularize "Send an Email" Herald actions.
epriestley added a commit: rP37829926702b: Modularize "add projects" and "remove projects" Herald actions.
epriestley added a commit: rP8d8ee18ce0fd: Modularize Maniphest Herald "Assign Task" action.
epriestley added a commit: rPa335004a91a9: Modularize Differential Reviewer actions in Herald.
epriestley added a commit: rPfdd379a026c3: Modularize the Legalpad "Require Signature" Herald Action.
epriestley added a commit: rP776caa507b15: Modularize the Harbormaster "Run build plan" Herald action.
epriestley added a commit: rP6f6d88794b25: Modularize the Diffusion "Add Auditors" Herald action.
epriestley added a commit: rPa3e2f655eb87: Modularize the Diffusion/Differential "Block" Herald actions.
epriestley added a commit: rP5f76c71d781c: Share target filtering code in HeraldAction.
epriestley added a comment.Aug 3 2015, 10:05 PM

I've deployed this to this server, let me know if anyone catches anything suspicious with Herald.

epriestley added subtasks: T9055: Weird Herald spacing, T9054: Undefined class constant ACTION_BLOCK.Aug 3 2015, 10:46 PM
epriestley closed subtask T9055: Weird Herald spacing as Resolved.Aug 3 2015, 10:49 PM
epriestley closed subtask T9054: Undefined class constant ACTION_BLOCK as Resolved.Aug 4 2015, 12:05 AM
epriestley closed this task as Resolved.Aug 6 2015, 2:52 PM

Thing seem quiet now.

aik099 mentioned this in T9149: Flagging commits via Herald no longer generates flag note.Aug 12 2015, 3:40 PM
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 8:59 AM
• GoogleLegacy added a comment.Sep 10 2018, 9:06 AM
This comment was removed by epriestley.
Phabricator · Built by Phacility