Page MenuHomePhabricator
Create Task
Maniphest T8726

Modularize Herald fields and actions
Closed, ResolvedPublic
Actions

Description

Herald conditions are currently hard-coded and should be modularized to support other infrastructure changes (custom field selects, outbound mail rules).

Revisions and Commits

Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
Restricted Maniphest Task
 InvalidepriestleyT9520 Allow Workboards to show a thumbnail image within each card
 ResolvedepriestleyT4863 Allow Workboard Cards to be customized for display
 ResolvedepriestleyT10034 Plan the future of Maniphest task relationships
 OpenNoneT5353 Add visual hint to tasks that are blocked by others
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedchadT4771 Add an option to show task status in task list
 WontfixepriestleyT4782 Provide short revision status summary in Differential query results?
 ResolvedepriestleyT9287 Working with many repositories
 InvalidNoneT11466 Build status on Differential search results
 ResolvedchadT9184 Remove IRC based support
 ResolvedchadT3578 Unbeta Ponder
 ResolvedchadT6919 Add Herald support to Ponder
 OpenNoneT7004 Don't send email whilst online
 OpenNoneT9891 Verify WMF use cases are accommodated after Herald Outbound Rules resolves
 OpenNoneT5791 Write Herald rules for outbound mail
 WontfixepriestleyT3794 Rebuild Diffusion/Audit on top of CustomField infrastructure
 OpenepriestleyT418 Integrate CustomField into more interfaces
 ResolvedepriestleyT8434 Accommodate the "Security" workflow
 ResolvedNoneT5016 Allow Herald rules for Maniphest to act on custom task fields
 ResolvedepriestleyT655 Integrate CustomField into Herald
Restricted Maniphest Task
 ResolvedjoshuaspenceT5889 Allow herald rules to act on existence of auditors
 ResolvedNoneT7804 Implement an "Acting User" Herald condition
 ResolvedepriestleyT8726 Modularize Herald fields and actions
 ResolvedepriestleyT8920 'Another Herald rule matches' is being displayed as a raw PHID
 ResolvedepriestleyT9055 Weird Herald spacing
 ResolvedepriestleyT9054 Undefined class constant ACTION_BLOCK

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley claimed this task.Jun 30 2015, 4:52 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Herald.
epriestley added a parent task: T8434: Accommodate the "Security" workflow.
epriestley added a parent task: T5791: Write Herald rules for outbound mail.
epriestley added a parent task: T655: Integrate CustomField into Herald.
epriestley added a parent task: T5016: Allow Herald rules for Maniphest to act on custom task fields.
epriestley added a subscriber: epriestley.
epriestley added a parent task: T5889: Allow herald rules to act on existence of auditors.Jun 30 2015, 4:54 PM
epriestley added a parent task: T7804: Implement an "Acting User" Herald condition.
epriestley added a revision: Restricted Differential Revision.Jun 30 2015, 5:33 PM
joshuaspence added a subscriber: joshuaspence.Jun 30 2015, 8:53 PM
epriestley added a revision: Restricted Differential Revision.Jun 30 2015, 10:38 PM
epriestley added a revision: Restricted Differential Revision.Jun 30 2015, 11:00 PM
epriestley added a revision: Restricted Differential Revision.Jun 30 2015, 11:04 PM
epriestley added a revision: Restricted Differential Revision.Jun 30 2015, 11:28 PM
epriestley added a revision: Restricted Differential Revision.Jul 1 2015, 12:06 AM
epriestley added a revision: Restricted Differential Revision.Jul 1 2015, 12:51 AM
sascha-egerer added a subscriber: sascha-egerer.Jul 1 2015, 6:15 AM
epriestley added a revision: Restricted Differential Revision.Jul 1 2015, 3:05 PM
epriestley added a revision: Restricted Differential Revision.Jul 1 2015, 3:31 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 6 2015, 8:15 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 6 2015, 8:17 PM
epriestley added a revision: Restricted Differential Revision.Jul 6 2015, 9:15 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 7 2015, 6:53 PM
epriestley added a revision: Restricted Differential Revision.Jul 7 2015, 11:10 PM
epriestley renamed this task from Modularize Herald conditions to Modularize Herald fields.Jul 8 2015, 9:55 AM
epriestley added a revision: Restricted Differential Revision.Jul 8 2015, 9:58 AM
epriestley added a revision: Restricted Differential Revision.Jul 8 2015, 10:40 AM
epriestley added a revision: Restricted Differential Revision.Jul 8 2015, 11:33 AM
epriestley added a commit: Restricted Diffusion Commit.Jul 8 2015, 7:25 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 3:42 PM
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 4:06 PM
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 4:33 PM
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 8:32 PM
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 10:07 PM
epriestley added a revision: Restricted Differential Revision.Jul 9 2015, 11:27 PM
epriestley mentioned this in T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule..Jul 10 2015, 12:40 PM
epriestley mentioned this in T8848: Add policy support to hosted repositories for allowing pushing branches or tags.Jul 15 2015, 5:14 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 16 2015, 9:11 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jul 17 2015, 3:19 PM
epriestley mentioned this in T8812: Herald Rule does not send mails.Jul 17 2015, 5:03 PM
epriestley added a revision: Restricted Differential Revision.Jul 17 2015, 5:31 PM
epriestley added a revision: Restricted Differential Revision.Jul 18 2015, 1:07 PM
epriestley added a subtask: T8920: 'Another Herald rule matches' is being displayed as a raw PHID.Jul 21 2015, 6:42 PM
epriestley mentioned this in T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
epriestley added a commit: Restricted Diffusion Commit.Jul 23 2015, 8:26 PM
epriestley added a revision: Restricted Differential Revision.Jul 24 2015, 2:54 PM
epriestley renamed this task from Modularize Herald fields to Modularize Herald fields and actions.Jul 24 2015, 3:35 PM
epriestley added a revision: Restricted Differential Revision.Jul 24 2015, 3:37 PM
epriestley closed subtask T8920: 'Another Herald rule matches' is being displayed as a raw PHID as Resolved.Jul 24 2015, 5:57 PM
epriestley added a revision: Restricted Differential Revision.Jul 24 2015, 7:26 PM
epriestley added a revision: Restricted Differential Revision.Jul 24 2015, 8:03 PM
epriestley mentioned this in T8957: Upgrading: HeraldCustomAction is now HeraldAction.Jul 25 2015, 11:42 AM
joshuaspence awarded a token.Jul 25 2015, 11:29 PM
epriestley mentioned this in T9003: Herald rule not working.Jul 29 2015, 7:44 PM
epriestley mentioned this in T6919: Add Herald support to Ponder.Aug 3 2015, 7:40 PM
epriestley added a parent task: T6919: Add Herald support to Ponder.
epriestley mentioned this in T5194: Create documentation on how to implement a custom Herald action.Aug 3 2015, 8:11 PM
epriestley added a commit: Restricted Diffusion Commit.Aug 3 2015, 9:52 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a comment.Aug 3 2015, 10:05 PM

I've deployed this to this server, let me know if anyone catches anything suspicious with Herald.

epriestley added subtasks: T9055: Weird Herald spacing, T9054: Undefined class constant ACTION_BLOCK.Aug 3 2015, 10:46 PM
epriestley closed subtask T9055: Weird Herald spacing as Resolved.Aug 3 2015, 10:49 PM
epriestley closed subtask T9054: Undefined class constant ACTION_BLOCK as Resolved.Aug 4 2015, 12:05 AM
epriestley closed this task as Resolved.Aug 6 2015, 2:52 PM

Thing seem quiet now.

aik099 mentioned this in T9149: Flagging commits via Herald no longer generates flag note.Aug 12 2015, 3:40 PM
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 8:59 AM
• GoogleLegacy added a comment.Sep 10 2018, 9:06 AM
This comment was removed by epriestley.
Phabricator · Built by Phacility