Page MenuHomePhabricator
Create Task
Maniphest T8822

Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule.
Closed, ResolvedPublic
Actions

Description

When I'm trying to review rule description

H19 Prevent dangerous changes on selected branches
Affects: Commit Hook: Branches/Tags/Bookmarks

Im getting following error:

Unhandled Exception ("InvalidArgumentException")

Argument 2 passed to phutil_implode_html() must be of the type array, string given, called in /opt/phabricator/src/applications/diffusion/herald/DiffusionPreCommitRefChangeHeraldField.php on line 40 and defined

Version Info:

Phabricator Version 26faa8f1f6b4872be3cf889551cb4a480dbb2678
Arcanist Version 999eb93765688a788b77513334cc9a651726c94b
libphutil Version aa6cd8f7e5e5e637dcfcb8417fbc343b45820c93

Related Objects

Event Timeline

sicnervo created this task.Jul 10 2015, 11:59 AM
sicnervo raised the priority of this task from to Needs Triage.
sicnervo updated the task description. (Show Details)
sicnervo added a project: Herald.
sicnervo added a subscriber: sicnervo.
epriestley added a subscriber: epriestley.Jul 10 2015, 12:40 PM

This is likely fixed by further changes connected to T8726, which are currently out for review. I'll keep an eye on it.

sicnervo added a comment.Jul 13 2015, 8:26 AM

Additional information about the rule from MySQL;

idruleIDfieldNamefiledConditionvalue
33119diffusion.pre.ref.typeis"branch"
33219diffusion.pre.ref.nameregexp"RegEx"
33319diffusion.pre.ref.changebit"16"

RegEx looks like this:

@(^branch1$|^branch2$|^branch3$)@

epriestley mentioned this in T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).Jul 14 2015, 2:23 PM
epriestley closed this task as Resolved.Jul 24 2015, 11:22 PM
epriestley claimed this task.

Pretty sure this is fixed now, let me know if you're still seeing it at HEAD.

Herald added a subscriber: eadler. · View Herald TranscriptJul 24 2015, 11:22 PM
sicnervo added a comment.Jul 27 2015, 6:44 AM

Yes, it's fixed.

CodeMouse92 added a subscriber: CodeMouse92.Aug 16 2015, 10:18 PM
This comment was removed by CodeMouse92.
Phabricator · Built by Phacility