Page MenuHomePhabricator

Begin modularizing Herald field values
ClosedPublic

Authored by epriestley on Jul 9 2015, 4:06 PM.
Tags
None
Referenced Files
F14317029: D13613.id32971.diff
Wed, Dec 18, 7:45 AM
Unknown Object (File)
Sun, Dec 15, 1:26 AM
Unknown Object (File)
Thu, Dec 12, 10:54 PM
Unknown Object (File)
Thu, Dec 12, 6:26 AM
Unknown Object (File)
Thu, Dec 12, 1:43 AM
Unknown Object (File)
Wed, Dec 11, 3:55 AM
Unknown Object (File)
Sun, Dec 8, 6:46 PM
Unknown Object (File)
Fri, Dec 6, 6:39 PM
Subscribers

Details

Summary

Ref T8726. I'm primarily trying to modularize tokenizer values so we don't have to update JS to add a new one.

This is ultimately the blocker for "select" custom fields working in Herald.

This inches us toward that. I'm not modularizing conditions or control types in this round, but hope to end up with hard-coded conditions (which are highly general and very rarely change), hard-coded control types (which are also highly general and very rarely change) and completely modular fields and values (which have mid-to-low generality and change frequently).

Test Plan

Used UI to interact with "none", "text", and new-style "select" controls. No actual support for tokenizers yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin modularizing Herald field values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:39 PM
This revision was automatically updated to reflect the committed changes.