Page MenuHomePhabricator

Herald Rule does not send mails
Closed, ResolvedPublic

Description

Hello together,

I set up a Herald rule to prevent some users to do changes on a master branch.
The blocking mechanism itself works, but no mails are sent.
I already checked the maillog on the host. Mailing works in general. Other Herald rules can send mails also.

So I'm not shure if I missed anything.

pasted_file (448×800 px, 49 KB)

pasted_file (556×944 px, 50 KB)

I'm currently using phabricator in the version ab7dc13c67fde3c1fd53dfa945b940e010e5e8f9

Event Timeline

OCram raised the priority of this task from to Low.
OCram updated the task description. (Show Details)
OCram added a project: Herald.
OCram added a subscriber: OCram.
chad raised the priority of this task from Low to Needs Triage.Jul 9 2015, 2:15 PM

Shure, I will try it again after updating my phabricator instance tomorrow morning.

  • Here the transcript of the last test:
  • I also tried to swap the actions.

pasted_file (418×822 px, 54 KB)

pasted_file (546×318 px, 37 KB)

I can't reproduce this. Here's a rule I wrote:

Screen Shot 2015-07-17 at 7.30.10 AM.png (996×1 px, 152 KB)

After pushing a commit, here's the transcript:

Screen Shot 2015-07-17 at 7.30.46 AM.png (1×2 px, 221 KB)

Mail is generated and sent, and appears in the outbound mail log, e.g. bin/phd list-outbound:

$ ./bin/mail show-outbound --id 3743
PROPERTIES
ID: 3743
Status: sent
Related PHID: PHID-PSHE-m7sxhsxgly6cig6h4e4w
Message: 

PARAMETERS
sensitive: 1
subject-prefix: [Diffusion]
vary-subject-prefix: [Push]
subject: (1 commit, master) rTESTYb1ec79ed0ac5 spaghetti
from: PHID-USER-cvfydnwadpdj7vdon36z
thread-id: PHID-PSHE-m7sxhsxgly6cig6h4e4w
is-first-message: 1
is-bulk: 1
to: ["PHID-USER-hwsda37inl2orub6qxkw"]

HEADERS
Thread-Topic: (1 commit, master) rTESTYb1ec79ed0ac5 spaghetti
X-Phabricator-To: <PHID-USER-hwsda37inl2orub6qxkw>

RECIPIENTS
  example-list (Example List)

TEXT BODY
admin pushed a commit to rTESTY.

DETAILS
  http://local.phacility.com/diffusion/pushlog/view/80/

COMMITS
  rTESTYb1ec79ed0ac5 (master) spaghetti

REFERENCES
    branch master 74780a9ef32e > b1ec79ed0ac5

To: example-list


HTML BODY
(This message has no HTML body.)

Note that in this case and in the T8863 case, mail recipients must now be able to see objects (e.g., revisions and repositories) to receive email about them. It's possible that that's the source of this issue.

For example, if neither "admin" or the list have permission to see the repository (or, in the case of T8863, if the list can't see the revision or the repository it belongs to), they won't get any mail. Is it possible that's the issue?

Ah, yeah, I believe that's the issue, I thought the mailing list user doesn't have to be given the read permission specifically. Thanks a lot for looking!

I'll try to make this more clear after T8726.

Tested it again with c3e16e26c9fd7acdfa5c6a12d8c591ac46d7a85

I checked if the members who should get the message already joined the repository and have the required permissions.
But I still seen no entry in bin/phd list-outbound.

And the transcript looks fine:

pasted_file (957×884 px, 108 KB)

epriestley claimed this task.

For the original issue: when a change is blocked, we do not send email about it. There is no way to be alerted to blocked pushes right now, and I generally don't think this is useful enough to include in the upstream. This interaction could possibly be more clear, but feels like something we just stick in the documentation to me.

For the visibility issue, after T8726 the transcript will show the issue more clearly:

Screen Shot 2015-08-03 at 1.41.59 PM.png (156×571 px, 22 KB)

There is no way to be alerted to blocked pushes right now, and I generally don't think this is useful enough to include in the upstream. This interaction could possibly be more clear, but feels like something we just stick in the documentation to me.

Is this still the case? If so, I think it would help if combinations of the "Block push" and "Send email" actions were impossible. It's not at all clear from the following transcript why no e-mail is actually being generated.

screenshot.png (280×538 px, 20 KB)