Page MenuHomePhabricator
Differential D13699

Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 2:54 PM.
Tags
None
Referenced Files
F18757729: D13699.id33278.diff
Sun, Oct 5, 7:13 PM
F18674566: D13699.diff
Sep 25 2025, 3:57 PM
F18645061: D13699.id.diff
Sep 19 2025, 6:55 AM
F18636582: D13699.id33278.diff
Sep 17 2025, 4:46 AM
F18628112: D13699.id33111.diff
Sep 16 2025, 5:36 AM
F18621315: D13699.diff
Sep 15 2025, 7:45 AM
F18605764: D13699.diff
Sep 13 2025, 9:09 PM
F18598612: D13699.diff
Sep 13 2025, 5:24 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP8ae08a3de70b: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
Summary

Ref T8726. Converts these actions to be modular. No real surprises in this change.

Test Plan

Screen Shot 2015-07-18 at 7.23.46 AM.png (160×653 px, 31 KB)

  • Wrote some rules.
  • Migrated them forward.
  • Used a bunch of these rules.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33111.Jul 24 2015, 2:54 PM
epriestley retitled this revision from to Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 2:54 PM
btrahan accepted this revision.Jul 24 2015, 5:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM
joshuaspence added a subscriber: joshuaspence.Jul 25 2015, 11:28 PM
Closed by commit rP8ae08a3de70b: Make "Add Subscribers" and "Remove Subscribers" Herald actions modular (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
27 lines
src/
10 lines
applications/
differential/
herald/
4 lines
diffusion/
herald/
4 lines
herald/
action/
24 lines
adapter/
144 lines
maniphest/
herald/
4 lines
pholio/
herald/
19 lines
phriction/
herald/
4 lines
subscriptions/
herald/
37 lines
40 lines
235 lines
37 lines
40 lines
infrastructure/
internationalization/
translation/
34 lines

Diff 33278

View Options

resources/sql/autopatches/20150724.herald.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/pholio/herald/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSelfHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSubscribersHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSelfHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSubscribersHeraldAction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility