Page MenuHomePhabricator

Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
ClosedPublic

Authored by epriestley on Jul 24 2015, 2:54 PM.

Details

Summary

Ref T8726. Converts these actions to be modular. No real surprises in this change.

Test Plan

  • Wrote some rules.
  • Migrated them forward.
  • Used a bunch of these rules.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 33111.Jul 24 2015, 2:54 PM
epriestley retitled this revision from to Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jul 24 2015, 5:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM
This revision was automatically updated to reflect the committed changes.