Page MenuHomePhabricator

Make "Add Subscribers" and "Remove Subscribers" Herald actions modular
ClosedPublic

Authored by epriestley on Jul 24 2015, 2:54 PM.
Tags
None
Referenced Files
F17871988: D13699.id.diff
Mon, Jul 28, 4:18 PM
F17850894: D13699.diff
Sun, Jul 27, 10:34 AM
Unknown Object (File)
May 25 2025, 4:57 PM
Unknown Object (File)
May 21 2025, 8:15 AM
Unknown Object (File)
May 20 2025, 3:40 PM
Unknown Object (File)
May 19 2025, 10:21 AM
Unknown Object (File)
May 6 2025, 11:03 AM
Unknown Object (File)
Apr 30 2025, 10:49 AM

Details

Summary

Ref T8726. Converts these actions to be modular. No real surprises in this change.

Test Plan

Screen Shot 2015-07-18 at 7.23.46 AM.png (160×653 px, 31 KB)

  • Wrote some rules.
  • Migrated them forward.
  • Used a bunch of these rules.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make "Add Subscribers" and "Remove Subscribers" Herald actions modular.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM
This revision was automatically updated to reflect the committed changes.