Page MenuHomePhabricator

Modularize Herald "flag" action, plus update transcripts
ClosedPublic

Authored by epriestley on Jul 18 2015, 1:07 PM.
Tags
None
Referenced Files
F14046787: D13649.diff
Wed, Nov 13, 11:43 PM
F14036681: D13649.diff
Sun, Nov 10, 11:35 AM
F14019312: D13649.diff
Tue, Nov 5, 9:53 PM
F13997002: D13649.id.diff
Thu, Oct 24, 1:36 AM
F13984750: D13649.diff
Sun, Oct 20, 3:39 PM
F13973610: D13649.id32996.diff
Fri, Oct 18, 1:43 AM
F13956793: D13649.id.diff
Oct 14 2024, 7:08 AM
Unknown Object (File)
Sep 21 2024, 8:33 AM

Details

Summary

Ref T8726. This modularizes "Mark with flag", plus rebuilds transcripts in a more modern/flexible way. The big transcript stuff is:

  • Transcripts are now translatable.
  • Transcripts can now show multiple outputs from a single action. For example, an action like "add A, B, C to subscribers" can now say "added A; B is invalid; C was already subscribed".
Test Plan

Screen Shot 2015-07-18 at 5.53.53 AM.png (954×2 px, 165 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize Herald "flag" action, plus update transcripts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:20 PM
This revision was automatically updated to reflect the committed changes.