Page MenuHomePhabricator

Further modularize Herald values
ClosedPublic

Authored by epriestley on Jul 9 2015, 4:33 PM.
Tags
None
Referenced Files
F14000550: D13614.diff
Thu, Oct 24, 10:45 PM
F13976493: D13614.id.diff
Fri, Oct 18, 2:31 PM
F13962860: D13614.id32896.diff
Tue, Oct 15, 12:42 PM
Unknown Object (File)
Sep 12 2024, 7:49 AM
Unknown Object (File)
Sep 5 2024, 3:00 PM
Unknown Object (File)
Aug 31 2024, 5:11 PM
Unknown Object (File)
Aug 19 2024, 4:04 AM
Unknown Object (File)
Aug 15 2024, 3:20 PM
Subscribers

Details

Summary

Ref T8726. Modularize action values. Fully modularize "text", "none" and "select" controls. Only tokenizers remain.

Test Plan
  • Used all affected value types in UI.
  • Reviewed rules using new modular rendering, saw sensible output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Further modularize Herald values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
This revision was automatically updated to reflect the committed changes.