Page MenuHomePhabricator

Further modularize Herald values
ClosedPublic

Authored by epriestley on Jul 9 2015, 4:33 PM.
Tags
None
Referenced Files
F12858000: D13614.id32896.diff
Fri, Mar 29, 11:10 AM
Unknown Object (File)
Mon, Mar 25, 1:52 PM
Unknown Object (File)
Mon, Mar 25, 1:51 PM
Unknown Object (File)
Fri, Mar 1, 3:20 PM
Unknown Object (File)
Feb 10 2024, 4:24 PM
Unknown Object (File)
Feb 3 2024, 5:48 AM
Unknown Object (File)
Feb 1 2024, 9:21 PM
Unknown Object (File)
Jan 23 2024, 2:51 PM
Subscribers

Details

Summary

Ref T8726. Modularize action values. Fully modularize "text", "none" and "select" controls. Only tokenizers remain.

Test Plan
  • Used all affected value types in UI.
  • Reviewed rules using new modular rendering, saw sensible output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Further modularize Herald values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
This revision was automatically updated to reflect the committed changes.