Differential D13616 Authored by epriestley on Jul 9 2015, 8:32 PM.
Details
Summary Ref T8726. This gets rid of all the VALUE_* constants and lets Fields provide arbitrary typeaheads without upstream/JS changes. Test Plan Used all tokenizers. Used "Another Herald Rule". Grepped for all removed constants.
Diff Detail
Event Timelineepriestley updated this object. Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2015, 8:33 PM2015-07-09 20:33:00 (UTC+0) btrahan edited edge metadata. This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM2015-07-16 20:42:52 (UTC+0) Closed by commit rP715233fb6115: Fully modularize Herald field values (authored by epriestley, committed by epriestley). · Explain WhyJul 16 2015, 9:12 PM2015-07-16 21:12:48 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 32973 src/applications/differential/herald/DifferentialRevisionRepositoryProjectsHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryProjectsHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.phpLoading... |