Page MenuHomePhabricator

Fully modularize Herald field values
ClosedPublic

Authored by epriestley on Jul 9 2015, 8:32 PM.
Tags
None
Referenced Files
F18751366: D13616.id.diff
Sat, Oct 4, 10:43 AM
F18738010: D13616.diff
Wed, Oct 1, 1:42 PM
F18705694: D13616.diff
Sun, Sep 28, 12:40 PM
F18705599: D13616.id32898.diff
Sun, Sep 28, 12:09 PM
F18655300: D13616.id.diff
Mon, Sep 22, 7:40 PM
F18612081: D13616.id32898.diff
Sun, Sep 14, 8:44 AM
F18582490: D13616.id32973.diff
Thu, Sep 11, 8:31 AM
F18506224: D13616.id.diff
Sep 5 2025, 1:16 AM
Subscribers

Details

Summary

Ref T8726. This gets rid of all the VALUE_* constants and lets Fields provide arbitrary typeaheads without upstream/JS changes.

Test Plan

Used all tokenizers. Used "Another Herald Rule". Grepped for all removed constants.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fully modularize Herald field values.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 16 2015, 8:42 PM
This revision was automatically updated to reflect the committed changes.