Page MenuHomePhabricator

Modularize all Diffusion commit Herald fields
ClosedPublic

Authored by epriestley on Jul 6 2015, 9:15 PM.

Details

Summary

Ref T8726.

Test Plan

Created a giant rule with every commit field:

Ran the upgrade, got the same rule with new fields:

Used "Test Console" to run transcripts, saw all the fields populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32788.Jul 6 2015, 9:15 PM
epriestley retitled this revision from to Modularize all Diffusion commit Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jul 7 2015, 6:36 PM
btrahan edited edge metadata.

I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.

This revision is now accepted and ready to land.Jul 7 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.