I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.

This revision is now accepted and ready to land.Jul 7 2015, 6:36 PM

Closed by commit rP98ac0a022c90: Modularize all Diffusion commit Herald fields (authored by epriestley). · Explain WhyJul 7 2015, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	resources/sql/autopatches/20150706.herald.1.sql (133 lines)
M		src/__phutil_library_map__.php (44 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitAffectedFilesHeraldField.php (24 lines)
P		src/applications/diffusion/herald/DiffusionCommitAuthorHeraldField.php (18 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
A	M	src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php (26 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php (38 lines)
P		src/applications/diffusion/herald/DiffusionCommitCommitterHeraldField.php (18 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
A	M	src/applications/diffusion/herald/DiffusionCommitDiffContentAddedHeraldField.php (24 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitDiffContentHeraldField.php (24 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitDiffContentRemovedHeraldField.php (24 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitDiffEnormousHeraldField.php (24 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitHeraldField.php (9 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitMessageHeraldField.php (24 lines)
P		src/applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php (21 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
P		src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php (17 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
A	M	src/applications/diffusion/herald/DiffusionCommitPackageOwnerHeraldField.php (37 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitRepositoryHeraldField.php (24 lines)
P		src/applications/diffusion/herald/DiffusionCommitRepositoryProjectsHeraldField.php (16 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
P		src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php (18 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
A	M	src/applications/diffusion/herald/DiffusionCommitRevisionAcceptedHeraldField.php (40 lines)
A	M	src/applications/diffusion/herald/DiffusionCommitRevisionHeraldField.php (30 lines)
P		src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php (22 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
P		src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php (21 lines) Copied from src/applications/subscriptions/herald/HeraldSubscribersField.php
V		src/applications/{diffusion/herald ← herald/adapter}/HeraldCommitAdapter.php (166 lines)
V		src/applications/{herald/adapter → diffusion/herald}/HeraldCommitAdapter.php
M		src/applications/herald/field/HeraldField.php (19 lines)
M		src/applications/maniphest/herald/ManiphestTaskAssigneeHeraldField.php (8 lines)
P		src/applications/subscriptions/herald/HeraldSubscribersField.php (2 lines) Copied to multiple locations: src/applications/diffusion/herald/DiffusionCommitAuthorHeraldField.php src/applications/diffusion/herald/DiffusionCommitCommitterHeraldField.php src/applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php src/applications/diffusion/herald/DiffusionCommitRepositoryProjectsHeraldField.php src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php