Page MenuHomePhabricator

Modularize all Diffusion commit Herald fields
ClosedPublic

Authored by epriestley on Jul 6 2015, 9:15 PM.
Tags
None
Referenced Files
F17628767: D13567.id32788.diff
Thu, Jul 10, 7:59 AM
F17628045: D13567.id32788.diff
Thu, Jul 10, 7:07 AM
F17619950: D13567.diff
Wed, Jul 9, 8:01 PM
Unknown Object (File)
Jun 27 2025, 4:01 PM
Unknown Object (File)
Jun 6 2025, 7:22 PM
Unknown Object (File)
May 23 2025, 4:57 AM
Unknown Object (File)
May 8 2025, 8:59 AM
Unknown Object (File)
May 6 2025, 3:48 AM
Subscribers

Details

Summary

Ref T8726.

Test Plan

Created a giant rule with every commit field:

Screen Shot 2015-07-06 at 1.57.11 PM.png (1×1 px, 271 KB)

Ran the upgrade, got the same rule with new fields:

Screen Shot 2015-07-06 at 2.08.34 PM.png (1×1 px, 268 KB)

Used "Test Console" to run transcripts, saw all the fields populate correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all Diffusion commit Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.

This revision is now accepted and ready to land.Jul 7 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.