Page MenuHomePhabricator

Rename "HeraldAction" to "HeraldActionRecord"
ClosedPublic

Authored by epriestley on Jul 17 2015, 3:19 PM.
Tags
None
Referenced Files
F17814261: D13644.id.diff
Fri, Jul 25, 9:01 PM
F17770196: D13644.diff
Wed, Jul 23, 9:21 AM
F17636621: D13644.id.diff
Fri, Jul 11, 11:43 AM
F17617086: D13644.diff
Wed, Jul 9, 3:47 PM
Unknown Object (File)
May 27 2025, 7:08 PM
Unknown Object (File)
May 23 2025, 4:58 AM
Unknown Object (File)
Apr 26 2025, 11:59 PM
Unknown Object (File)
Apr 26 2025, 2:50 AM
Subscribers

Details

Summary

Ref T8726. I want to modularize actions like fields, but the base class should be "HeraldAction".

Eventually, "HeraldCondition" should probably be "HeraldFieldRecord", and then both Action and Condition should just be rolled into Rule, probably, but that can wait and doesn't block anything.

Test Plan

Ran migration, poked around UI, used git grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Rename "HeraldAction" to "HeraldActionRecord".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.