Page MenuHomePhabricator

Modernize all Herald DifferentialDiff fields
ClosedPublic

Authored by epriestley on Jul 7 2015, 11:10 PM.
Tags
None
Referenced Files
F14353579: D13590.diff
Thu, Dec 19, 4:42 PM
Unknown Object (File)
Tue, Dec 10, 1:35 AM
Unknown Object (File)
Sun, Dec 8, 1:37 AM
Unknown Object (File)
Thu, Dec 5, 9:47 AM
Unknown Object (File)
Thu, Dec 5, 5:44 AM
Unknown Object (File)
Sun, Dec 1, 12:06 AM
Unknown Object (File)
Fri, Nov 29, 11:40 PM
Unknown Object (File)
Thu, Nov 28, 11:23 PM
Subscribers

Details

Summary

Ref T8726. This deals with all the Differential diff fields, same deal as previous changes.

Test Plan
  • Wrote a rule with every field.
  • Migrated it.
  • Saw the same rule working.
  • Rigged the hell out of transcripts (diffs normally do not generate transcripts, because the only action is "block" and they don't exist yet when Herald runs).
  • Verified that all fields looked sensible in the transcript.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize all Herald DifferentialDiff fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 6:56 PM
This revision was automatically updated to reflect the committed changes.