Page MenuHomePhabricator

Modularize all remaining Maniphest Herald fields
ClosedPublic

Authored by epriestley on Jul 1 2015, 12:51 AM.

Details

Summary

Ref T8726. The only notable bit here is that the "body" / "title" fields (which are currently shared across a bunch of types) are getting split into application variants.

Among other things, this will let us label the field "Commit message" for commits, for example.

Test Plan
  • Created a rule using all four fields.
  • Applied patch, saw rule break ("unknown field").
  • Ran storage upgrade, saw rule fix itself in the migration.
  • Edited tasks, triggered rule, viewed transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32656.Jul 1 2015, 12:51 AM
epriestley retitled this revision from to Modularize all remaining Maniphest Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 32672.Jul 1 2015, 2:32 PM
  • Use more general field constants and class names.
btrahan accepted this revision.Jul 1 2015, 5:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:27 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
This revision was automatically updated to reflect the committed changes.