Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32868.Jul 8 2015, 10:40 AM
epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 32869.Jul 8 2015, 11:12 AM
  • Also handle special rendering of "Change" rule.
epriestley updated this revision to Diff 32870.Jul 8 2015, 11:12 AM
  • Less-incorrect change.
btrahan accepted this revision.Jul 8 2015, 7:00 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1223

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.