Page MenuHomePhabricator

Modularize all Herald pre-commit ref fields
ClosedPublic

Authored by epriestley on Jul 8 2015, 10:40 AM.
Tags
None
Referenced Files
F14059168: D13600.diff
Sun, Nov 17, 5:58 PM
F14046096: D13600.diff
Wed, Nov 13, 6:17 PM
F14034402: D13600.diff
Sun, Nov 10, 12:01 AM
F14021670: D13600.diff
Wed, Nov 6, 11:10 AM
F14017119: D13600.id32880.diff
Mon, Nov 4, 2:21 PM
F13994221: D13600.id32880.diff
Wed, Oct 23, 4:43 AM
F13993313: D13600.id.diff
Tue, Oct 22, 10:02 PM
F13985462: D13600.diff
Sun, Oct 20, 8:40 PM
Subscribers

Details

Summary

Ref T8726. Just (pre-commit content) one more left.

Test Plan
  • Created a big rule with every field.
  • Migrated it.
  • Verified the rule was still the same.
  • Pushed a bunch of changes and reviewed the transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all Herald pre-commit ref fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also handle special rendering of "Change" rule.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1215–1223

nice

This revision is now accepted and ready to land.Jul 8 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.