Page MenuHomePhabricator

Begin modularizing Herald fields

Authored by epriestley on Jun 30 2015, 5:33 PM.



Ref T8726. This lays groundwork for modularizing Herald fields and modularizes the "Content source" field.

This doesn't touch conditions or values yet.

Test Plan

Created a rule with a "content source" field, created a new task, saw rule apply.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32631.Jun 30 2015, 5:33 PM
epriestley retitled this revision from to Begin modularizing Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jun 30 2015, 6:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:22 PM
joshuaspence added a subscriber: joshuaspence.
eadler added a subscriber: eadler.Jul 3 2015, 7:49 PM
This revision was automatically updated to reflect the committed changes.