HomePhabricator

Modernize all Herald DifferentialDiff fields

Authored by epriestley.

Description

Modernize all Herald DifferentialDiff fields

Summary: Ref T8726. This deals with all the Differential diff fields, same deal as previous changes.

Test Plan:

  • Wrote a rule with every field.
  • Migrated it.
  • Saw the same rule working.
  • Rigged the hell out of transcripts (diffs normally do not generate transcripts, because the only action is "block" and they don't exist yet when Herald runs).
  • Verified that all fields looked sensible in the transcript.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13590

Details

Committed
epriestleyJul 8 2015, 7:25 PM
Pushed
epriestleyJul 8 2015, 7:25 PM
Reviewer
btrahan
Differential Revision
D13590: Modernize all Herald DifferentialDiff fields
Parents
rPae81f86a67b3: Fix some Releeph jankiness in interacting with the redesign
Branches
Unknown
Tags
Unknown
Tasks
T8726: Modularize Herald fields and actions