Page MenuHomePhabricator

Modularize "Send an Email" Herald actions
ClosedPublic

Authored by epriestley on Jul 24 2015, 3:37 PM.
Tags
None
Referenced Files
F14001487: D13701.id33279.diff
Fri, Oct 25, 8:32 AM
F13964654: D13701.id.diff
Tue, Oct 15, 9:13 PM
F13964653: D13701.diff
Tue, Oct 15, 9:13 PM
F13964216: D13701.id33279.diff
Tue, Oct 15, 7:56 PM
F13959945: D13701.diff
Mon, Oct 14, 9:26 PM
Unknown Object (File)
Oct 2 2024, 2:10 PM
Unknown Object (File)
Sep 16 2024, 10:38 PM
Unknown Object (File)
Sep 12 2024, 7:52 AM

Details

Summary

Ref T8726. No surprises.

Test Plan

Created rules using both action variants, applied upgrade, saw rules still work correctly.

Screen Shot 2015-07-24 at 8.32.28 AM.png (152×544 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize "Send an Email" Herald actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM
src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php
15–22

nice

This revision was automatically updated to reflect the committed changes.