Page MenuHomePhabricator

Upgrading: HeraldCustomAction is now HeraldAction
Closed, ResolvedPublic


If you implement custom actions in Herald, you should now subclass HeraldAction instead of HeraldCustomAction.

The HeraldCustomAction class no longer exists, and code extending it will not load, work, or have any effect.

The API for HeraldAction differs from the API for HeraldCustomAction. You can look at the native actions (which now also extend HeraldAction) for guidance.

See T8726 for some context.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Herald.
epriestley added a subscriber: epriestley.

This stuff is now in HEAD, and HEAD no longer loads (or even contains) HeraldCustomAction.

epriestley claimed this task.

This has been live for about a month without any followup concerns.