Page MenuHomePhabricator

Integrate CustomField into Herald
Closed, ResolvedPublic

Description

Leftover from T343. Integrate custom fields into Herald, so you can write rules based on them. Nice to have, but no requests for it yet.

(same as Facebook task 518501)

Related Objects

Event Timeline

epriestley added a project: Differential.
epriestley added a subscriber: epriestley.
epriestley added a subscriber: Unknown Object (MLST).Sep 3 2013, 11:34 PM

This will impact FB as it moves forward, because FB has custom Differential fields.

epriestley renamed this task from Integrate Differential custom fields into Herald to Integrate CustomField into Herald.Apr 3 2014, 10:16 PM
epriestley edited projects, added Custom Fields; removed Differential.
epriestley added a subscriber: bigo.

@bigo / @frgtn, this probably doesn't cover your use case completely as-is, but I'm not sure how close it gets. In particular, these field types are supported:

  • bool, remarkup, text, users
  • fully custom fields which reasonably approximate these standard fields

These are not, but support is meaningless because they aren't editable:

  • header

These are not, but support is possible:

  • date (needs range/comparison conditions, and date value type?)
  • int (needs range/comparsion conditions?)
  • select (needs custom value type with options)
  • credential (unclear what support would look like, needs new value type?)
  • fully custom fields which are similar to these standard fields

Basically, do you want to write conditions against any of these unsupported field types at this time? For example, [number of hours] [is greater than] [2], or [some custom select dropdown] [is any of] [custom value 1, custom value 2]? If so, which ones?

Would love to see date fields supported.

The use case I'm trying to cover is to create notifications for open tasks that are past their Due Date (custom date field that we use).

It appears that all the blocking and related tasks have been completed, but this one is still pending. If this is no longer blocked it may be worth re-prioritizing higher and addressing :)

epriestley changed the visibility from "All Users" to "Public (No Login Required)".

We have a custom field for "Task type" (feature, bug, etc). Would *love* the ability to use herald with this field.

That's supported after D13618.

Only "date", "int" and "credential" remain unsupported.

epriestley claimed this task.

The use case I'm trying to cover is to create notifications for open tasks that are past their Due Date (custom date field that we use).

See T6491.

We don't have any actual outstanding requests for "date" (as it would actually work), "int" or "credential" (or any of the more esoteric and primarily internal fields which now exist) so I'm going to close this until we do.