Page MenuHomePhabricator

Make Herald action modularization more aggressive
ClosedPublic

Authored by epriestley on Jul 17 2015, 5:31 PM.

Details

Summary

Ref T8726. Herald actions are technically sort-of modular already, but make them more aggressively modular similar to HeraldField.

I plan to obsolete and replace HeraldCustomAction.

Test Plan

Saw actions in nice groups; created and ran a "Do Nothing" action. Transcripts are a bit rough for now.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32992.Jul 17 2015, 5:31 PM
epriestley retitled this revision from to Make Herald action modularization more aggressive.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
joshuaspence added inline comments.
src/applications/herald/action/HeraldAction.php
70

I wonder if we can do this in a more general way, see D13541 for am example of why.

Should be moot since it's cached behind PhutilClassMapQuery for the specific concern there.

btrahan accepted this revision.Jul 20 2015, 6:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:15 PM
This revision was automatically updated to reflect the committed changes.