Page MenuHomePhabricator
Differential D13646

Make Herald action modularization more aggressive
ClosedPublic
Actions

Authored by epriestley on Jul 17 2015, 5:31 PM.
Tags
None
Referenced Files
F13082078: D13646.diff
Wed, Apr 24, 9:59 PM
Unknown Object (File)
Wed, Apr 24, 8:17 AM
Unknown Object (File)
Mon, Apr 22, 8:59 AM
Unknown Object (File)
Mon, Apr 22, 8:20 AM
Unknown Object (File)
Sun, Apr 21, 4:03 PM
Unknown Object (File)
Wed, Apr 17, 3:04 PM
Unknown Object (File)
Thu, Apr 11, 7:14 AM
Unknown Object (File)
Fri, Apr 5, 1:27 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP56dd5211f0d0: Make Herald action modularization more aggressive
Summary

Ref T8726. Herald actions are technically sort-of modular already, but make them more aggressively modular similar to HeraldField.

I plan to obsolete and replace HeraldCustomAction.

Test Plan

Saw actions in nice groups; created and ran a "Do Nothing" action. Transcripts are a bit rough for now.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32992.Jul 17 2015, 5:31 PM
epriestley retitled this revision from to Make Herald action modularization more aggressive.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2015, 5:31 PM
joshuaspence added a subscriber: joshuaspence.Jul 18 2015, 1:49 AM
joshuaspence added inline comments.
src/applications/herald/action/HeraldAction.php
70

I wonder if we can do this in a more general way, see D13541 for am example of why.

epriestley added a comment.Jul 18 2015, 2:52 AM

Should be moot since it's cached behind PhutilClassMapQuery for the specific concern there.

btrahan accepted this revision.Jul 20 2015, 6:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:15 PM
Closed by commit rP56dd5211f0d0: Make Herald action modularization more aggressive (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
18 lines
applications/
differential/
herald/
1 line
2 lines
diffusion/
herald/
2 lines
2 lines
herald/
action/
118 lines
32 lines
15 lines
15 lines
15 lines
15 lines
action/
field/
HeraldActionGroup.php
HeraldFieldGroup.php
18 lines
adapter/
116 lines
controller/
87 lines
8 lines
field/
14 lines
group/
15 lines
maniphest/
herald/
2 lines
pholio/
herald/
2 lines
phriction/
herald/
2 lines
webroot/
rsrc/
js/
application/
herald/
40 lines

Diff 33276

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/herald/HeraldDifferentialDiffAdapter.php

Loading...
View Options

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...
View Options

src/applications/herald/action/HeraldAction.php

Loading...
View Options

src/applications/herald/action/HeraldActionGroup.php

Loading...
View Options

src/applications/herald/action/HeraldDoNothingAction.php

Loading...
View Options

src/applications/herald/action/HeraldNotifyActionGroup.php

Loading...
View Options

src/applications/herald/action/HeraldPreventActionGroup.php

Loading...
View Options

src/applications/herald/action/HeraldSupportActionGroup.php

Loading...
View Options

src/applications/herald/action/HeraldUtilityActionGroup.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/herald/field/HeraldFieldGroup.php

Loading...
View Options

src/applications/herald/group/HeraldGroup.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/pholio/herald/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
Phabricator · Built by Phacility