Ref T8726. Some adapters now have a large number of fields, and we lost the sort-of-human-readable implicit ordering when fields were modularized.
Instead, group and sort fields.
Differential D13619 Authored by epriestley on Jul 9 2015, 11:27 PM.
Tags None Referenced Files Subscribers Tokens "Like" token, awarded by eadler.
Details
Summary Ref T8726. Some adapters now have a large number of fields, and we lost the sort-of-human-readable implicit ordering when fields were modularized. Instead, group and sort fields. Test Plan
Diff Detail
Event Timelineepriestley updated this object. Herald added a subscriber: epriestley. · View Herald TranscriptJul 9 2015, 11:27 PM2015-07-09 23:27:58 (UTC+0) This revision is now accepted and ready to land.Jul 14 2015, 3:01 PM2015-07-14 15:01:18 (UTC+0) Closed by commit rP0306eb70edfc: Group and order Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 16 2015, 9:13 PM2015-07-16 21:13:17 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 32975 src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentAddedHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentDiffContentRemovedHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.phpLoading... |