Page MenuHomePhabricator

Modularize "add projects" and "remove projects" Herald actions
ClosedPublic

Authored by epriestley on Jul 24 2015, 7:26 PM.

Details

Summary

Ref T8726. Convert these to be modular.

Test Plan
  • Created rules using these actions.
  • Upgraded them.
  • Verified they still work.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 33123.Jul 24 2015, 7:26 PM
epriestley retitled this revision from to Modularize "add projects" and "remove projects" Herald actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jul 25 2015, 12:01 AM
btrahan edited edge metadata.
btrahan added inline comments.
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1318

duplicate s

This revision is now accepted and ready to land.Jul 25 2015, 12:01 AM
epriestley edited edge metadata.
  • Fix duplicate "ss".
joshuaspence rescinded a token.
joshuaspence awarded a token.
joshuaspence added a subscriber: joshuaspence.
This revision was automatically updated to reflect the committed changes.