Page MenuHomePhabricator

Inline CommentsProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Mar 17 2021

epriestley closed T13513: Make schema changes to inlines to prepare for new inline features as Resolved.

When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.

Mar 17 2021, 10:59 PM · Inline Comments, Diffusion, Differential

Mar 15 2021

epriestley moved T13513: Make schema changes to inlines to prepare for new inline features from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Inline Comments, Diffusion, Differential

May 23 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21287: Fix an issue where inline comments with only edit suggestions are considered empty.
May 23 2020, 3:18 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In previews, suggestions aren't highlighted properly (likely just missing CSS).
May 23 2020, 3:15 PM · Inline Comments, Diffusion, Differential

May 21 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21283: Prevent keyboard selection of change blocks inside edit suggestions.
May 21 2020, 10:06 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • j, etc., can incorrectly select blocks inside a diff inside a suggestion.
May 21 2020, 9:41 PM · Inline Comments, Diffusion, Differential

May 20 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21281: Drop old "differential_commit" table.
May 20 2020, 7:30 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21280: Use the changeset parse cache to cache suggestion changesets.
May 20 2020, 6:37 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:

May 20 2020, 6:31 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21279: Put a readthrough cache in front of inline context construction.
May 20 2020, 5:37 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21278: Clean up Diffusion behaviors for inline edit suggestions.
May 20 2020, 4:22 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21277: Render inline comment suggestions as real diffs.
May 20 2020, 4:10 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
    • Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.
May 20 2020, 3:53 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

The inline comment context menu does not apply the correct cursor ("pointer").

May 20 2020, 3:23 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21276: Roughly support inline comment suggestions.
May 20 2020, 3:16 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:

May 20 2020, 12:31 AM · Inline Comments, Diffusion, Differential

May 19 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21275: Make server components of inline comment content handling state-oriented.
May 19 2020, 9:56 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.
May 19 2020, 9:53 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21274: Allow "has draft inlines?" queries to overheat.
May 19 2020, 8:54 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21273: Make inline content "state-oriented", not "string-oriented".
May 19 2020, 8:51 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • The inline comment context menu does not apply the correct cursor ("pointer").
May 19 2020, 4:27 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21268: Fix "r" and "R" both replying with quote on inline comments.
May 19 2020, 4:26 PM · Inline Comments, Diffusion, Differential

May 15 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21263: Fix an out-of-order access issue with inlines.
May 15 2020, 8:27 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21262: Use a more consistent inline highlighting style with fewer redraws.
May 15 2020, 7:43 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions.
May 15 2020, 4:35 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • The line-triggered reticle should be updated to use the hover-reticle cell style.
May 15 2020, 12:24 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Screen Shot 2020-05-14 at 5.01.17 PM.png (545×661 px, 44 KB)

May 15 2020, 12:03 AM · Inline Comments, Diffusion, Differential

May 14 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21257: Improve offset/range inline behavior for rich diffs and unified diffs.
May 14 2020, 10:53 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21256: Give selected inline comments are more obvious selected state.
May 14 2020, 8:18 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21255: When users click headers to select diff UI elements, don't eat the events.
May 14 2020, 6:46 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact.
May 14 2020, 6:40 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21253: When cancelling an inline comment edit, exit the edit state after the response arrives.
May 14 2020, 6:19 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets.
May 14 2020, 5:57 PM · Inline Comments, Diffusion, Differential

May 13 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21250: Store inline comment offset information and show it when highlighting comments.
May 13 2020, 11:55 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.
May 13 2020, 11:05 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21249: Improve select-to-comment behavior in Firefox and on unified diffs.
May 13 2020, 8:47 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • In Firefox, multi-line selections don't generate a context menu properly.
  • Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
  • Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.
May 13 2020, 8:20 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21248: Allow users to create inline comments by directly selecting text directly.
May 13 2020, 8:17 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: D21246: Add "View Raw Remarkup" to inline comments.
May 13 2020, 4:31 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21246: Add "View Raw Remarkup" to inline comments.
May 13 2020, 4:31 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.
May 13 2020, 4:30 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.

May 13 2020, 4:18 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments: D21244: Move inline comment actions into a dropdown menu.
May 13 2020, 12:57 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21244: Move inline comment actions into a dropdown menu.
May 13 2020, 12:57 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Inline stuff:

May 13 2020, 12:43 PM · Inline Comments, Diffusion, Differential

May 12 2020

epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets.
May 12 2020, 11:00 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21242: When an inline was left on a rendered DocumentEngine document, don't include an email context patch.
May 12 2020, 9:09 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21241: Make "View as Document Type..." only show valid options.
May 12 2020, 8:33 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21240: When creating an inline, save the current document engine.
May 12 2020, 7:19 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Probably kicking this, but:

May 12 2020, 6:31 PM · Inline Comments, Diffusion, Differential