Page MenuHomePhabricator

Allow users to create inline comments by directly selecting text directly
ClosedPublic

Authored by epriestley on May 13 2020, 8:17 PM.

Details

Summary

Ref T13513. Support direct text selection for inlines. This is currently just an alternate way to get to the same place as using line numbers, but can preserve offset/range information in the future.

Test Plan
  • Selected some text, hit "c", clicked "New Inline Comment", got sensible comments on both sides of a diff in Safari, Chrome, and (with limitations) Firefox.
  • Caveats: no unified support, doesn't work across lines in Firefox.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:15 AM
This revision was automatically updated to reflect the committed changes.