Page MenuHomePhabricator

Allow users to create inline comments by directly selecting text directly
ClosedPublic

Authored by epriestley on Wed, May 13, 8:17 PM.

Details

Summary

Ref T13513. Support direct text selection for inlines. This is currently just an alternate way to get to the same place as using line numbers, but can preserve offset/range information in the future.

Test Plan
  • Selected some text, hit "c", clicked "New Inline Comment", got sensible comments on both sides of a diff in Safari, Chrome, and (with limitations) Firefox.
  • Caveats: no unified support, doesn't work across lines in Firefox.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 13, 8:17 PM
epriestley requested review of this revision.Wed, May 13, 8:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 12:15 AM
This revision was automatically updated to reflect the committed changes.