Page MenuHomePhabricator

Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
ClosedPublic

Authored by epriestley on May 15 2020, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 8:26 PM
Unknown Object (File)
Fri, Dec 27, 3:15 PM
Unknown Object (File)
Dec 19 2024, 7:56 PM
Unknown Object (File)
Dec 18 2024, 6:56 PM
Unknown Object (File)
Dec 10 2024, 8:24 PM
Unknown Object (File)
Dec 8 2024, 6:49 PM
Unknown Object (File)
Oct 25 2024, 8:39 AM
Unknown Object (File)
Oct 20 2024, 12:52 PM
Subscribers
None

Details

Summary

Ref T13513. See PHI1734, which raises a concern about the performance of large revisions near the 100-change threshold.

Currently, getInlines() is called whenever the scroll position transitions between two changesets, and it performs a relatively complicated DOM scan to lift inlines out of the document.

This shows up as taking a small but nontrivial amount of time in Firefox profiles and should be safely memoizable.

Test Plan
  • Under Firefox profiling, scrolled through a large revision.
  • Before change: getInlines() appeared as the highest-cost thing we're explicitly doing on profiles.
  • After change: getInlines() was no longer meaningfully represented on profiles.
  • Created inlines, edited inlines, etc. Didn't identify any broken behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable