Page MenuHomePhabricator

Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions

Authored by epriestley on May 15 2020, 4:35 PM.
Referenced Files
Unknown Object (File)
Mon, Jun 27, 9:09 PM
Unknown Object (File)
Mon, Jun 27, 6:02 PM
Unknown Object (File)
Sat, Jun 25, 4:24 PM
Unknown Object (File)
Thu, Jun 16, 12:29 PM
Unknown Object (File)
Fri, Jun 10, 6:33 AM
Unknown Object (File)
Tue, Jun 7, 10:39 PM
Unknown Object (File)
Thu, Jun 2, 6:24 PM
Unknown Object (File)
May 28 2022, 5:43 PM



Ref T13513. See PHI1734, which raises a concern about the performance of large revisions near the 100-change threshold.

Currently, getInlines() is called whenever the scroll position transitions between two changesets, and it performs a relatively complicated DOM scan to lift inlines out of the document.

This shows up as taking a small but nontrivial amount of time in Firefox profiles and should be safely memoizable.

Test Plan
  • Under Firefox profiling, scrolled through a large revision.
  • Before change: getInlines() appeared as the highest-cost thing we're explicitly doing on profiles.
  • After change: getInlines() was no longer meaningfully represented on profiles.
  • Created inlines, edited inlines, etc. Didn't identify any broken behavior.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable