Page MenuHomePhabricator

Render proper "Show Context" links in DocumentEngine diffs, not just bullets
ClosedPublic

Authored by epriestley on May 12 2020, 11:00 PM.
Tags
None
Referenced Files
F19937178: D21243.diff
Sun, Apr 12, 7:54 PM
F19897202: D21243.diff
Sun, Mar 29, 6:59 AM
F19802723: D21243.id50591.diff
Mar 1 2026, 6:31 PM
F19493449: D21243.diff
Jan 8 2026, 8:58 AM
F19493411: D21243.diff
Jan 8 2026, 8:54 AM
F19493384: D21243.diff
Jan 8 2026, 8:52 AM
F19468238: D21243.id.diff
Jan 4 2026, 1:00 AM
F19099509: D21243.id.diff
Dec 4 2025, 8:09 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, viewing a Jupyter document, hidden context just gets a plain "* * *" facade with no way to expand it.

Support click-to-expand, like source changes.

Test Plan
  • Clicked to expand various Jupyter diffs.
  • Clicked to expand normal source changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 11:09 PM
This revision was automatically updated to reflect the committed changes.