Page MenuHomePhabricator

Render proper "Show Context" links in DocumentEngine diffs, not just bullets
ClosedPublic

Authored by epriestley on May 12 2020, 11:00 PM.
Tags
None
Referenced Files
F15316145: D21243.diff
Thu, Mar 6, 6:23 PM
Unknown Object (File)
Mon, Feb 24, 2:43 AM
Unknown Object (File)
Mon, Feb 24, 1:55 AM
Unknown Object (File)
Mon, Feb 17, 1:41 AM
Unknown Object (File)
Feb 9 2025, 9:16 AM
Unknown Object (File)
Feb 9 2025, 9:16 AM
Unknown Object (File)
Feb 9 2025, 9:16 AM
Unknown Object (File)
Jan 30 2025, 11:03 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, viewing a Jupyter document, hidden context just gets a plain "* * *" facade with no way to expand it.

Support click-to-expand, like source changes.

Test Plan
  • Clicked to expand various Jupyter diffs.
  • Clicked to expand normal source changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 11:09 PM
This revision was automatically updated to reflect the committed changes.