Page MenuHomePhabricator

Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact
ClosedPublic

Authored by epriestley on Thu, May 14, 6:40 PM.

Details

Summary

Ref T13513. In Safari, do this:

  • view a 2-up diff with content on both sides;
  • select more than one line on the right side; and
  • use your mouse to click "New Inline Comment" in the context menu that pops up.

The mousedown event for the "New Inline Comment" click removes the "copy selection" behavior and creates a flash where both sides of the diff are selected.

This doesn't happen with (most) normal clicks because mouse down on a non-grabbable element clears the document selection.

To avoid this, don't reset the copy selection behavior if the user mouses down on an "<a />". This might not be robust, but seems simple and plausible as a fix.

Test Plan
  • See above.
  • Before patch: flash of overbroad selection when clicking "New Inline Comment".
  • After patch: no selection flash.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 14, 6:40 PM
epriestley requested review of this revision.Thu, May 14, 6:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 9:29 PM
This revision was automatically updated to reflect the committed changes.