Page MenuHomePhabricator

When an inline was left on a rendered DocumentEngine document, don't include an email context patch
ClosedPublic

Authored by epriestley on Tue, May 12, 9:09 PM.

Details

Summary

Ref T13513. If you leave an inline on line 20 of a Jupyter document, we currently render context around *raw* line 20, which is inevitably some unrelated piece of JSON.

Instead, drop this context. (Ideal behavior would be to render context around Jupyter block 20, but that's a whole lot of work.)

Test Plan
  • On Jupyter changes and normal source changes, made and submitted inline comments, then viewed text and HTML mail.
  • Saw no context on Jupyter comments (instead of bad context), and unchanged behavior (useful context) on normal source changes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 12, 9:09 PM
epriestley requested review of this revision.Tue, May 12, 9:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 12, 9:34 PM
This revision was automatically updated to reflect the committed changes.