Page MenuHomePhabricator

Distinguish more carefully between "null" inline offsets and "0" inline offsets
ClosedPublic

Authored by epriestley on May 14 2020, 5:57 PM.
Tags
None
Referenced Files
F19008097: D21252.diff
Fri, Nov 21, 9:31 PM
F18938375: D21252.id50608.diff
Tue, Nov 11, 3:11 AM
F18935895: D21252.diff
Mon, Nov 10, 7:12 PM
F18808910: D21252.id50613.diff
Oct 19 2025, 9:42 AM
F18807929: D21252.id.diff
Oct 19 2025, 3:57 AM
F18806832: D21252.diff
Oct 18 2025, 9:45 PM
F18797544: D21252.diff
Oct 17 2025, 5:10 AM
F18760135: D21252.id50613.diff
Oct 6 2025, 8:10 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, when creating an inline by selecting a line range, slightly careless handling leads to an inline with "0" offsets (by passing "undefined" to the server). This causes the block to highlight every line except the last one as fully bright, which is incorrect.

An inline with "0" offsets and an inline with no offsets are different. Be more careful about passing offsets around and rendering them.

Test Plan
  • Used the line numbers to add an inline to lines 4-8 of a change.
  • Hovered the inline.
  • Saw all four lines marked as "dull"-highlighted (previously: three bright lines, one dull line).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:27 PM
This revision was automatically updated to reflect the committed changes.