Page MenuHomePhabricator

When users click headers to select diff UI elements, don't eat the events
ClosedPublic

Authored by epriestley on Thu, May 14, 6:46 PM.

Details

Summary

Ref T13513. Currently, clicking inline or changeset headers eats the click events. This doesn't serve any clear purpose, and means these clicks do not clear text selections from the document, which is unusual.

Test Plan
  • Selected some text in a diff.
  • Clicked a changeset header to select it.
  • Before patch: text selection and context menu were retained.
  • After patch: text selection was cleared and context menu was dismissed.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 14, 6:46 PM
epriestley requested review of this revision.Thu, May 14, 6:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 9:34 PM
This revision was automatically updated to reflect the committed changes.