Page MenuHomePhabricator

When users click headers to select diff UI elements, don't eat the events
ClosedPublic

Authored by epriestley on May 14 2020, 6:46 PM.

Details

Summary

Ref T13513. Currently, clicking inline or changeset headers eats the click events. This doesn't serve any clear purpose, and means these clicks do not clear text selections from the document, which is unusual.

Test Plan
  • Selected some text in a diff.
  • Clicked a changeset header to select it.
  • Before patch: text selection and context menu were retained.
  • After patch: text selection was cleared and context menu was dismissed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:34 PM
This revision was automatically updated to reflect the committed changes.