Page MenuHomePhabricator

When cancelling an inline comment edit, exit the edit state after the response arrives
ClosedPublic

Authored by epriestley on May 14 2020, 6:19 PM.
Tags
None
Referenced Files
F17637196: D21253.id50614.diff
Fri, Jul 11, 1:23 PM
Unknown Object (File)
Jun 5 2025, 4:55 PM
Unknown Object (File)
Jun 2 2025, 10:30 PM
Unknown Object (File)
Jun 2 2025, 8:57 PM
Unknown Object (File)
Jun 1 2025, 7:58 PM
Unknown Object (File)
May 31 2025, 1:42 PM
Unknown Object (File)
May 11 2025, 5:02 PM
Unknown Object (File)
May 9 2025, 4:16 AM
Subscribers
None

Details

Summary

Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan
  • Clicked a line number.
  • Typed some text.
  • Clicked "Cancel".
  • Before patch: paths panel flashes "1".
  • After patch: paths panel stays stable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable