Page MenuHomePhabricator

When cancelling an inline comment edit, exit the edit state after the response arrives
ClosedPublic

Authored by epriestley on Thu, May 14, 6:19 PM.

Details

Summary

Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan
  • Clicked a line number.
  • Typed some text.
  • Clicked "Cancel".
  • Before patch: paths panel flashes "1".
  • After patch: paths panel stays stable.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 14, 6:19 PM
epriestley requested review of this revision.Thu, May 14, 6:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 9:28 PM
This revision was automatically updated to reflect the committed changes.