Page MenuHomePhabricator

When cancelling an inline comment edit, exit the edit state after the response arrives
ClosedPublic

Authored by epriestley on May 14 2020, 6:19 PM.
Tags
None
Referenced Files
F11397098: D21253.id50614.diff
Sun, Nov 27, 10:41 PM
Unknown Object (File)
Mon, Nov 21, 12:25 PM
Unknown Object (File)
Tue, Nov 15, 6:21 AM
Unknown Object (File)
Tue, Nov 15, 6:20 AM
Unknown Object (File)
Tue, Nov 15, 6:19 AM
Unknown Object (File)
Sat, Nov 5, 5:55 PM
Unknown Object (File)
Sep 21 2022, 2:43 PM
Unknown Object (File)
Sep 18 2022, 5:46 AM
Subscribers
None

Details

Summary

Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan
  • Clicked a line number.
  • Typed some text.
  • Clicked "Cancel".
  • Before patch: paths panel flashes "1".
  • After patch: paths panel stays stable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable