Page MenuHomePhabricator
Differential D21256

Give selected inline comments are more obvious selected state
ClosedPublic
Actions

Authored by epriestley on May 14 2020, 8:18 PM.
Tags
None
Referenced Files
F18112347: D21256.diff
Tue, Aug 12, 4:27 PM
F18110139: D21256.id50612.diff
Mon, Aug 11, 4:33 PM
F18104890: D21256.id.diff
Sun, Aug 10, 2:47 PM
F18104547: D21256.id.diff
Sun, Aug 10, 1:06 PM
F18104233: D21256.diff
Sun, Aug 10, 10:49 AM
F18099931: D21256.diff
Sat, Aug 9, 9:33 AM
Unknown Object (File)
Jun 5 2025, 4:55 PM
Unknown Object (File)
Jun 1 2025, 7:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rPfbd57ad83232: Give selected inline comments are more obvious selected state
Summary

Ref T13513. Give selected inlines a selection state and visual cues which are similar to the changeset selection state.

Also fix a couple of minor issues with select interactions and offset comments.

Test Plan

Selected inlines, saw obvious visual cues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 14 2020, 8:18 PM
Harbormaster completed remote builds in B24429: Diff 50612.May 14 2020, 8:19 PM
epriestley requested review of this revision.May 14 2020, 8:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:36 PM
Closed by commit rPfbd57ad83232: Give selected inline comments are more obvious selected state (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPfbd57ad83232: Give selected inline comments are more obvious selected state.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
celerity/
postprocessor/
2 lines
infrastructure/
diff/
view/
16 lines
webroot/
rsrc/
css/
application/
differential/
35 lines
js/
application/
diff/
15 lines
27 lines
28 lines

Diff 50617

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility