Differential D21249

Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 8:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 6, 3:33 AM

	Unknown Object (File)
	Thu, Jan 30, 3:47 AM

	Unknown Object (File)
	Mon, Jan 27, 4:21 PM

	Unknown Object (File)
	Mon, Jan 27, 5:36 AM

	Unknown Object (File)
	Sat, Jan 25, 7:40 AM

	Unknown Object (File)
	Sat, Jan 25, 7:40 AM

	Unknown Object (File)
	Sat, Jan 25, 7:40 AM

	Unknown Object (File)
	Thu, Jan 23, 10:30 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs

Summary

Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.

Test Plan

Selected multiple lines of content in Firefox, got an option to add a comment.
Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 13 2020, 8:47 PM

Harbormaster completed remote builds in B24416: Diff 50599.May 13 2020, 8:48 PM

epriestley requested review of this revision.May 13 2020, 8:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:19 AM

Closed by commit rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

68 lines

Diff 50604

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...