Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 8:47 PM.

Tags

None

Referenced Files

	F18306296: D21249.id50599.diff
	Sun, Aug 24, 12:38 AM

	F18162607: D21249.id50599.diff
	Fri, Aug 15, 4:46 AM

	F18133515: D21249.id50604.diff
	Wed, Aug 13, 10:59 PM

	F18112340: D21249.diff
	Tue, Aug 12, 4:26 PM

	F18110377: D21249.id.diff
	Mon, Aug 11, 7:04 PM

	F18105013: D21249.diff
	Sun, Aug 10, 3:43 PM

	F17740522: D21249.diff
	Jul 21 2025, 6:16 AM

	F17738441: D21249.id.diff
	Jul 20 2025, 11:45 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs

Summary

Ref T13513.

Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.

Test Plan

Selected multiple lines of content in Firefox, got an option to add a comment.
Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 13 2020, 8:47 PM

Harbormaster completed remote builds in B24416: Diff 50599.May 13 2020, 8:48 PM

epriestley requested review of this revision.May 13 2020, 8:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:19 AM

Closed by commit rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

68 lines

Diff 50604

View Options

resources/celerity/map.php