Page MenuHomePhabricator

Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic

Authored by epriestley on Wed, May 13, 8:47 PM.

Details

Summary

Ref T13513.

  • Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
  • Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.
Test Plan
  • Selected multiple lines of content in Firefox, got an option to add a comment.
  • Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 13, 8:47 PM
epriestley requested review of this revision.Wed, May 13, 8:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 12:19 AM
This revision was automatically updated to reflect the committed changes.