Improve select-to-comment behavior in Firefox and on unified diffs
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 8:47 PM.

Tags

None

Referenced Files

	F15577226: D21249.diff
	Tue, May 6, 12:58 PM

	F15564635: D21249.diff
	Wed, Apr 30, 1:09 PM

	F15564543: D21249.id50599.diff
	Wed, Apr 30, 12:46 PM

	F15465828: D21249.id50604.diff
	Apr 2 2025, 11:36 PM

	F15457061: D21249.diff
	Mar 30 2025, 2:04 PM

	F15442167: D21249.id50604.diff
	Mar 26 2025, 9:54 PM

	F15424809: D21249.diff
	Mar 23 2025, 12:22 AM

	F15415947: D21249.id50604.diff
	Mar 20 2025, 8:31 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs

Summary

Ref T13513.

Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.

Test Plan

Selected multiple lines of content in Firefox, got an option to add a comment.
Selected content in unified mode, got an option to add a comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 13 2020, 8:47 PM

Harbormaster completed remote builds in B24416: Diff 50599.May 13 2020, 8:48 PM

epriestley requested review of this revision.May 13 2020, 8:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:19 AM

Closed by commit rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPebef22ccc1bb: Improve select-to-comment behavior in Firefox and on unified diffs.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

68 lines

Diff 50604

View Options

resources/celerity/map.php