Page MenuHomePhabricator

Use a more consistent inline highlighting style with fewer redraws
ClosedPublic

Authored by epriestley on Fri, May 15, 7:42 PM.

Details

Summary

Ref T13513. The on-hover-inline reticle has switched over to have cell-based behavior. Switch the on-hover-line-number reticle to use the same behavior.

Also, clean up the dirty/redraw loop slightly: we no longer need to dirty on resize, and we don't need to redraw if the range isn't actually dirty.

Test Plan

Highlighted lines and line ranges. Hovered over inlines.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 15, 7:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 15, 7:44 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.