Page MenuHomePhabricator

Use a more consistent inline highlighting style with fewer redraws
ClosedPublic

Authored by epriestley on May 15 2020, 7:42 PM.
Tags
None
Referenced Files
F17617989: D21262.diff
Wed, Jul 9, 5:04 PM
Unknown Object (File)
Jun 5 2025, 4:55 PM
Unknown Object (File)
Jun 1 2025, 5:03 PM
Unknown Object (File)
May 31 2025, 4:10 PM
Unknown Object (File)
May 29 2025, 7:12 AM
Unknown Object (File)
Apr 30 2025, 4:26 PM
Unknown Object (File)
Apr 29 2025, 4:33 PM
Unknown Object (File)
Mar 30 2025, 6:14 PM
Subscribers
None

Details

Summary

Ref T13513. The on-hover-inline reticle has switched over to have cell-based behavior. Switch the on-hover-line-number reticle to use the same behavior.

Also, clean up the dirty/redraw loop slightly: we no longer need to dirty on resize, and we don't need to redraw if the range isn't actually dirty.

Test Plan

Highlighted lines and line ranges. Hovered over inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 7:44 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.