Page MenuHomePhabricator

Make "View as Document Type..." only show valid options
ClosedPublic

Authored by epriestley on Tue, May 12, 8:33 PM.

Details

Summary

Ref T13513. Currently, "View as Document Type..." lists every available engine.

This is hard to get completely right because we can't always rebuild the document ref accurately in the endpoint, but try harder to fake something reasonable.

Test Plan

Used "View as Document Type..." on Jupyter notebooks, was given "Jupyter" and "Source" as options.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 12, 8:33 PM
epriestley requested review of this revision.Tue, May 12, 8:34 PM
epriestley updated this revision to Diff 50585.Tue, May 12, 8:38 PM
  • Also restrict the list for changes with no candidate engines.
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 12, 9:25 PM
This revision was automatically updated to reflect the committed changes.