Page MenuHomePhabricator

Make "View as Document Type..." only show valid options
ClosedPublic

Authored by epriestley on May 12 2020, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 3:23 AM
Unknown Object (File)
Jan 9 2024, 8:11 AM
Unknown Object (File)
Dec 25 2023, 7:55 AM
Unknown Object (File)
Dec 23 2023, 5:48 PM
Unknown Object (File)
Dec 18 2023, 11:53 AM
Unknown Object (File)
Dec 13 2023, 5:55 PM
Unknown Object (File)
Dec 13 2023, 3:31 AM
Unknown Object (File)
Dec 12 2023, 8:34 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, "View as Document Type..." lists every available engine.

This is hard to get completely right because we can't always rebuild the document ref accurately in the endpoint, but try harder to fake something reasonable.

Test Plan

Used "View as Document Type..." on Jupyter notebooks, was given "Jupyter" and "Source" as options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Also restrict the list for changes with no candidate engines.
This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 9:25 PM
This revision was automatically updated to reflect the committed changes.