Page MenuHomePhabricator

Improve offset/range inline behavior for rich diffs and unified diffs

Authored by epriestley on May 14 2020, 10:53 PM.
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:47 AM
Unknown Object (File)
Fri, Apr 5, 8:06 PM
Unknown Object (File)
Fri, Mar 29, 4:00 PM
Unknown Object (File)
Fri, Mar 29, 1:17 AM
Unknown Object (File)
Sun, Mar 24, 8:26 PM
Unknown Object (File)
Feb 9 2024, 8:01 PM
Unknown Object (File)
Jan 15 2024, 5:27 PM
Unknown Object (File)
Jan 10 2024, 6:44 AM



Ref T13513. The way I'm highlighting lines won't work for Jupyter notebooks or other complex content blocks, and I don't see an obvious way to make it work that's reasonably robust.

However, we can just ignore the range behavior for complex content and treat the entire block as selected. This isn't quite as fancy as the source behavior, but pretty good.

Also, adjust unified diff behavior to work correctly with highlighting and range selection.

Test Plan
  • Used range selection in a Jupyter notebook, got reasonable behavior (range is treated as "entire block").
  • Used range selection in a unified diff, got equivalent behavior to 2-up diffs.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.