Page MenuHomePhabricator

Improve offset/range inline behavior for rich diffs and unified diffs
ClosedPublic

Authored by epriestley on Thu, May 14, 10:53 PM.

Details

Summary

Ref T13513. The way I'm highlighting lines won't work for Jupyter notebooks or other complex content blocks, and I don't see an obvious way to make it work that's reasonably robust.

However, we can just ignore the range behavior for complex content and treat the entire block as selected. This isn't quite as fancy as the source behavior, but pretty good.

Also, adjust unified diff behavior to work correctly with highlighting and range selection.

Test Plan
  • Used range selection in a Jupyter notebook, got reasonable behavior (range is treated as "entire block").
  • Used range selection in a unified diff, got equivalent behavior to 2-up diffs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 14, 10:53 PM
epriestley requested review of this revision.Thu, May 14, 10:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 14, 11:02 PM
This revision was automatically updated to reflect the committed changes.