Page MenuHomePhabricator

When creating an inline, save the current document engine
ClosedPublic

Authored by epriestley on Tue, May 12, 7:19 PM.

Details

Summary

Ref T13513. As part of inline metadata, save the document engine the change is being rendered with.

This will allow other parts of the UI to detect that an inline was created on a Jupyter notebook but is being rendered on raw source, or whatever else.

The immediate goal is to fix nonsensical inline snippet rendering in email on Jupyter notebooks.

Test Plan
  • Created inlines and replies on normal soure code, saw no document engine annotated in the database.
  • Created inlines and replies on a Jupyter notebook rendered in Jupyter mode, saw "jupyter" annotations in the database.
  • Swapped document engines between Jupyter and Source, etc.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, May 12, 7:19 PM
epriestley requested review of this revision.Tue, May 12, 7:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 12, 9:25 PM
This revision was automatically updated to reflect the committed changes.