Mar 17 2021
When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.
Mar 15 2021
May 23 2020
- In previews, suggestions aren't highlighted properly (likely just missing CSS).
May 21 2020
- j, etc., can incorrectly select blocks inside a diff inside a suggestion.
May 20 2020
I made a change to drop unchanged context from suggestion views, but I don't particularly like it. It changed this:
- Inline comments with suggestions don't "know" that they're empty when the suggestion is the same as the context text.
- Create an inline. Suggest edit. Don't change anything. Save. You get a blank inline with no suggestion and no content, when this inline would normally delete itself.
The inline comment context menu does not apply the correct cursor ("pointer").
I still have a lot of inline style attributes to clean up and then I'm sure there will be a long tail of weird edge cases, but this is getting pretty close:
May 19 2020
- This isn't necessarily terribly useful in practice, but a UI hint about whether or not we've actually saved a draft would make debugging slightly easier.
- The inline comment context menu does not apply the correct cursor ("pointer").
May 15 2020
- The line-triggered reticle should be updated to use the hover-reticle cell style.
May 14 2020
May 13 2020
- In Jupyter notebooks (and, theoretically, other rich content) we find an inner <td /> before finding the content <td />, preventing context menus from working.
- In Firefox, multi-line selections don't generate a context menu properly.
- Clicking the "New Inline Comment" action disables the oncopy behavior onmousedown but doesn't take the action until onclick. This creates a flash of selected content which spans both sides of the change and looks odd.
- Context selection doesn't activate in unified mode, maybe because data-copy stuff is being used to identify content cells.
- When you create an inline, do nothing, then click "Cancel", inlines briefly count themselves in the paths panel.
I have a patch which allows you to edit published inlines. It "works", but it causes a ton of weird side effects when you perform an edit.
Inline stuff:
May 12 2020
Probably kicking this, but: