- Add "ExecFuture->hasPID()" to simplify reading PID information.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 23 2020
Jul 23 2020
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.
The call sequence here is approximately:
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
epriestley committed rPfcb75d0503c6: Fix an issue where prose diffing may fail after hitting the PCRE backtracking… (authored by epriestley).
Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".
This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Jul 22 2020
Jul 22 2020
Please use Discourse to discuss Phabricator.
This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?
epriestley committed rP324445589b5e: (stable) Fix an issue with destruction of Revision and Diff objects with… (authored by epriestley).
(stable) Fix an issue with destruction of Revision and Diff objects with…
epriestley committed rP8f9ba4852861: Fix an issue with destruction of Revision and Diff objects with viewstates (authored by epriestley).
Fix an issue with destruction of Revision and Diff objects with viewstates
If you believe you've found a bug in Phabricator, please report it on Discourse, including complete reproduction instructions.
maroux added inline comments to D21041: Use a named remote and branches for staging to help git-lfs.
Jul 21 2020
Jul 21 2020
epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Jul 20 2020
Jul 20 2020
Jul 18 2020
Jul 18 2020
epriestley committed rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage (authored by epriestley).
(stable) Likely, fix a warning when rendering modified coverage
epriestley committed rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage (authored by epriestley).
Likely, fix a warning when rendering modified coverage
Jul 17 2020
Jul 17 2020
epriestley committed rP37ffb71c4d5e: In source views, wrap display tabs in "user-select: all" to improve cursor… (authored by epriestley).
In source views, wrap display tabs in "user-select: all" to improve cursor…
Jul 16 2020
Jul 16 2020
epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.
Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.
Is this really a harbormaster problem though? I would have located it within Differential.
Jul 12 2020
Jul 12 2020
epriestley requested review of D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
epriestley requested review of D21413: Move the view of merged changes to "DiffusionCommitGraphView".
epriestley requested review of D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Jul 11 2020
Jul 11 2020
(stable) Promote 2020 Week 27
(stable) Promote 2020 Week 27
Jul 10 2020
Jul 10 2020
Krinkle awarded T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags a Orange Medal token.
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
The broader structural issue here is:
Jul 9 2020
Jul 9 2020
epriestley added a comment to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
A second issue is that some of the "publish" behavior depends on the commit/revision relationship. This can still be sequenced correctly entirely in the publish daemon, but "close related revisions" and "publish the commit" are not entirely independent.
epriestley renamed T13361: Get rid of the "Actions" dropdown in Diffusion from Get rid of the "Actions" dropdown in in Diffusion to Get rid of the "Actions" dropdown in Diffusion.
epriestley closed T13369: When a large number of commits are pushed to a repository, import them at lower priority as Resolved.
This appears stable.
epriestley committed rP1d4d860cb5a0: Allow non-authors to "Request Review" of draft revisions (authored by epriestley).
Allow non-authors to "Request Review" of draft revisions
epriestley committed rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't… (authored by epriestley).
Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
epriestley committed rPb21b73b8dd35: Expand Revision transaction API to allow actions to vary more broadly based on… (authored by epriestley).
Expand Revision transaction API to allow actions to vary more broadly based on…
epriestley requested review of D21400: Require rows passed to "loadAllFromArray()" have unique keys.
epriestley committed rP852e368cb777: (stable) Fix an issue where querying for a large number of projects by slug… (authored by epriestley).
(stable) Fix an issue where querying for a large number of projects by slug…
epriestley committed rP73c4240415e0: Add some additional patterns to the "filter Mercurial --debug output" list (authored by epriestley).
Add some additional patterns to the "filter Mercurial --debug output" list
epriestley committed rP56838c0e3dc2: Fix an issue where querying for a large number of projects by slug could… (authored by epriestley).
Fix an issue where querying for a large number of projects by slug could…