Allow non-authors to "Request Review" of draft revisions


Allow non-authors to "Request Review" of draft revisions

See PHI1810. In situations where:

  • An author submits an urgent change for review.
  • The author pings reviewers to ask them to look at it.

...the reviewers may not be able to move the review forward if the review is currently a "Draft". They can only "Commandeer" or ask the author to "Request Review" as ways forward.

Although I'm hesitant to support review actions (particularly, "Accept") on draft revisions, I think there's no harm in allowing reviewers to skip tests and promote the revision out of draft as an explicit action.

Additionally, lightly specialize some of the transaction strings to distinguish between "request review from draft" and other state transitions.

Test Plan:

  • As an author, used "Request Review" to promote a draft and to return a change to reviewers for consideration. These behaviors are unchanged, except "promote a draft" has different timeline text.
  • As a non-author, used "Begin Review" to promote a draft.

Differential Revision: https://secure.phabricator.com/D21403


epriestleyAuthored on Jul 9 2020, 8:30 PM
epriestleyPushed on Jul 9 2020, 9:20 PM
Differential Revision
D21403: Allow non-authors to "Request Review" of draft revisions
rP6e85b521fe86: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
Build Status
Buildable 24765
Build 34154: Run Core Tests